From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Tao Fang <fangtao0901@gmail.com>
Cc: 11788@debbugs.gnu.org, schwab@linux-m68k.org, ivan@siamics.net,
David Engster <deng@randomsample.de>
Subject: bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly
Date: Sun, 20 Mar 2016 12:21:09 +0100 [thread overview]
Message-ID: <m31t75l7iy.fsf@gnus.org> (raw)
In-Reply-To: <87d1qvwxo0.fsf@gmail.com> (Tao Fang's message of "Tue, 15 Mar 2016 23:47:27 +0800")
Tao Fang <fangtao0901@gmail.com> writes:
> I've received notice email of the assignment/disclaimer process with the
> FSF yesterday, and currently it's complete, please check the file to see
> if it's all okay?
Your assignment is now on file...
> And I've re-format the previous attached patch file and maybe somebody
> could helping review, modify and apply it to the repo?
Looks basically good, but a few notes:
> - (let ((proc (url-open-stream host buf host port gateway-method)))
> + (let ((proc (url-open-stream host buf
> + (if url-using-proxy (url-host url-using-proxy) host)
> + (if url-using-proxy (url-port url-using-proxy) port)
> + gateway-method)))
Throughout the code, the lines seem to be too long. They should
preferably not be more than 80 characters long (unless there's an
absolute need).
[...]
> + (let ((tls-connection (gnutls-negotiate
> + :process proc
> + :hostname (url-host url-current-object)
> + :verify-error nil)))
After negotiation, you should probably call `nsm-verify-connection'.
Uhm... and that's it. Oh, and a NEWS entry saying that url now
supports HTTPS proxies would be nice, and a ChangeLog style commit
message.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-03-20 11:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 10:11 bug#11788: url-http does not properly handle https over proxy Andreas Schwab
2013-12-03 8:31 ` bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly Ivan Shmakov
2015-07-24 16:32 ` lo2net
2015-12-25 21:31 ` Lars Ingebrigtsen
2015-12-26 7:24 ` Eli Zaretskii
2015-12-30 16:16 ` lo2net
2015-12-30 16:50 ` Eli Zaretskii
2016-03-08 19:41 ` David Engster
2016-03-08 20:05 ` Eli Zaretskii
2016-03-15 15:47 ` Tao Fang
2016-03-16 16:23 ` Eli Zaretskii
2016-03-20 11:21 ` Lars Magne Ingebrigtsen [this message]
2016-03-22 15:31 ` Tao Fang
2016-04-04 20:21 ` Lars Magne Ingebrigtsen
2016-04-05 20:34 ` David Engster
2016-04-06 11:46 ` Lars Magne Ingebrigtsen
2016-04-06 18:01 ` David Engster
2016-04-06 18:09 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31t75l7iy.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=11788@debbugs.gnu.org \
--cc=deng@randomsample.de \
--cc=fangtao0901@gmail.com \
--cc=ivan@siamics.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.