Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt

Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt

[Stefan Monnier]

> +(require 'cl-extra)

Please require cl-lib instead: the division into cl-(lib|macs|seq|extra)
is supposed to be an internal implementation detail.


        Stefan

Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +(require 'cl-extra)
>
> Please require cl-lib instead: the division into cl-(lib|macs|seq|extra)
> is supposed to be an internal implementation detail.

That's what I had originally, but then I got this warning:

In end of data:
emacs-lisp/eieio-opt.el:359:1:Warning: the function `cl--describe-class' is
    not known to be defined.

Perhaps because it's an internal(ish) function?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> +(require 'cl-extra)
>>
>> Please require cl-lib instead: the division into cl-(lib|macs|seq|extra)
>> is supposed to be an internal implementation detail.
>
> That's what I had originally, but then I got this warning:
>
> In end of data:
> emacs-lisp/eieio-opt.el:359:1:Warning: the function `cl--describe-class' is
>     not known to be defined.
>
> Perhaps because it's an internal(ish) function?

Hm...  Perhaps that should have been a call to cl-describe-type instead,
despite what

(define-obsolete-function-alias 'eieio-help-class 'cl--describe-class "25.1")

says...  I'll do some testing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Hm...  Perhaps that should have been a call to cl-describe-type instead,
> despite what
>
> (define-obsolete-function-alias 'eieio-help-class 'cl--describe-class "25.1")
>
> says...  I'll do some testing.

Hm...  nope.  That function does

  (save-excursion
    (with-help-window (help-buffer)
      (with-current-buffer standard-output
        (let ((class (cl-find-class type)))
          (if class
              (cl--describe-class type class)

which isn't what we want...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt

[Stefan Monnier]

>>> +(require 'cl-extra)
>> Please require cl-lib instead: the division into cl-(lib|macs|seq|extra)
>> is supposed to be an internal implementation detail.
> That's what I had originally, but then I got this warning:
> In end of data:
> emacs-lisp/eieio-opt.el:359:1:Warning: the function `cl--describe-class' is
>     not known to be defined.
> Perhaps because it's an internal(ish) function?

Ah, yes, it's not autoloaded because it's internal.
I guess cl-extra is OK in that case, but please add a comment to
explain it.


        Stefan

Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I guess cl-extra is OK in that case, but please add a comment to
> explain it.

OK; done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no