From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24046: [PATCH] vc-git: prevent execution of git stash in error cases Date: Tue, 25 Jun 2019 14:03:03 +0200 Message-ID: References: <87vaoczcco.fsf@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="148245"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 24046@debbugs.gnu.org, Alexander Kuleshov To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 14:04:54 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfkBx-000cMq-HF for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 14:04:53 +0200 Original-Received: from localhost ([::1]:59484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfkBw-0002nH-9r for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 08:04:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33320) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfkBB-0002me-QJ for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 08:04:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfkB9-0002mt-4W for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 08:04:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45274) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfkB8-0002lm-1V for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 08:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfkB7-0002R9-Px for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 08:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 12:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24046-submit@debbugs.gnu.org id=B24046.15614641909288 (code B ref 24046); Tue, 25 Jun 2019 12:04:01 +0000 Original-Received: (at 24046) by debbugs.gnu.org; 25 Jun 2019 12:03:10 +0000 Original-Received: from localhost ([127.0.0.1]:58815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfkAH-0002Pj-Jy for submit@debbugs.gnu.org; Tue, 25 Jun 2019 08:03:10 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:47668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfkAF-0002PX-Qe for 24046@debbugs.gnu.org; Tue, 25 Jun 2019 08:03:08 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfkAC-0007jo-2V; Tue, 25 Jun 2019 14:03:06 +0200 In-Reply-To: <87vaoczcco.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sat, 03 Jun 2017 23:00:07 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161342 Archived-At: npostavs@users.sourceforge.net writes: > Alexander Kuleshov writes: > >> Here is simple patch which adds two additional checks to the vc-git-stash-show >> function to check that correct stash name is passed and actually repo >> has stashes. > > I'm not sure this is a good idea, we just end up duplicating checks that > 'git stash' is going to perform anyway... I agree, and even if we did want to add these checks, they should be done in all the stash-related commands... So I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no