From: Lars Ingebrigtsen <larsi@gnus.org>
To: npostavs@users.sourceforge.net
Cc: 24046@debbugs.gnu.org, Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: bug#24046: [PATCH] vc-git: prevent execution of git stash in error cases
Date: Tue, 25 Jun 2019 14:03:03 +0200 [thread overview]
Message-ID: <m31rzheutk.fsf@gnus.org> (raw)
In-Reply-To: <87vaoczcco.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sat, 03 Jun 2017 23:00:07 -0400")
npostavs@users.sourceforge.net writes:
> Alexander Kuleshov <kuleshovmail@gmail.com> writes:
>
>> Here is simple patch which adds two additional checks to the vc-git-stash-show
>> function to check that correct stash name is passed and actually repo
>> has stashes.
>
> I'm not sure this is a good idea, we just end up duplicating checks that
> 'git stash' is going to perform anyway...
I agree, and even if we did want to add these checks, they should be
done in all the stash-related commands...
So I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-06-25 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 12:46 bug#24046: [PATCH] vc-git: prevent execution of git stash in error cases Alexander Kuleshov
2017-06-04 3:00 ` npostavs
2019-06-25 12:03 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31rzheutk.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=24046@debbugs.gnu.org \
--cc=kuleshovmail@gmail.com \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.