all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Keith David Bershatsky <esq@lawlist.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 17585-done@debbugs.gnu.org
Subject: bug#17585: 24.4.50; vertical-motion erroneously adds points
Date: Thu, 29 May 2014 23:21:05 -0700	[thread overview]
Message-ID: <m2zjhzkcry.wl%esq@lawlist.com> (raw)
In-Reply-To: <m2a9a6iaon.wl%esq@lawlist.com>

The `test` function yields the same result with Emacs built (--with-ns) from the Trunk as of May 29, 2014 at 11:18 P.S.T.  Approximately when, please, should I expect to see the fix merged into the Trunk?

I'm using macports / baazar:

/macports/bin/bzr branch --stacked bzr://bzr.savannah.gnu.org/emacs/trunk emacs-trunk

Thanks,

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

At Sun, 25 May 2014 17:23:31 +0300,
Eli Zaretskii wrote:
> 
> > Date: Sun, 25 May 2014 00:23:20 -0700
> > From: Keith David Bershatsky <esq@lawlist.com>
> > 
> > The following test function demonstrates how vertical-motion erroneously adds points when dealing with long lines without spaces that go beyond the window-width:
> > 
> >     (defun test ()
> >     (interactive)
> >       (switch-to-buffer (get-buffer-create "foo.txt"))
> >       (text-mode)
> >       (linum-mode t)
> >       (visual-line-mode t)
> >       (dotimes (i (* (window-width) 4))
> >         (insert ";"))
> >      (dotimes (i 10)
> >         (insert "\n"))
> >       (goto-char (point-min))
> >       (vertical-motion 1)
> >       (message "Second Row + 2 points:  %s" (current-column))
> >       (vertical-motion 1)
> >       (message "Third Row + 4 points:  %s" (current-column)))
> 
> Fixed in revision 117154 on the emacs-24 branch.  The patch is below,
> in case you want to try it without waiting for it to be merged to the
> trunk.
> 
> Thanks.
> 
> --- src/xdisp.c	2014-05-24 21:28:43 +0000
> +++ src/xdisp.c	2014-05-25 14:18:46 +0000
> @@ -8556,7 +8556,7 @@ move_it_in_display_line_to (struct it *i
>  	}
>        else
>  	{
> -	  if (it->line_wrap == WORD_WRAP)
> +	  if (it->line_wrap == WORD_WRAP && it->area == TEXT_AREA)
>  	    {
>  	      if (IT_DISPLAYING_WHITESPACE (it))
>  		may_wrap = 1;





  parent reply	other threads:[~2014-05-30  6:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-25  7:23 bug#17585: 24.4.50; vertical-motion erroneously adds points Keith David Bershatsky
2014-05-25 14:23 ` Eli Zaretskii
2014-05-30  6:21 ` Keith David Bershatsky [this message]
2014-05-30  6:47   ` Eli Zaretskii
2014-05-30 16:21   ` Stefan Monnier
2014-05-31 19:00 ` Keith David Bershatsky
2014-05-31 19:11   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2zjhzkcry.wl%esq@lawlist.com \
    --to=esq@lawlist.com \
    --cc=17585-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.