From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) Newsgroups: gmane.emacs.devel Subject: Re: electric-pair-mode as a minor mode? Date: Sun, 12 Apr 2015 14:16:36 +0100 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1428844632 12474 80.91.229.3 (12 Apr 2015 13:17:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 12 Apr 2015 13:17:12 +0000 (UTC) Cc: Lars Magne Ingebrigtsen , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 12 15:17:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YhHl2-0003iI-Lr for ged-emacs-devel@m.gmane.org; Sun, 12 Apr 2015 15:17:04 +0200 Original-Received: from localhost ([::1]:45320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhHl1-0003xr-SW for ged-emacs-devel@m.gmane.org; Sun, 12 Apr 2015 09:17:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhHko-0003xY-GI for emacs-devel@gnu.org; Sun, 12 Apr 2015 09:16:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhHkl-0003Sr-8b for emacs-devel@gnu.org; Sun, 12 Apr 2015 09:16:50 -0400 Original-Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:34117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhHkl-0003Sl-12 for emacs-devel@gnu.org; Sun, 12 Apr 2015 09:16:47 -0400 Original-Received: by wgso17 with SMTP id o17so56711187wgs.1 for ; Sun, 12 Apr 2015 06:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=67FsmtRWoMmi9b6U3DYYqoGypTacD27t2hir0e7Z+wo=; b=b/CyDbGmcuLRi/wfUr46vnHgL0jIqoydkIqCFD9zz0sDTNVvh+BpCiWHqlWVRu/LFS 5KSz/hGVe4Ijym+ODQrVmeFiej+H5qe9X/LRZpBEQqd6uUn/Lkv8XomZk/j5h6GB2B16 AeDjm/Qcs/pkMCqW185elWUNJLiYz8hfdyf2TP75xxGCZhNowRXuREVFtNjmwC+tQauk J29AQfUCJNMWklLddj/5rQdh/wickX49cl708KLJ+Y734tqUEQ2gNuq3NzLJINMnkDbR 0mlmbfZbeFpY1wG2OcALO7R3BpdmLap0TWeQXxDL56RqWr8yo5x5ECHwIcPQFW8K4t9K pYEg== X-Received: by 10.180.74.144 with SMTP id t16mr13000475wiv.33.1428844606274; Sun, 12 Apr 2015 06:16:46 -0700 (PDT) Original-Received: from king.yourcompany.com (31.57.37.188.rev.vodafone.pt. [188.37.57.31]) by mx.google.com with ESMTPSA id dx11sm6984732wjb.23.2015.04.12.06.16.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Apr 2015 06:16:45 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 12 Apr 2015 07:56:46 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (darwin) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185334 Archived-At: Stefan Monnier writes: >>> I think in the case of the smiley regexps, rather than mark them as >>> comments, it's better to only change the parenthesis's syntax to be >>> "punctuation". >> Since Lars hasn't responded yet, here's an updated patch that addresses >> the issues discussed so far. OK to install? > > [ Hmm.... I'd really like Lars's input on this. > But it looks OK to me. ] Commited with your recommendations. As a side note, a spurious "Summary: " prefix slipped through in the first line of the commit message, since I ammended my local commit from the command line, with emacsclient as EDITOR and then used M-p `log-edit-previous-comment' to pull in the last message. I saw 'Summary:' fontified so assumed it would be killed by `log-edit-mode'. Something like (defun log-edit--strip-headers-maybe () (save-excursion (goto-char (point-min)) (when (and (search-forward-regexp "^Summary:[ \t]+" (line-end-position) t) (y-or-n-p "Possibly spurious \"Summary:\" header detected. Remove?")) (delete-region (match-beginning 0) (match-end 0))))) Would have helped, but I don't know where to hook it