From: John Wiegley <jwiegley@gmail.com>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Small docstring improvements
Date: Fri, 19 Aug 2016 14:12:50 -0700 [thread overview]
Message-ID: <m2zio8tqct.fsf@newartisans.com> (raw)
In-Reply-To: <CAArVCkR6i1+zRmy3wbmwkd-RW=A9BS6zMYbGhQoF9sc+rDUy-g@mail.gmail.com> (Philipp Stephani's message of "Fri, 19 Aug 2016 20:34:58 +0000")
>>>>> "PS" == Philipp Stephani <p.stephani2@gmail.com> writes:
PS> I've simply copied the docstring from write-region, which has exactly the
PS> same semantics (because call-process-region calls write-region). Like it
PS> or not, these are the semantics, and they are intentional (the code for
PS> call-process-region has explicit branches for these cases), so I think
PS> they deserve to be documented.
Yes, agreed with respect to your patch, disagree only with respect to what you
found there. :) Those explicit branches shouldn't have been written. It sounds
like its purely an attempt to avoid creating new functions for what is clearly
new functionality.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
next prev parent reply other threads:[~2016-08-19 21:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 19:26 Small docstring improvements Philipp Stephani
2016-08-19 19:34 ` John Wiegley
2016-08-19 20:34 ` Philipp Stephani
2016-08-19 21:12 ` John Wiegley [this message]
2016-08-19 22:04 ` Drew Adams
2016-08-20 0:24 ` John Wiegley
2016-08-20 7:10 ` Eli Zaretskii
2016-08-20 23:17 ` John Wiegley
2016-08-19 21:59 ` Dmitry Gutov
2016-08-20 7:08 ` Eli Zaretskii
2016-08-20 13:52 ` Philipp Stephani
2016-08-20 15:34 ` Eli Zaretskii
2016-08-20 15:59 ` Philipp Stephani
2016-08-20 16:11 ` Eli Zaretskii
2016-08-20 18:00 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zio8tqct.fsf@newartisans.com \
--to=jwiegley@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.