From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#27114: 25.2: fringe click echoes "Emacs-Lisp:" in emacs-lisp mode Date: Mon, 21 Aug 2017 15:20:14 +0200 Message-ID: References: <87y3te2awi.fsf@users.sourceforge.net> <838tldee8x.fsf@gnu.org> <87fud0731u.fsf@lylat> <83k21ycmlk.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1503321681 18055 195.159.176.226 (21 Aug 2017 13:21:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 Aug 2017 13:21:21 +0000 (UTC) Cc: agrambot@gmail.com, 27114@debbugs.gnu.org, npostavs@users.sourceforge.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 21 15:21:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djmdm-0004IC-DG for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Aug 2017 15:21:14 +0200 Original-Received: from localhost ([::1]:44511 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djmds-0000kH-Ir for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Aug 2017 09:21:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djmde-0000h6-85 for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2017 09:21:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djmda-0001hx-8c for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2017 09:21:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38711) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djmda-0001hs-4S for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2017 09:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1djmda-0006a3-0Q for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2017 09:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2017 13:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27114-submit@debbugs.gnu.org id=B27114.150332162925235 (code B ref 27114); Mon, 21 Aug 2017 13:21:01 +0000 Original-Received: (at 27114) by debbugs.gnu.org; 21 Aug 2017 13:20:29 +0000 Original-Received: from localhost ([127.0.0.1]:47392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djmd2-0006Yw-Uv for submit@debbugs.gnu.org; Mon, 21 Aug 2017 09:20:29 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:39079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djmd0-0006Yi-Jy for 27114@debbugs.gnu.org; Mon, 21 Aug 2017 09:20:27 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 1BB3E22508 for <27114@debbugs.gnu.org>; Mon, 21 Aug 2017 13:14:30 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1503321268; x=1504185269; bh=pqvD9SHt5Z4LY uyTGh5u9J+5CF3t9egyF2lRERa/haA=; b=MmgpF2ScchzHxnDDalUSAGcrqAsKU mrxpexGu77wtdsR4yxoP6kkyESmpFN730ATGrbhLeJzocA700nuUt8t9Yd+dVxzp TYp5UwqinlezRqtULyNFcdvcBI/OtEDhlxBBS6+31lV8MBmbzOmGpEMJNPz+Lbsu UIpXO9BLraPsOU= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6yDp51XPywkZ for <27114@debbugs.gnu.org>; Mon, 21 Aug 2017 13:14:28 +0000 (UTC) Original-Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 338A7224EA; Mon, 21 Aug 2017 13:14:25 +0000 (UTC) In-reply-to: <83k21ycmlk.fsf@gnu.org> (message from Eli Zaretskii on Sun, 20 Aug 2017 17:58:31 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135988 Archived-At: > Date: Sun, 20 Aug 2017 17:58:31 +0300 > From: Eli Zaretskii > > > Date: Sun, 20 Aug 2017 16:14:40 +0200 > > From: charles@aurox.ch (Charles A. Roelli) > > CC: eliz@gnu.org, npostavs@users.sourceforge.net, > > 27114@debbugs.gnu.org > > > > > --- a/lisp/progmodes/elisp-mode.el > > > +++ b/lisp/progmodes/elisp-mode.el > > > @@ -45,7 +45,7 @@ emacs-lisp-mode-syntax-table > > > "Syntax table used in `emacs-lisp-mode'.") > > > > > > (defvar emacs-lisp-mode-map > > > - (let ((map (make-sparse-keymap "Emacs-Lisp")) > > > + (let ((map (make-sparse-keymap)) > > > (menu-map (make-sparse-keymap "Emacs-Lisp")) > > > (lint-map (make-sparse-keymap)) > > > (prof-map (make-sparse-keymap)) > > > > Thanks for finding this out. The function that prints "Emacs-Lisp:" > > to the echo area during the click is "read_char_minibuf_menu_prompt" > > (keyboard.c), which calls Fkeymap_prompt (which in the scenario of > > this bug, returns "Emacs-Lisp"), and eventually executes these lines: > > > > /* Prompt with that and read response. */ > > message3_nolog (apply1 (intern ("concat"), Fnreverse (menu_strings))); > > > > Maybe it's wrong for "read_char" to call this function > > ("read_char_minibuf_menu_prompt") for some click events. > > No, it's not wrong. It's a feature: it provides visual feedback for > incomplete mouse clicks. The ELisp manual explicitly says to provide > this string, which it calls "overall prompt", for all keymaps that can > be menus. Which this keymap can. Thanks. But it seems this "overall prompt" should only be set for menu keymaps, not general mode maps. For example, (keymap-prompt lisp-interaction-mode-map) nil (keymap-prompt python-mode-map) nil (keymap-prompt c-mode-map) nil (keymap-prompt emacs-lisp-mode-map) "Emacs-Lisp" > (If you make the proposed change, and then visit some .el file and > click C-mouse-3, what do you see in the header of the pop-up menu?) I still see "Emacs-Lisp Mode" (it's unchanged). Notice that Alex's change removes the "overall prompt" from the "main" Emacs Lisp mode keymap, but not the menu-map.