From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Robert Pluim <rpluim@gmail.com>
Newsgroups: gmane.emacs.devel
Subject: Re: master e4896fc 1/2: Add a new 'flex' completion style
Date: Thu, 14 Feb 2019 13:38:50 +0100
Message-ID: <m2zhqyzgrp.fsf@gmail.com>
References: <20190213212413.868.40960@vcs0.savannah.gnu.org>
	<20190213212414.D6F4C209C6@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="123187"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@gmail.com>
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 14 13:41:45 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1guGKn-000VyF-5f
	for ged-emacs-devel@m.gmane.org; Thu, 14 Feb 2019 13:41:45 +0100
Original-Received: from localhost ([127.0.0.1]:47603 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1guGKm-00076Z-0x
	for ged-emacs-devel@m.gmane.org; Thu, 14 Feb 2019 07:41:44 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:46042)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rpluim@gmail.com>) id 1guGKf-00073r-RL
	for emacs-devel@gnu.org; Thu, 14 Feb 2019 07:41:38 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rpluim@gmail.com>) id 1guGIK-000209-CQ
	for emacs-devel@gnu.org; Thu, 14 Feb 2019 07:39:13 -0500
Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:43721)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <rpluim@gmail.com>) id 1guGII-0001ki-AR
	for emacs-devel@gnu.org; Thu, 14 Feb 2019 07:39:10 -0500
Original-Received: by mail-wr1-x431.google.com with SMTP id r2so6277907wrv.10
	for <emacs-devel@gnu.org>; Thu, 14 Feb 2019 04:38:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
	h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list
	:date:in-reply-to:message-id:mime-version:content-transfer-encoding;
	bh=Mm+CBIzjTTgSy3IhHtKlbUbwhGImaYaiHYanmIzmeQk=;
	b=uJVhMZsvgcX2mZW3cXdURWwkiuWvlETQg0jqb7p+fJy6mcmfjU05k2FJTvJ5niuOrq
	4J7cJKcN2NrU9HMF8elwTtEWK6yA0aR0T7sQy3iNCZ+g/xXjxfMU+KEmEf32gw/1NcjZ
	h9RYhQTb2Jpe+9odbT10o28MUkZwQRR+rwcXarKaFVPQrrf4OGKgrDoJ0qw0ZlA/eW4N
	+UOMxbbnTdzURo+grEf4dzomyPjO0+glsf6M57sGOzj4Yca4NYyx4JEGH63U1TpnUFCV
	9iEs8pNaqbjzu1wVU6VkVUncgyUDsEg9iX+Zgv/cXBprdbrf4zb/kWIS98FNAtdYeY1T
	pMMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20161025;
	h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to
	:gmane-reply-to-list:date:in-reply-to:message-id:mime-version
	:content-transfer-encoding;
	bh=Mm+CBIzjTTgSy3IhHtKlbUbwhGImaYaiHYanmIzmeQk=;
	b=CWC4Ss2WJlvrD9eoupuPH+NQFa/Jes5ZyDQ3xmgBRhqBB33FNwNX7h3gdlCZOT+O4i
	5aA2iXGxwLcSI6qBq5gMUkX/LXWL/h5cQdh+7rHvoxdYZc9PK3CFn2QHzY3NCTlNY5/O
	wF3DA/gDwhaHh5swjJsylVGCheqYTZUUJYaW3khTrlBebegOnXfsDqkEi5yk1IQcNvYb
	EsqsLj0M5A5cP3w6ObmrYiOO5FMXMXWCJ1tc7O5twxe7+l/IvgM14AH17YZBDO9ro5us
	my9lcxaWCiIR7v2SIFtEjdQm8NcUhUUTh3wANufmqK3IQgZj+k5VjgfGSiKlTVKxPSYt
	n57g==
X-Gm-Message-State: AHQUAubhmfRANqtzHBZm3eQLWii3A1O+4U2xo4NYj9FFM+DnrJGEDkEm
	U8uUGIzcjdzz+csUZUQanMI=
X-Google-Smtp-Source: AHgI3IbGO6JjRN0nuBlitSW6B7k/U5cNGj+ZalN5+lkzkxliCgppbRWLmOREwllO2dnY42QifdebNA==
X-Received: by 2002:adf:90af:: with SMTP id i44mr2666158wri.222.1550147931948; 
	Thu, 14 Feb 2019 04:38:51 -0800 (PST)
Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id
	k20sm4384166wre.41.2019.02.14.04.38.50
	(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
	Thu, 14 Feb 2019 04:38:51 -0800 (PST)
Mail-Copies-To: never
Gmane-Reply-To-List: yes
In-Reply-To: <20190213212414.D6F4C209C6@vcs0.savannah.gnu.org>
	(unknown@unknown.invalid's message of "Wed, 13 Feb 2019 16:24:14 -0500
	(EST)")
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 2a00:1450:4864:20::431
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:233310
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/233310>

Unknown <unknown@unknown.invalid> writes:

> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index b757eb8..c1e3fdc 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -788,6 +788,11 @@ Additionally the user can use the char \"*\" as a gl=
ob pattern.")
>  I.e. when completing \"foo_bar\" (where _ is the position of point),
>  it will consider all completions candidates matching the glob
>  pattern \"*foo*bar*\".")
> +    (flex
> +     completion-flex-try-completion completion-flex-all-completions
> +     "Completion of an in-order subset of characters.
> +When completing \"foo\" the glob \"*f*o*o*\" is used, so that
> +i.e. foo can complete to frodo.")

I think you can either drop the 'i.e.', or drop 'so that'.

>      (initials
>       completion-initials-try-completion completion-initials-all-completi=
ons
>       "Completion of acronyms and initialisms.
> @@ -3345,7 +3350,12 @@ the same set of elements."
>  ;;; Substring completion
>  ;; Mostly derived from the code of `basic' completion.
>=20=20
> -(defun completion-substring--all-completions (string table pred point)
> +(defun completion-substring--all-completions
> +    (string table pred point &optional transform-pattern-fn)
> +  "Match the presumed substring STRING to the entries in TABLE.
> +Respect PRED and POINT.  The pattern used is a PCM-style
> +substring pattern, but it be massaged by TRANSFORM-PATTERN-FN, if
> +that is non-nil."

I=CA=BCm all in favour of respect, but what does that mean in the context
of PRED and POINT?

What is 'PCM-style'? What does 'massaged' mean? What is the signature of
TRANSFORM-PATTERN-FN?

Robert