From: Robert Pluim <rpluim@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Marcin Borkowski <mbork@mbork.pl>, 35502@debbugs.gnu.org
Subject: bug#35502: 27.0.50; encode-time apparently stopped working
Date: Tue, 30 Apr 2019 20:00:50 +0200 [thread overview]
Message-ID: <m2zho74bl9.fsf@gmail.com> (raw)
In-Reply-To: <bc33752d-65ff-c7e0-5232-4f6d7700b9b1@cs.ucla.edu> (Paul Eggert's message of "Tue, 30 Apr 2019 10:54:48 -0700")
>>>>> On Tue, 30 Apr 2019 10:54:48 -0700, Paul Eggert <eggert@cs.ucla.edu> said:
Paul> Although I don't use macOS I rigged up a version of mktime
Paul> on Fedora that reproduced the problem. The bug I found
Paul> doesn't have anything to do with ATTRIBUTE_COLD; it's an
Paul> unportable assumption in the emacs/src/timefns.c. I
Paul> installed the attached into master to fix the bug I found;
Paul> please give it a try.
My first reaction was "that¼s the wrong branch of the code, nargs ==
9", and then my brain reset. Time to walk away from the computer for a
while.
That patch fixes roundtripping for me, thanks.
Paul> * src/timefns.c (Fencode_time): Ignore DST flag when the
Paul> zone is numeric or is a cons, as the doc string says
Paul> it€s ignored in that case, and not ignoring it
^^^
That shows as "\xe2\x80\x99" for me in Gnus. I thought commit messages
were supposed to be ASCII only?
Robert
next prev parent reply other threads:[~2019-04-30 18:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 9:23 bug#35502: 27.0.50; encode-time apparently stopped working Marcin Borkowski
2019-04-30 15:17 ` Eli Zaretskii
2019-04-30 15:39 ` Robert Pluim
2019-04-30 15:43 ` Eli Zaretskii
2019-04-30 15:55 ` Robert Pluim
2019-04-30 16:08 ` Eli Zaretskii
2019-04-30 16:16 ` Robert Pluim
2019-04-30 15:40 ` Marcin Borkowski
2019-04-30 16:14 ` Eli Zaretskii
2019-04-30 17:54 ` Paul Eggert
2019-04-30 18:00 ` Robert Pluim [this message]
2019-04-30 19:40 ` Paul Eggert
2019-04-30 20:16 ` Marcin Borkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zho74bl9.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=35502@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=mbork@mbork.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.