From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#35389: 27.0.50; [PATCH] Emacs on macOS sets mouse-wheel variables directly Date: Sat, 11 May 2019 11:54:13 +0200 Message-ID: References: <87y341q8cb.fsf@gmail.com> <83y33edr2a.fsf@gnu.org> <20190510212531.GA82150@breton.holly.idiocy.org> <83sgtleczm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="203725"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35389@debbugs.gnu.org, Alan Third , npostavs@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 11 11:55:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPOik-000qtI-FD for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 May 2019 11:55:10 +0200 Original-Received: from localhost ([127.0.0.1]:56605 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPOij-0007BC-E0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 May 2019 05:55:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPOid-0007Au-Gc for bug-gnu-emacs@gnu.org; Sat, 11 May 2019 05:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPOic-0005Nw-CC for bug-gnu-emacs@gnu.org; Sat, 11 May 2019 05:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPOic-0005Nl-8S for bug-gnu-emacs@gnu.org; Sat, 11 May 2019 05:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hPOib-0007xD-Rg for bug-gnu-emacs@gnu.org; Sat, 11 May 2019 05:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 May 2019 09:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35389 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35389-submit@debbugs.gnu.org id=B35389.155756846630526 (code B ref 35389); Sat, 11 May 2019 09:55:01 +0000 Original-Received: (at 35389) by debbugs.gnu.org; 11 May 2019 09:54:26 +0000 Original-Received: from localhost ([127.0.0.1]:39907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPOhz-0007wG-S6 for submit@debbugs.gnu.org; Sat, 11 May 2019 05:54:24 -0400 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:35005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPOhx-0007w3-PE for 35389@debbugs.gnu.org; Sat, 11 May 2019 05:54:22 -0400 Original-Received: by mail-wm1-f53.google.com with SMTP id q15so5549743wmj.0 for <35389@debbugs.gnu.org>; Sat, 11 May 2019 02:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=sr3aRlA6jTjVBBgXRNB6OSiwwd15t3ScMz8oizrtF70=; b=O+i+EYHTWBspezlOG2ffbUdRCF1lOQ5qGoOxfyQop9T8J08HeE2PqTGxAlAdiJCuER eVvYgDjEFLvWjdfFGUcmAaRZRi3gnG6voJEvWFdeb/9un70YC36r2LonY1gb/Yc2FWcG a26VwQAMZomzk2bwddKs4YP5ox1WNIUI4NirNftM1Usts+ObPKE8M2v/EeyPTpntPeCk zK0DSKSGx5/MsXflKk3iFhGWmh9CRmYkD/gh4LsL+ZFsvBR8qu7/EFAN1wySJ1V8pWx9 Z+aElWi8LHZhkME2sXhCZX0PcndacVtQz8+kZKW8ZDXzhIJ/+wfsNB2Nnimg8h1OECGL IJbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=sr3aRlA6jTjVBBgXRNB6OSiwwd15t3ScMz8oizrtF70=; b=dVBS6zmG5kwVIHaUlBH6EtILwNYY1NTak/2IN7gTUF8J/C1h1QoV8aHcpxkcJX2VaL 6waD13O7I5KxT1TEyl4PQvW/w75OQDDwDSL4HE4ukdwQkcF7Upo0MK5zmj3QeUxJbi1n P7zkh/kkj7UvnbFgdH2hdFptGucx/QSIdTv/YOSG0t8jmykOC+u2wnKQwPoR55kx962U XJ80J8G61If55MwqIabRW+I6I6VzbBZMdIvQUppSqk7KOflNiv/TJW3CsfGsK6s9NtqD skeNYxoUnnxhlqg5u0ukIrkJov1tjQ9pQNo6kX3PIDPxTGNYIr1EQhlam0aMntMwDLIx XNAQ== X-Gm-Message-State: APjAAAW2nyMx2UQew8y5po/ZCB5cUviSIZ1sqCvyxsAHeREdDYMTLe+v OoYA5TOe/SjPIL83FwlYJBk= X-Google-Smtp-Source: APXvYqxeYTgkGhWPWy2uTp/8Uouul0VDGwqrBRWrws5sT0dgldF+udBBPZ7SJnosyo+Y0m73m/EHgQ== X-Received: by 2002:a7b:cc01:: with SMTP id f1mr9469194wmh.78.1557568455704; Sat, 11 May 2019 02:54:15 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:5197:f2f2:1d4e:f66b]) by smtp.gmail.com with ESMTPSA id o6sm19239859wrh.55.2019.05.11.02.54.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 11 May 2019 02:54:14 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <83sgtleczm.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 11 May 2019 09:12:13 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159071 Archived-At: >>>>> On Sat, 11 May 2019 09:12:13 +0300, Eli Zaretskii said: >> Date: Fri, 10 May 2019 22:25:31 +0100 From: Alan Third >> Cc: Robert Pluim , >> 35389@debbugs.gnu.org, npostavs@gmail.com >>=20 >> > Why does that system configuration need a different default >> to begin > with? In general, having different defaults on >> different systems is > not a good idea. >>=20 >> macOS 10.7+ handles wheel scrolling differently from how other >> systems handle it. If we stick with the defaults then it >> becomes uncontrollably fast, the current defaults make it feel >> similar to X, Windows, etc. >>=20 >> IIRC, fixing it in C is probably possible, but not as straight >> forward as just changing the defaults. There was discussion of >> it in Emacs devel at the time and only one person objected, but >> later changed their mind. Could you give a time range for when that was discussed? Eli> Could there be some internal variable, either in Lisp or in Eli> C, which we then would use in the default value, as some Eli> unit, instead of just number of wheel turns and number of Eli> lines? Then we could set that internal variable to different Eli> values, but keep the customization the same in those Eli> internally-defined units. I think that would be somewhat Eli> cleaner, if possible and reasonable, because we'd be able to Eli> document the customization in these units in a Eli> platform-independent way. I can=CA=BCt think of a single variable you could use to transform (5 ((shift) . 1) ((control) . nil))) to (1 ((shift) . 5) ((control))) unless you want to start doing 'on macOS >=3D 10.7, divide by 5 if no modifiers, multiply by five if shift', which could be done in lisp in `mwheel-scroll', but it feels very hacky. (as an aside ((control) . nil) is the same as ((control)), so we should change one or the other) Eli> If that's impractical, then I guess we'll have to live with Eli> this inconsistency, although I personally consider it a Eli> slippery slope. At the very least it should be documented, Eli> in NEWS if not in the manual. Noam's original suggestion of patching ns-win.el might be best, then, as it avoids any changes to the defcustom's. >> > Also, the original patch mentioned a specific version of >> appkit, > whereas this one is more general, AFAIU. Wouldn't >> that cause trouble > or surprise elsewhere? >>=20 >> We still support macOS 10.6, which behaves similarly to X and >> Windows. Changing the defaults for it would result in >> unexpected behaviour. Thanks, I wasn't sure if 10.6 was still supported, so we'll have to cater for that. Eli> Are you saying that testing the OS version and testing the Eli> appkit version yield the same result in this case? Or are Eli> you saying that testing the appkit version is simply Eli> incorrect? Because that was my concern. I think testing the appkit version is correct (but I=CA=BCm not the expert here, Alan is). Robert