From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#38218: network-interface-list only returns IPv4 addresses Date: Tue, 26 Nov 2019 19:10:04 +0100 Message-ID: References: <8736eoiend.fsf@gnus.org> <83h82qsgjm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="225904"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38218@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 19:11:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZfJ7-000wcI-TN for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 19:11:26 +0100 Original-Received: from localhost ([::1]:57802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZfJ6-000778-Nm for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 13:11:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52783) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZfIn-00076o-Ct for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:11:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZfIk-0005wv-W4 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:11:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46918) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZfIk-0005w4-Qo for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZfIk-0006jO-Ld for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 13:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2019 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 38218-submit@debbugs.gnu.org id=B38218.157479181625813 (code B ref 38218); Tue, 26 Nov 2019 18:11:02 +0000 Original-Received: (at 38218) by debbugs.gnu.org; 26 Nov 2019 18:10:16 +0000 Original-Received: from localhost ([127.0.0.1]:52890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfI0-0006iF-8w for submit@debbugs.gnu.org; Tue, 26 Nov 2019 13:10:16 -0500 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:50500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfHx-0006hz-SS for 38218@debbugs.gnu.org; Tue, 26 Nov 2019 13:10:14 -0500 Original-Received: by mail-wm1-f46.google.com with SMTP id l17so4280225wmh.0 for <38218@debbugs.gnu.org>; Tue, 26 Nov 2019 10:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version; bh=Qy2KL8WSTQTKw6UBsaGhypKfmv1uGJzsUQUG3xBKGS4=; b=cgUmxQ2olzaWFtp1H1Xp7pGmDKJUhBxheK7ybveSWlXKTaPkhzfqV3csCvKQv9qjCL /sMS/MX6XFei1yhqNFdQBR4OyP7I2bi2c/Pk5OTdCx6w0K5SnDCUzQdLu6tEzntJoJcf p9kZPBGTD4DkPEPMoNfA4zyzSUESdSzgIn9QcXpmf73fL3SAJPO7FHHnfriKxQvWTDVf Blko2dCjyLoCanS7w2D6PRHkD+trladoLFzbyHtgm58bgJuF0+pCOrJlC4dLNSU2SvU3 ++Huj+iIk0Ty4xpdFPn+Y1EQnnH8NNC2Ltk+4MKx/CAjxnH4AOpEYlubBxA1ucboTWP+ RP1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=Qy2KL8WSTQTKw6UBsaGhypKfmv1uGJzsUQUG3xBKGS4=; b=EarKo9/+cfXL8mrZB1wn6tD1HroOkSbdqaDt50bRfcQcwU6o1J0zvhXDcNTmTgkpsq ffn1YjYrjSTD28lgwaZJEQ5UNhFVoPA8Dfbx08kxTDed+1gSOdFCw7u4K5C+g++E/Cb3 MKhIKDCfM3H78H0S4lmyblRj3YMaN1ESjiyAZXkfKiuVC4dGAzQnwvWSmP4uHbxPBSer GfkTEubBeYKEvagAihpZVkq3FzzaT7UVRTJED3fLIf64LVgJea0KCSJUUoQUoq9GrFYm 5XpNT1EG7OVFMV52h2sXp4BsGVC/0JcRgEYxI7YAMTogL1qfz+LnNL2dXFUQBBUDvVXm 0FWw== X-Gm-Message-State: APjAAAU+iAEyqsSBb6w4iBsVFG+tfgKXWTnrr+XtDF9MHbtD0qiuNCLd /tqZD595GmN1EGujkdQmTr5gvuQS X-Google-Smtp-Source: APXvYqy6Qe8l0Q1rzC4kCKQ3Da3i5rTkT/YQJvLzSH/bM0MhvBWWxEBhZ+zxPkSEyCNE9MlcNcstoA== X-Received: by 2002:a7b:ce12:: with SMTP id m18mr371966wmc.130.1574791807497; Tue, 26 Nov 2019 10:10:07 -0800 (PST) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:e411:a3bc:3f6:bb15]) by smtp.gmail.com with ESMTPSA id s8sm15733808wrt.57.2019.11.26.10.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 10:10:06 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <83h82qsgjm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 26 Nov 2019 19:17:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172462 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> On Tue, 26 Nov 2019 19:17:49 +0200, Eli Zaretskii said: Eli> It needed a bit of tweaking for mingw.org's MinGW, so that it would Eli> work on XP. However, after making the changes, one test from Eli> nsm-tests.el fails here: Thanks for that Eli> 127.1/0 No such host is known. Eli> 127.1/0 No such host is known. Eli> Test nsm-check-local-subnet-ipv4 backtrace: Eli> signal(ert-test-failed (((should (eq nil (nsm-should-check "12= 7.1") Eli> ert-fail(((should (eq nil (nsm-should-check "127.1"))) :form (= eq ni Eli> (if (unwind-protect (setq value-44 (apply fn-42 args-43)) (set= q for Eli> (let (form-description-46) (if (unwind-protect (setq value-44 = (appl Eli> (let ((value-44 'ert-form-evaluation-aborted-45)) (let (form-d= escri Eli> (let* ((fn-42 #'eq) (args-43 (condition-case err (let ((signal= -hook Eli> (let ((nsm-trust-local-network t)) (let* ((fn-37 #'eq) (args-3= 8 (co Eli> (let ((local-ip '[172 26 128 160 0]) (mask '[255 255 255 0 0])= (wro Eli> (closure (t) nil (let ((local-ip '[172 26 128 160 0]) (mask '[= 255 2 Eli> ert--run-test-internal(#s(ert--test-execution-info :test #s(er= t-tes Eli> ert-run-test(#s(ert-test :name nsm-check-local-subnet-ipv4 :do= cumen Eli> ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unsta= ble)) Eli> ert-run-tests((not (tag :unstable)) #f(compiled-function (even= t-typ Eli> ert-run-tests-batch((not (tag :unstable))) Eli> ert-run-tests-batch-and-exit((not (tag :unstable))) Eli> eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) Eli> command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charse= t cp8 Eli> command-line() Eli> normal-top-level() Eli> Test nsm-check-local-subnet-ipv4 condition: Eli> (ert-test-failed Eli> ((should Eli> (eq nil Eli> (nsm-should-check "127.1"))) Eli> :form Eli> (eq nil t) Eli> :value nil)) Eli> FAILED 1/2 nsm-check-local-subnet-ipv4 (4.656250 sec) Eek. mingw (or winsock) doesn=CA=BCt support getaddrinfo("127.1",...), although getaddrinfo("127.0.0.1",...) seems to work. This fixes it for me: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Use-127.0.0.1-in-nsm-tests.patch >From e441c874ac7e7a0c7724af85ebf2d1678aea3a88 Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Tue, 26 Nov 2019 19:07:42 +0100 Subject: [PATCH] Use 127.0.0.1 in nsm-tests To: emacs-devel@gnu.org Winsock doesn't like "127.1" * test/lisp/net/nsm-tests.el (nsm-check-local-subnet-ipv4): Spell numeric localhost as "127.0.0.1" instead of "127.1". --- test/lisp/net/nsm-tests.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/lisp/net/nsm-tests.el b/test/lisp/net/nsm-tests.el index 8e52568d71..97edcca80d 100644 --- a/test/lisp/net/nsm-tests.el +++ b/test/lisp/net/nsm-tests.el @@ -42,11 +42,11 @@ nsm-check-local-subnet-ipv4 (should-error (nsm-network-same-subnet local-ip wrong-length-mask remote-ip-yes)) (should (eq nil (nsm-network-same-subnet local-ip wrong-mask remote-ip-yes))) (should (eq t (nsm-should-check "google.com"))) - (should (eq t (nsm-should-check "127.1"))) + (should (eq t (nsm-should-check "127.0.0.1"))) (should (eq t (nsm-should-check "localhost"))) (let ((nsm-trust-local-network t)) (should (eq t (nsm-should-check "google.com"))) - (should (eq nil (nsm-should-check "127.1"))) + (should (eq nil (nsm-should-check "127.0.0.1"))) (should (eq nil (nsm-should-check "localhost")))))) (defun nsm-ipv6-is-available () -- 2.24.0.155.gd9f6f3b619 --=-=-=--