From: Robert Pluim <rpluim@gmail.com>
To: "A.C." <achirvasub@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 38507@debbugs.gnu.org
Subject: bug#38507: Fwd: Re: eww error: error in process filter: Window system frame should be used
Date: Thu, 12 Dec 2019 14:23:33 +0100 [thread overview]
Message-ID: <m2zhfxwucq.fsf@gmail.com> (raw)
In-Reply-To: <20191206023324.GA20286@system76-pc.localdomain>
>>>>> On Fri, 06 Dec 2019 00:11:54 -0500, "A.C." <achirvasub@gmail.com> said:
AC> -------- Original Message --------
AC> From: "A.C." <achirvasub@gmail.com>
AC> Sent: December 6, 2019 12:09:46 AM EST
AC> To: bug-gnu-emacs@gnu.org
AC> Subject: Re: eww error: error in process filter: Window system frame should be used
AC> To follow up with some more info:
AC> As the trace indicates, the problem seems to be caused by an svg image
AC> that website tries to load. This happens only when I start emacs in a
AC> terminal (with the '-nw' flag). The website loads fine
AC> - when emacs runs in an x window (so plain 'emacs' rather than 'emacs -nw');
AC> - in a terminal, provided I disable svg images with
AC> (setq shr-blocked-images "svg")
AC> So there are ways around this, but surely eww could handle
AC> this more gracefully? Perhaps with the right combination of
AC> compile config options?
Eww really shouldn't try to display images when running in terminal
mode. This should do it, unless Lars can suggest
something better:
diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 22d4cde34a..aec4a9e465 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1197,8 +1197,9 @@ shr-parse-image-data
(libxml-parse-xml-region (point) (point-max)) 'utf-8)))
;; SVG images often do not have a specified foreground/background
;; color, so wrap them in styles.
- (when (eq content-type 'image/svg+xml)
- (setq data (svg--wrap-svg data)))
+ (and (display-graphic-p)
+ (eq content-type 'image/svg+xml)
+ (setq data (svg--wrap-svg data)))
(list data content-type)))
(defun svg--wrap-svg (data)
next prev parent reply other threads:[~2019-12-12 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 2:33 bug#38507: eww error: error in process filter: Window system frame should be used Stuart Little
2019-12-06 5:09 ` A.C.
2019-12-06 5:11 ` bug#38507: Fwd: " A.C.
2019-12-12 13:23 ` Robert Pluim [this message]
2019-12-17 17:03 ` Robert Pluim
2019-12-24 16:21 ` Lars Ingebrigtsen
2019-12-24 21:56 ` A.C.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zhfxwucq.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=38507@debbugs.gnu.org \
--cc=achirvasub@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.