From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Really prevent quitting in sensitive contexts Date: Thu, 12 Mar 2020 11:21:39 +0100 Message-ID: References: <20200312020554.194607-1-dancol@dancol.org> <7eced910-43dd-5e62-a864-beded660a07e@dancol.org> <87tv2tga3i.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="83138"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Colascione , Stefan Monnier , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 12 11:22:24 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jCKyu-000LVj-4M for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Mar 2020 11:22:24 +0100 Original-Received: from localhost ([::1]:38904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCKyt-0002Cn-48 for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Mar 2020 06:22:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37932) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCKyF-0000sm-A3 for emacs-devel@gnu.org; Thu, 12 Mar 2020 06:21:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCKyE-0007Xj-9Y for emacs-devel@gnu.org; Thu, 12 Mar 2020 06:21:43 -0400 Original-Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:38842) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jCKyE-0007Td-3U for emacs-devel@gnu.org; Thu, 12 Mar 2020 06:21:42 -0400 Original-Received: by mail-wm1-x341.google.com with SMTP id h83so2048892wmf.3 for ; Thu, 12 Mar 2020 03:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:message-id :mime-version; bh=Rzs03lXKktbQ9u8eUQWLELLj1UlZYjrR4OLS4qOKHQs=; b=sPQfoU0kvrXO/e4oye/E8IayRTcdMva6KBd782iBQYzZPRiCU/0y9XBHZBZp8QySOV x9PJ1J/22ShNxSwEVtQ0ZpAM2k5G/9cKCQkKOsFxMxDC5VRMDXKTZKITuvPwZ64jJpxU 7PxXiSKCzVGredzuH3HIGeuzpjxlSIamcUlIWP7RFo2wVabeTkFcN2J33uUz3qTzU12K eSxX/Qvc8PwnS1JcxoNpnCj8ZspB0lkZAuoqq4LklOUU40VgjeGlwUYCic9hTOc7SAvQ q12U5gC0O0KcCddk4fU7YZxYOScnWwO3VVcw2cetS4UrAIbqwgYebLGNCrXc0Wau5k+j SoyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:message-id:mime-version; bh=Rzs03lXKktbQ9u8eUQWLELLj1UlZYjrR4OLS4qOKHQs=; b=XsgpouPokycH4NhQg6UNQxbIN9T3ssuZQy/mSSaBDfNgz5c1dGrm0Om3I49p5Cbx5p AAkdEBzs+FaB6MkZP0j6Z5IFyU0L3gxk9RHaD+i5pGU8afK7gz8kx9tl0KdavFM9P14S GmXDpvcp6t0t8S75sRTbY0ublsFfNBpfD09qQjwD3v2td/2y0py7LY5KpjQ+K8+sgFUJ 5p/qvPhaBEEM+40alCG4FxvBz7bkfz1rCRTSehxSncLz/2yBoi6oEvIxu8pvSEJpjRzy XeIDY09SvLcvD6gtsxPe/p7TGxkQlXU3Szydjrzf0MMR6V+miXFq740txDwgz+ZrHHPz Ry0w== X-Gm-Message-State: ANhLgQ35Bln0rxbrfGuG4Lw3hvW55eTROk6QNMqHwty+LHuj+SroKVrF bXnFRGVE8fKwX+4HiSikLHuCtNcYCls= X-Google-Smtp-Source: ADFU+vtSu4IkTimomcCkNPCNYQybSIyFMHucSIeNHswynfIOz0R5Q3sMKA9xswz/CwHllUVkhooZSA== X-Received: by 2002:a1c:23ca:: with SMTP id j193mr4245980wmj.111.1584008500630; Thu, 12 Mar 2020 03:21:40 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id 19sm12396334wma.3.2020.03.12.03.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 03:21:40 -0700 (PDT) Gmane-Reply-To-List: yes X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245487 Archived-At: >>>>> On Thu, 12 Mar 2020 11:07:29 +0100, Michael Albinus said: Michael> Daniel Colascione writes: >>> Are there bug#NNN where these are discussed? >> >> No. The motiviation is Tramp inflooping after a quit because it uses >> with-local-quit inside tramp-accept-process-output, which causes >> tramp-wait-for-regexp to retry infinitely and quickly. >> >> I found *that* behavior trying to figure out why M-x compile over >> Tramp was hanging not only Emacs, but also the SSH connection more >> generally. I *think* it has something to do with compilation-filter >> calling file-truename, which invokes Tramp's handler, which wants to >> talk over the same SSH connection that's spewing compilation messages, >> deadlocking something somewhere. Michael> Please write a bug report, it should be solved in Tramp. Michael> with-local-quit is used in tramp-accept-process-output by Michael> intention. There were reports that Tramp hung, and couldn't be quit ... Michael> Would the appended patch help (completely untested)? Yes! This solves my 'tramp hangs when visiting a patch' hang (or at least, I can now C-g out of it). Robert