From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#40355: [PATCH] Implement caching for libravatar lookup Date: Wed, 01 Apr 2020 09:27:00 +0200 Message-ID: References: <20200331180336.2999-1-philip@warpmail.net> <87d08sp5zk.fsf@bulbul> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="93420"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40355@debbugs.gnu.org To: philip@warpmail.net (Philip K.) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 01 09:28:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJXnK-000OD4-G1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Apr 2020 09:28:14 +0200 Original-Received: from localhost ([::1]:48310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJXnJ-0005cH-DQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Apr 2020 03:28:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47190) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJXn9-0005c4-Sd for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2020 03:28:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJXn8-00052Y-Nl for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2020 03:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54088) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJXn8-000524-Hk for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2020 03:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jJXn8-0001UH-AZ for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2020 03:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Apr 2020 07:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40355-submit@debbugs.gnu.org id=B40355.15857260355447 (code B ref 40355); Wed, 01 Apr 2020 07:28:02 +0000 Original-Received: (at 40355) by debbugs.gnu.org; 1 Apr 2020 07:27:15 +0000 Original-Received: from localhost ([127.0.0.1]:37401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJXmI-0001PQ-Hn for submit@debbugs.gnu.org; Wed, 01 Apr 2020 03:27:15 -0400 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:56250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJXmG-0001Oi-Dl for 40355@debbugs.gnu.org; Wed, 01 Apr 2020 03:27:08 -0400 Original-Received: by mail-wm1-f41.google.com with SMTP id r16so5392756wmg.5 for <40355@debbugs.gnu.org>; Wed, 01 Apr 2020 00:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=jnPaNQaiNTv4rlTnNxhgLd7j2uJjkvPwgFRc2hFiVms=; b=KyKq4d7zvp9RfyGEz5IqQiJp3JABW++brOdgGLU970Z6MbMVWGqTTp7Psnu/KwgUen 1+oWNhGVgoia5Rr4p93DN5QtQX17vXLCfmEhYMKoDK8usIdF0+ayuRorky0GBmKC4jvx FF7VYXN+Vo9dXAUXLE74OOOsF9CNuGl0eByhs4Di9egXxQ9JsE7/NQsYeROJpbJ72BaA CpuQpH/yaAVMrV/jrCBKH785bJ791FzDgPgucRSLOx6rMW4bBjf7P7gend55U0SgDdnw T0Z3TmpLI9EVCfFa/t6SKSTn3XWbGr8Hiw61Q5prylYuggatWxV68EtGsOPbNZgp+heC fEMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=jnPaNQaiNTv4rlTnNxhgLd7j2uJjkvPwgFRc2hFiVms=; b=fxTkHnxIQfU5ZRuLMPaprSKR/7KfDxZw4iLDY3o5CiD6Fi/a7FnkbltL5dnW/0bSnU iFIGKR9oWRSHYycdij+VokRgbGOlEbv/NTcTrOoCE93bOl1kwhkre3iih9juD0uOI/bu Q+2biRqexx3aeAUz8XWrrVC2tR8f2gbNnfd9miW6C59l6EAIu7gB4GICIMuR0NHqObOk M7l3ZdOKqJ5/gWxo2y3yEzDsb7MX3I2XLNxdmJE0DXwgz9+yfMwQtbas/bcD8Idltbey 6+LGXjhQtZ6vALEOeXkGxS7pQ/QQwDHA7YzrVSbPVgm6qjQ0NqK9wt0U9vlpCEzZO90p WKcg== X-Gm-Message-State: AGi0PuaVgkzWiYgfFtUQDjRdp+WIUm3KlEeVUaNf3NrIUzCvXDXr95ip sgQCty/Rm01LauOGsYM78e3XAFze X-Google-Smtp-Source: APiQypILBXcrvRHbPvUFXwx51QQgir7cd9O8fs8NzGb+wpUD+ENQE5zSBLE6gOYsb2iOmCTibhf9YA== X-Received: by 2002:a1c:7e11:: with SMTP id z17mr2933237wmc.151.1585726022022; Wed, 01 Apr 2020 00:27:02 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:65f2:9a92:2c96:9204]) by smtp.gmail.com with ESMTPSA id a2sm1790554wrp.13.2020.04.01.00.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 00:27:01 -0700 (PDT) In-Reply-To: <87d08sp5zk.fsf@bulbul> (Philip K.'s message of "Tue, 31 Mar 2020 23:30:23 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177937 Archived-At: >>>>> On Tue, 31 Mar 2020 23:30:23 +0200, philip@warpmail.net (Philip K.) s= aid: Philip> Robert Pluim writes: >>>>>>> On Tue, 31 Mar 2020 20:03:36 +0200, Philip K said: >>=20 >> I doubt you need the 'cache' arg, you can keep the cache purely >> internal. Philip> I added it because I was considering defining gravatar-libravat= ar-cache Philip> as Philip> (let ((cache (make-hash-table :test 'equal))) Philip> (dolist (domain '("aol.com" "att.net" "comcast.net" "face= book.com" Philip> "gmail.com" "gmx.com" "googlemail.com" = "google.com" Philip> "hotmail.com" "hotmail.co.uk" "mac.com"= "me.com" Philip> "mail.com" "msn.com" "live.com" "sbcglo= bal.net" Philip> ;; ... Philip> )) Philip> (gravatar--service-libravatar (concat "ignored@" domain= ) cache)) Philip> cache) Philip> with a few popular domains. The only issue is that evaluating i= t takes Philip> forever. Perhaps that=CA=BCs a sign that pre-population is not needed :-) >> How big is this cache likely to get? Perhaps use a weak hash table? Philip> I haven't managed to gather good real-world data yet, but I wou= ld assume Philip> something along the lines of 50-200 domains? OK, I don=CA=BCt think that=CA=BCs onerous. Robert