From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.bugs Subject: bug#61165: 30.0.50; Avoid nreverse in row_to_value Date: Mon, 30 Jan 2023 08:30:14 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33903"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 61165@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 08:31:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMOdN-0008aS-Fu for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 08:31:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMOd7-0005Ht-6o; Mon, 30 Jan 2023 02:31:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMOd5-0005HW-GU for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 02:31:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMOd5-0004Gi-8M for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 02:31:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMOd4-0001sO-IQ for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 02:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61165 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16750638237155 (code B ref -1); Mon, 30 Jan 2023 07:31:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Jan 2023 07:30:23 +0000 Original-Received: from localhost ([127.0.0.1]:46205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMOcR-0001rL-0X for submit@debbugs.gnu.org; Mon, 30 Jan 2023 02:30:23 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:48842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMOcP-0001rD-4H for submit@debbugs.gnu.org; Mon, 30 Jan 2023 02:30:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMOcO-00059F-SI for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 02:30:20 -0500 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMOcN-0004AV-6Y for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 02:30:20 -0500 Original-Received: by mail-wm1-x32b.google.com with SMTP id m5-20020a05600c4f4500b003db03b2559eso7431306wmq.5 for ; Sun, 29 Jan 2023 23:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=VzXlwKTaquFucfgiKOIgyNYvhUPrFinx1peVgsXvNVg=; b=LcaMK+FyquFnTm8bMe5CGYbDQFj7iRFrsv9TbZp5bGo/fFmKiAavCXHysDUaWFYT56 yxoXEXKPJxxIxInLEbP3hl/ztJUxA8Tgz3p4hd3XgyqEvh8duG5NITQ1L65ZvBupccHI KIOOTf95hT0oYAfBHKkgUz5oa3iZmXVpKvObuxD2kGQS22SxWXyi77XLldOvncx9oVQq WYuNesYmg6uLgx8a8Xr/lzP1rMT6xQWCoIs9g+Y/+Hd5QzaDNBHnShA9lFWdeJ2fYyDj gxhXZscmm52+8jyV5+JaOEGU8nB8arNpPs7CdWdHFt08j3l0jK1dSRU3OLfEEifQNhaC yZ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VzXlwKTaquFucfgiKOIgyNYvhUPrFinx1peVgsXvNVg=; b=tRQu8J6qfRNU/OsfVVHm0AktmpNq36MgWghW8UGKhtHNZlu9QRcfAaiqgQU6lda4pp XMXWOPQjSAVEFChjgygUCKMAGkavLSnskANXpcmSKDZdyjtgleRIp6P91yBvsQevoD5s E7DbFt8nXwTstABZcWPJNwwTGDIPrbcwkQXPABG/Fsf8qUcMe972SmL0TfUaZjBGYI/f M12K3Lml7x3xHQRkuXbWwFD0x9O8Smvy8qKxKNwRXIn5vM2NMlRfNL1ayKQqY1jqK2Ir Gl080nL1kj8jttlEH4A2Zh12UqbvFLZTe82mePVT5kN9IOjNw68uxSK8lqpyyKF1NkPQ Ri6g== X-Gm-Message-State: AO0yUKWXNrPJwYRxjBFNjmvX7/h6Q+4zL+O5IdpR0mC3u5bvvv4ip957 eueR8cKcmgBJ6KrnFWoXAuCw7kO/M6A= X-Google-Smtp-Source: AK7set/ZWH8rShu2Kxb8COHzR3LlPd8zWoTz4hIchhwkTL+ROtaBBJ0eEDghon6vaFrp3w0PdbItLQ== X-Received: by 2002:a05:600c:3512:b0:3dc:2c7c:6616 with SMTP id h18-20020a05600c351200b003dc2c7c6616mr14283824wmq.21.1675063817392; Sun, 29 Jan 2023 23:30:17 -0800 (PST) Original-Received: from caladan ([185.127.214.178]) by smtp.gmail.com with ESMTPSA id p12-20020a05600c418c00b003d9780466b0sm11750179wmh.31.2023.01.29.23.30.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 23:30:16 -0800 (PST) Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=eller.helmut@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254393 Archived-At: --=-=-= Content-Type: text/plain The function row_to_value in the file src/sqlite.c can avoid the call to Fnreverse by traversing the row in reverse order. Only a minor improvement but the change is simple. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=sqlite.patch diff --git a/src/sqlite.c b/src/sqlite.c index c96841e63f9..6e89ef04287 100644 --- a/src/sqlite.c +++ b/src/sqlite.c @@ -399,7 +399,7 @@ row_to_value (sqlite3_stmt *stmt) int len = sqlite3_column_count (stmt); Lisp_Object values = Qnil; - for (int i = 0; i < len; ++i) + for (int i = len - 1; 0 <= i; i--) { Lisp_Object v = Qnil; @@ -434,7 +434,7 @@ row_to_value (sqlite3_stmt *stmt) values = Fcons (v, values); } - return Fnreverse (values); + return values; } static Lisp_Object --=-=-=--