From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: face-cache Date: Sun, 28 Apr 2024 08:50:10 +0200 Message-ID: References: <86a5leuigi.fsf@gnu.org> <867cgiugsv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10456"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: eller.helmut@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 28 08:51:02 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0yNK-0002Ws-Ge for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Apr 2024 08:51:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0yMw-00063p-1L; Sun, 28 Apr 2024 02:50:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0yMa-00063B-Gn for emacs-devel@gnu.org; Sun, 28 Apr 2024 02:50:16 -0400 Original-Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0yMY-0003RL-Hf; Sun, 28 Apr 2024 02:50:15 -0400 Original-Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a556d22fa93so381306866b.3; Sat, 27 Apr 2024 23:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714287012; x=1714891812; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oZaS23zmRCljJlTsEZK+yFFUpzCQJNrRHHmUdzNTBkA=; b=is30iZqIZJyiPv4VRyzRBRu3mZYmNIpzx+omQCITyFVZGPFkRDDkQaU8BnsGOd81RU 5yoviTU7IywERTgSCi0X5oiRcgq395nz767hUmtqkKHCEYX5BsEaof/IYQRKg3ln8JXF klcX40G6xZXi5/dYcGvK2nHbDjfLRT/APTQNn4sjXKJyPx/hd8cbfINwyeCX2pN6F1YO +sCk1PHQynE8La1y0TSl2ZeBERSACX6rVVCEUpDqT+wnQmQT5O+K7Tup4R3O71Oj7Jqn RpVMz87ForEIjOXScHhQ1HoSApZFLGAUCe8ISb6npokLvly86m8qpvoSqfRr87o4yuqt fYHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714287012; x=1714891812; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oZaS23zmRCljJlTsEZK+yFFUpzCQJNrRHHmUdzNTBkA=; b=UWKjVGSnrgYu1FrhL7kp5sK/xFhB3D9HIQU7/R0wjxkEaknTlYuNQzxniFG1sNat3m I1oip5LMnklTiSxH6B5lRCmSC4upC9lcBngWMZrtvdC/9wGnHTrCBHaSKTg5SQs2JRX0 7jH9ernfBHConcWm5BJpjMz/IvrBDP7JLhITNlrDQ9SwSV+titJHn68cKzq75uBLCHlo ql4lvHkUb9ncK5JQ7vIfRuDGEZg6K+zoV4iDbNhX0wvxMuuVylIO9BprQ1GfYJZqZe0k pTD8lt83TAFR6Y1B6khlbuJtHtUnzOW8yTIxxG1MvAxUnw/i1ze5TBLBqoQc+BnMf0/L bvww== X-Forwarded-Encrypted: i=1; AJvYcCVzKb8zoFDcKPJ45zRDwNj9O7TzNXhHY6lqk+rU1lU92GbrAk4vcFIDhDui6ndg3zKUjfdlO0mHOokUa1quIZAfQfH3 X-Gm-Message-State: AOJu0YzfR+BpyP3Oua1D6LeiUIOV+A7bopiWKFBJXUfXmHyA8kxc5wN8 ee1KtVG01Y6T9hWzB7Z30wmChXcqVD9oBE80THh02oANs9lYR5A3yiG3VQ== X-Google-Smtp-Source: AGHT+IGfFoJ3Hxb3oPtHtOixPADMWScjydxizKcFgaBKfYlctGqNOwDibQZDin9HHblR9BX1jhQBDw== X-Received: by 2002:a17:906:b016:b0:a58:ee10:ad05 with SMTP id v22-20020a170906b01600b00a58ee10ad05mr1293335ejy.69.1714287011874; Sat, 27 Apr 2024 23:50:11 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36a77.dip0.t-ipconnect.de. [217.227.106.119]) by smtp.gmail.com with ESMTPSA id m24-20020a17090607d800b00a524216fe78sm12495266ejc.64.2024.04.27.23.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 23:50:11 -0700 (PDT) In-Reply-To: <867cgiugsv.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 28 Apr 2024 09:45:04 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x630.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318235 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: eller.helmut@gmail.com, emacs-devel@gnu.org >> Date: Sun, 28 Apr 2024 08:28:39 +0200 >>=20 >> In my case, it looks like a string which is created by Ffont_xlfd_name >> is later garbled. The string is used as the name of a fontset. Fontsets >> are PVEC_CHAR_TABLE, which, AFAIU, are treated like normal vectors >> during old GC. It's a bit confusing to me... Fix_char_table does that >> for the new GC in a similar way. > > Char-tables have the extras[] array: > > struct Lisp_Char_Table > { > [...] > /* These hold additional data. It is a vector. */ > Lisp_Object extras[FLEXIBLE_ARRAY_MEMBER]; > > Does fix_char_table handle that? I think so, but I find it a bit confusing. If you take a look at mark_char_table (alloc.c:7122), I see that the function treats char tables as struct Lisp_Vector, i.e. there is an implicit assumption there that marking v->contents when looking at it as Lisp_Vector catches bot the contents and extra contents when looking at it as a Lisp_Char_Table. WDT?