From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: weak hash tables Date: Tue, 02 Jul 2024 08:57:07 +0200 Message-ID: References: <2syUQ04IbTWqDJjMfKSrtzWMWmFGq1GIOwSxv_r6BEyNDtk7ADADKjZk-90g9tSS9SKWppkiq6_zihUtsoE1spiopaOI6-v9inQrGxwMyCs=@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11230"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Helmut Eller , Emacs Devel To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 02 08:57:36 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sOXSK-0002jw-0H for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Jul 2024 08:57:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOXS8-0002Ef-9j; Tue, 02 Jul 2024 02:57:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOXRz-000217-CO for emacs-devel@gnu.org; Tue, 02 Jul 2024 02:57:19 -0400 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sOXRw-00028H-U3; Tue, 02 Jul 2024 02:57:14 -0400 Original-Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-58ba3e38028so267949a12.0; Mon, 01 Jul 2024 23:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719903429; x=1720508229; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=WsWy1+jOI4/85GvZc564n2gs8bJma7QsLnnzsj9nYnQ=; b=Z1VLX9uSr7f/7yyJ4JqUqrRw+YHhzre+jWGSXDpsxck9SClLXBgK2i9qyDXshSYrSn PpI4ULjrqD7iCJ80AHEguapW/Luw4U8/EJUaDXFuN6TmBo9xXBj6tu7I41CrvsOLZNZ0 zf7MZ+tA62ZaQqnBxuUSsedPZQ73JP+WhcIWcvMVrtrI39IlZvcyF7YBL/FACOQZWhgb vklXDj31jEOJBa6K6rFeFdzZRPAP4LUJBsRouGk2QGUfcbIHDtjVd9H051/7TQtXe3NY fMIgERh0iChEYLrxJn850u0kwwrVUEn9w8jMFZwqmqF//JVWXok6wqqq9dowVP+xfXfe FhqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719903429; x=1720508229; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WsWy1+jOI4/85GvZc564n2gs8bJma7QsLnnzsj9nYnQ=; b=p2RkKXZ88mKyYdW7v2rN1QkfRVFIrhfNAjJ7C/uZC3lJULiY03JJxbbw/QdoOFN1Lf FgmOwOVK3HNqUcvueWkDSgfFISvJZBWFqe1JT0ewtnN8nmJKEbIkVEJzcYp9Y1sUPFJn HdJ+N68HvH1bilwYi3IhbifVueRT79dRFfCN4UQ6sXnV13CnUH2Tm94xjYwvIJSD8geP pHbWe+VRgNV8iQxZMxn0CQADJQ4DCnwWlM73WwIESh7LsaBm1YXqV0QKUMRt/AGRd87T IyhPlBngmaBpWlUVpqyJhq1YtIZOSsSb01FYTtAb+qJhZ1On9Z/1TeevrmII1KbGHITJ 3FSQ== X-Forwarded-Encrypted: i=1; AJvYcCWkriG+LxZGq+edgDRA4a5La/FcH4IiqTywVrec/Pc4kENJZLTRw84UEMlqh0G+qlu6kS6SjC+kqzUVFVvKxh+nP4gk X-Gm-Message-State: AOJu0Yys7zI9//HMdcbL/recXT5dHo3nVzM/9Me+ODj5YNlBHv+rQYlA xr6a/3RG3egaOFfg/DoGtvbWXDI5WkCX2FdsLPuOLl3mC4oj5/FoQgvkag== X-Google-Smtp-Source: AGHT+IFsN0DcZqxUdICeQH5JFw1grx3HmFek3Bz8+YVNFGu37tb3hxT9bgQNp0Eow76ihopg1F3kVg== X-Received: by 2002:a17:906:3392:b0:a72:5c85:fa40 with SMTP id a640c23a62f3a-a7514512db2mr470953466b.76.1719903428977; Mon, 01 Jul 2024 23:57:08 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36129.dip0.t-ipconnect.de. [217.227.97.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf1b569sm389916366b.1.2024.07.01.23.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 23:57:08 -0700 (PDT) In-Reply-To: <2syUQ04IbTWqDJjMfKSrtzWMWmFGq1GIOwSxv_r6BEyNDtk7ADADKjZk-90g9tSS9SKWppkiq6_zihUtsoE1spiopaOI6-v9inQrGxwMyCs=@protonmail.com> (Pip Cet's message of "Mon, 01 Jul 2024 23:10:01 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321100 Archived-At: Pip Cet writes: > Is it correct that all IGC objects need to be scannable when they're > still zeroed-out from allocation? > > (I'm currently trying to simply delay setting the weak->strong and > strong->weak pointers until the parts are initialized, and to turn the > scan into a nop if they aren't. I'm not convinced that's sufficient to > prevent the compiler from reordering the initialization so an invalid > state becomes visible to the scan function, though...) I have here fixes for that (I think) that I'll transfer to GNU in a few minutes. I think with that we're good. Please have a look.