From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: "Final" version of tty child frames Date: Tue, 22 Oct 2024 12:43:55 +0200 Message-ID: References: <86ttd4ftvs.fsf@gnu.org> <86plnsfp7j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="838"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 22 12:44:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3CN6-00006c-GW for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Oct 2024 12:44:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3CMs-0004UA-II; Tue, 22 Oct 2024 06:44:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3CMr-0004Sw-4T for emacs-devel@gnu.org; Tue, 22 Oct 2024 06:44:01 -0400 Original-Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3CMp-0000Fn-L9; Tue, 22 Oct 2024 06:44:00 -0400 Original-Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4314c4cb752so57836605e9.2; Tue, 22 Oct 2024 03:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729593837; x=1730198637; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=30zr3OhzeFSFTFnQfqT33fUCBLlrN+NbPQQKPQKBBsY=; b=ERaBVNDkmGsqUBoWkn4W99JyiRnZih4UymuWNbMwEznfZVBK9spP1Ni+0QuliVTKcX /tQULqj7af4xkrS5OWgYH7mWNWztELDFhRpqzv0nmNYMDs4DjI9x/B4ZMqK32TFr2cF9 WMY/CEzBwolepfk05zYePEXTzP4cx9gx2UjV2sg7JZEXdyu3Qk3VG49t4WS70qUXnTeQ WLYhW4tjTQ7Fu/4JVUzHDt9ABnYYI1O6rQIioaSAaXVIIwRIznD1bmumluHDlVI7WqA6 LWpdIqFrhR065W8jXCiQX88Rr8kXA4JNqjHqXkj23aJgssFK7nc6DxYCu7HfEhcDdzc9 14VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729593837; x=1730198637; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=30zr3OhzeFSFTFnQfqT33fUCBLlrN+NbPQQKPQKBBsY=; b=C1fehpQrxpj6qtThTRaVLquOtBh0ytn45brkF6A+1+PqlQI7xlYxV0SuPM2IaUy6RZ uGN1lH0JbiXPToUPYgLAdU4N9WuYYaqkKJIUj93mlDhLZlryHToi1vZD2eVH++Vs+bMr S6c5oyBTw33B1tGNmPHlHz7u5Wz6BRJM6yGEsL7skFO+1KEzYlnOBvMTwqCriyqUCi5R r7hLg1a1SFhvhWc6/6DN0Um/0YxDd7naKdsHOmCshF7/z6juzs4noEwMeJcMFvte1bVf UDsZP15zk0xzFLbP5RlFhWCm2zmgSCQIa/qejOJEvGNXJM+rtGTHlIousHBIte4HVBZQ QlvQ== X-Gm-Message-State: AOJu0Yx4u/1pO44miAsMkcQ2HMkHlElPSauD5sZpaZhQtj+De9EcZ0qU 8KBcrUICydNax5YkhKK2jaaDDj/7eT9Yc261A0KLXEwCkX5w6CViuQ4F8biD X-Google-Smtp-Source: AGHT+IFjkNixB5qw7yupJdhalOjOGBkJB3IwlXZY5ZGdnnNYsc0AwNWVfDosOAw+lanH9JS5aC1ryw== X-Received: by 2002:a05:600c:3b10:b0:431:58cd:b259 with SMTP id 5b1f17b1804b1-4317cb0971cmr15739035e9.31.1729593836936; Tue, 22 Oct 2024 03:43:56 -0700 (PDT) Original-Received: from pro2 (p4fe3ac5a.dip0.t-ipconnect.de. [79.227.172.90]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f5cc5adsm84163855e9.42.2024.10.22.03.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 03:43:56 -0700 (PDT) In-Reply-To: <86plnsfp7j.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 22 Oct 2024 12:42:56 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324730 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: emacs-devel@gnu.org >> Date: Tue, 22 Oct 2024 10:21:43 +0200 >>=20 >> Thanks for taking a look. > > Can you explain this comment and the code change: > > + /* Struct frame can move with igc, and so on. But we need > + something that takes different frames into account. Use the > + face_cache pointer for that which is malloc'd. */ > + if (glyph->frame && glyph->frame !=3D f) > + face_id +=3D (ptrdiff_t) glyph->frame->face_cache; > > Why do we need to take the frame into account here? Is this relevant > to the current GC used on master? Forgot to answer tha GC part: It's not relevant to non-MPS GC. (I'm using igc here, normally.)