Compiler warnings in dired.c

Compiler warnings in dired.c

[Eli Zaretskii]

This change:

 2009-10-24  Andreas Schwab  <schwab@linux-m68k.org>
 
 	* dired.c (Ffile_attributes): Simplify now that FIXNUM_OVERFLOW_P
 	can properly handle unsigned types.
 	(make_uid, make_gid): Removed.

causes these warnings on a 64-bit host:

  dired.c: In function 'Ffile_attributes':
  dired.c:1039: warning: comparison is always false due to limited range of data type
  dired.c:1039: warning: comparison is always false due to limited range of data type
  dired.c:1043: warning: comparison is always false due to limited range of data type
  dired.c:1043: warning: comparison is always false due to limited range of data type

Re: Compiler warnings in dired.c

[Andreas Schwab]

Eli Zaretskii <eliz@gnu.org> writes:

> This change:
>
>  2009-10-24  Andreas Schwab  <schwab@linux-m68k.org>
>  
>  	* dired.c (Ffile_attributes): Simplify now that FIXNUM_OVERFLOW_P
>  	can properly handle unsigned types.
>  	(make_uid, make_gid): Removed.
>
> causes these warnings on a 64-bit host:

This is unavoidable.  Just disable the them, they are useless.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Compiler warnings in dired.c

[Stefan Monnier]

> This is unavoidable.  Just disable the them, they are useless.

100% agreed.


        Stefan

Re: Compiler warnings in dired.c

[Eli Zaretskii]

> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Sun, 25 Oct 2009 00:38:24 +0200
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > This change:
> >
> >  2009-10-24  Andreas Schwab  <schwab@linux-m68k.org>
> >  
> >  	* dired.c (Ffile_attributes): Simplify now that FIXNUM_OVERFLOW_P
> >  	can properly handle unsigned types.
> >  	(make_uid, make_gid): Removed.
> >
> > causes these warnings on a 64-bit host:
> 
> This is unavoidable.  Just disable the them, they are useless.

I didn't enable any warnings.  This is using the stock
src/Makefile.in.  For the record, the GCC version is this:

    gcc (GCC) 4.0.3 (Ubuntu 4.0.3-1ubuntu5)

Re: Compiler warnings in dired.c

[Andreas Schwab]

Eli Zaretskii <eliz@gnu.org> writes:

> I didn't enable any warnings.

You can disable them.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Compiler warnings in dired.c

[Eli Zaretskii]

> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Sun, 25 Oct 2009 09:34:48 +0100
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I didn't enable any warnings.
> 
> You can disable them.

Please do.