From: Andrew Hyatt <ahyatt@gmail.com>
To: Gary Oberbrunner <garyo@genarts.com>
Cc: 3418@debbugs.gnu.org
Subject: bug#3418: Issue with compile.el and compilation-parse-errors-filename-function
Date: Tue, 26 Jan 2016 00:21:51 -0500 [thread overview]
Message-ID: <m2y4bczzio.fsf@gmail.com> (raw)
In-Reply-To: <4A1FF55B.4040202@genarts.com> (Gary Oberbrunner's message of "Fri, 29 May 2009 10:46:51 -0400")
Gary Oberbrunner <garyo@genarts.com> writes:
> Hi emacs folks. I submitted a patch to compilation-get-file-structure in
> compile.el in 2001, introducing this stanza:
>
> ;; If compilation-parse-errors-filename-function is
> ;; defined, use it to process the filename.
> (when compilation-parse-errors-filename-function
> (setq filename
> (funcall
> filename)))
>
> At some point since then, the filename was changed to not always be absolute;
> there's now a variable spec-directory in that function. This means that
> implementations of compilation-parse-errors-filename-function can't always work
> correctly since it doesn't know the full path of the file.
>
> I'm happy to work on a fix, but I see a few issues.
>
> Solution 1: add 2nd arg SPEC-DIRECTORY to
> compilation-parse-errors-filename-function.
> Problem: existing implementations will get an incorrect number of args error and
> will have to change.
>
> Solution 2: make filename absolute before passing to
> compilation-parse-errors-filename-function.
> Problem: the rest of the code is pretty careful not to absolutize the filename;
> this would change the behavior in ways I don't completely understand.
>
> Of course I am personally happy with solution 1, but since it affects
> compatibility I thought I should bring it up on this list. I am not on the
> list, so please cc me with any replies, thanks!
Sadly, this bug hasn't been responded to. Your description is pretty
code-intensive, for those of us not familiar with the internals, can you
give instructions on how to reproduce a user-visible issue?
next prev parent reply other threads:[~2016-01-26 5:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 14:46 bug#3418: Issue with compile.el and compilation-parse-errors-filename-function Gary Oberbrunner
2016-01-26 5:21 ` Andrew Hyatt [this message]
2016-01-26 14:42 ` Eli Zaretskii
2016-01-26 15:15 ` Gary Oberbrunner
2016-01-26 16:08 ` Eli Zaretskii
2016-01-26 16:19 ` Gary Oberbrunner
2017-08-11 0:50 ` npostavs
2017-08-11 1:04 ` Gary Oberbrunner
2017-08-11 6:34 ` Eli Zaretskii
2017-08-12 15:42 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y4bczzio.fsf@gmail.com \
--to=ahyatt@gmail.com \
--cc=3418@debbugs.gnu.org \
--cc=garyo@genarts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.