bug#11041: 23.4; Shifted keystrokes are not passed into OS X Input Manager correctly

bug#11041: 23.4; Shifted keystrokes are not passed into OS X Input Manager correctly

[Yong-Gang Wang]

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

In GNU Emacs 23.4.1 (x86_64-apple-darwin, NS apple-appkit-1038.36)
 of 2012-01-29 on bob.porkrind.org

Repro: On Mac OS X, turns a CJK input method on, e.g. Chinese Pinyin Input
Method, then types shifted characters like ":", "?", "<" or ">" in GNU
Emacs OS X 23.4.1.
Expected results: Chinese fullwidth punctuations are input, like "：", "？",
"《" or "》".
Actual results: English halfwidth punctuations are input, ":", "?", "<" or
">".

Debug and Code location:

See src/nsterm.m line 4490-4492, the current logic is, when there are
modifier keys, including SHIFT, being pressed down, the key code won't be
sent to OS X Input Manager for composing the input method result. This
logic is NOT true for shifted keystrokes. Actually, shifted keystrokes
like ":", "?", "<" or ">" are still display characters and should be sent
into the Input Manager for composing.

      /* if it was a function key or had modifiers, pass it directly to
emacs */
      if (fnKeysym || (emacs_event->modifiers
                       && [[theEvent charactersIgnoringModifiers] length] >
0))

A workable fix:

      /* if it was a function key or had modifiers(except for shift only
modifier), pass it directly to emacs */
      if (fnKeysym || (emacs_event->modifiers
                       && emacs_event->modifiers != shift_modifier
                       && [[theEvent charactersIgnoringModifiers] length] >
0))

Thanks,


-- 
Yong-Gang Wang 王咏刚

[-- Attachment #2: Type: text/html, Size: 2097 bytes --]

bug#11041: 23.4; Shifted keystrokes are not passed into OS X Input Manager correctly

[Alan Third]

Yong-Gang Wang <wixette@gmail.com> writes:

> Repro: On Mac OS X, turns a CJK input method on, e.g. Chinese Pinyin Input Method, then types shifted characters like ":", "?", "<" or ">" in GNU Emacs OS X 23.4.1.
> Expected results: Chinese fullwidth punctuations are input, like "：", "？", "《" or "》".
> Actual results: English halfwidth punctuations are input, ":", "?", "<" or ">".
>
> Debug and Code location:
>
> See src/nsterm.m line 4490-4492, the current logic is, when there are modifier keys, including SHIFT, being pressed down, the key code won't be sent to OS X Input Manager for composing the input method result. This logic is NOT true for shifted keystrokes. Actually, shifted keystrokes like ":", "?", "<" or ">" are still display characters and should be sent into the Input Manager
> for composing.
>
>       /* if it was a function key or had modifiers, pass it directly to emacs */
>       if (fnKeysym || (emacs_event->modifiers
>                        && [[theEvent charactersIgnoringModifiers] length] > 0))
>
> A workable fix:
>
>       /* if it was a function key or had modifiers(except for shift only modifier), pass it directly to emacs */
>       if (fnKeysym || (emacs_event->modifiers
>                        && emacs_event->modifiers != shift_modifier
>                        && [[theEvent charactersIgnoringModifiers] length] > 0))

Hi Sorry, it's taken so long for someone to get back to you.

It looks like this exact fix was already in Emacs when the bug was
raised, so I'm not sure what's going on.

Are you able to confirm whether this now works as expected?
-- 
Alan Third

bug#11041: acknowledged by developer (control message for bug #11041)

[Yong-Gang Wang]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

Confirmed that the bug has been fixed. Thanks,

On Sat, Feb 10, 2018 at 6:13 AM, GNU bug Tracking System <
help-debbugs@gnu.org> wrote:

> This is an automatic notification regarding your bug report
> #11041: 23.4; Shifted keystrokes are not passed into OS X Input Manager
> correctly,
> which was filed against the emacs package.
>
> Thank you for your report, which has now been closed.
> You can view the full report at
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11041
>
> If you require further information, please followup to
> 11041@debbugs.gnu.org.
>
> debbugs.gnu.org maintainers
> (administrator, GNU bugs database)
>
>


-- 
Yong-Gang Wang 王咏刚

[-- Attachment #2: Type: text/html, Size: 1327 bytes --]