From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#34723: 27.0.50; customize and improve diff-mode recentering Date: Sat, 16 Mar 2019 20:39:12 +0100 Message-ID: References: <8336o1e33w.fsf@gnu.org> <83r2blcdj2.fsf@gnu.org> <83h8cgc7ih.fsf@gnu.org> Reply-To: charles@aurox.ch Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="213457"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34723@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 16 20:36:43 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5F6o-000tPn-Hh for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Mar 2019 20:36:42 +0100 Original-Received: from localhost ([127.0.0.1]:45467 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5F6n-0002pz-Fs for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Mar 2019 15:36:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5F6Z-0002cW-Dn for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2019 15:36:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5ExS-0001YM-Oc for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2019 15:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33181) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5ExS-0001Y7-GA for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2019 15:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h5ExS-0004qz-7c for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2019 15:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Mar 2019 19:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34723 X-GNU-PR-Package: emacs Original-Received: via spool by 34723-submit@debbugs.gnu.org id=B34723.155276436918600 (code B ref 34723); Sat, 16 Mar 2019 19:27:02 +0000 Original-Received: (at 34723) by debbugs.gnu.org; 16 Mar 2019 19:26:09 +0000 Original-Received: from localhost ([127.0.0.1]:46725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h5Ewb-0004pw-As for submit@debbugs.gnu.org; Sat, 16 Mar 2019 15:26:09 -0400 Original-Received: from nestroy.aurox.ch ([82.195.237.20]:42740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h5EwZ-0004pV-8a for 34723@debbugs.gnu.org; Sat, 16 Mar 2019 15:26:08 -0400 Original-Received: from nestroy.aurox.ch (nestroy.aurox.ch [127.0.0.1]) by nestroy.aurox.ch (Postfix) with ESMTP id 44MC95260Jzt58 for <34723@debbugs.gnu.org>; Sat, 16 Mar 2019 19:26:01 +0000 (UTC) Authentication-Results: nestroy.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim2; t=1552764359; x=1555356360; bh=3 Fe58oGLH5EdYR0i/Wp3O2V2G/r6GsF5zyC/BvpgLkA=; b=pPe/KE388wQK/rUN7 DUennQHklrOw0fkecQobKU2OIRaaTNpdvdxbDpLcHz143Eb+a5wklcjwHDMFQsgn s/a0a/2o8S/d65Ouywqc+rWKEtt3xjVUf1k9QNhpRLleu/22HostW1gWGu0G1jwa H7xCApHumYSHeZfqZMRSHKjkiY= X-Virus-Scanned: Debian amavisd-new at nestroy.aurox.ch Original-Received: from nestroy.aurox.ch ([127.0.0.1]) by nestroy.aurox.ch (nestroy.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 714nk-gmd9ro for <34723@debbugs.gnu.org>; Sat, 16 Mar 2019 19:25:59 +0000 (UTC) Original-Received: from gray (unknown [IPv6:2a02:1206:4512:5f50:c62c:3ff:fe30:b864]) by nestroy.aurox.ch (Postfix) with ESMTPSA id 44MC9336sGzt4q; Sat, 16 Mar 2019 19:25:59 +0000 (UTC) In-reply-to: (message from Stefan Monnier on Wed, 13 Mar 2019 15:56:50 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156417 Archived-At: > From: Stefan Monnier > Date: Wed, 13 Mar 2019 15:56:50 -0400 > > >> There are cases where recentering does "make sure that the whole entry > >> is visible", but as we saw in the first post of this report, there is > >> at least one case where recentering makes less useful context visible. > > That's clearly undesirable, indeed. I think it's a plain bug. > > Basically when moving in one direction, diff-hunk-next/prev should never > > scroll the buffer in the other direction. > > I installed the patch below which should fix this most glaring problem. > > > Stefan Thanks! I noticed that I had to "touch lisp/vc/diff-mode.el" before the change took effect in my local tree, since the change in the macro does not trigger the recompilation of the callers. Could "make" somehow detect this?