From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#37470: 26.3; [PATCH] Default value and type of message-make-forward-subject-function Date: Fri, 20 Sep 2019 12:02:15 +0200 Message-ID: References: <8736grwd0l.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="101524"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37470@debbugs.gnu.org To: Damien Cassou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 20 12:11:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBFst-000QI5-O5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 12:11:27 +0200 Original-Received: from localhost ([::1]:57320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBFsq-0008Bf-PX for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 06:11:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57403) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBFsc-0007qN-9s for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 06:11:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBFkk-0006QL-Om for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 06:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iBFkk-0006QF-Kk for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 06:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iBFkk-00061z-DL for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 06:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2019 10:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37470-submit@debbugs.gnu.org id=B37470.156897374723140 (code B ref 37470); Fri, 20 Sep 2019 10:03:02 +0000 Original-Received: (at 37470) by debbugs.gnu.org; 20 Sep 2019 10:02:27 +0000 Original-Received: from localhost ([127.0.0.1]:56835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBFkA-000619-V9 for submit@debbugs.gnu.org; Fri, 20 Sep 2019 06:02:27 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:46750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBFk8-00060v-Rl for 37470@debbugs.gnu.org; Fri, 20 Sep 2019 06:02:25 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id o18so6073268wrv.13 for <37470@debbugs.gnu.org>; Fri, 20 Sep 2019 03:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=JYdIRdolUQKW362b9259G+bWC93hNjSevpFof6Iyieo=; b=QzeCuhjpoMqhs1kvgrp3LzIB4xln4Jvg6UBAFfCcJ1/9TIKP4zOmhyUnUYSa46QsQq 3ElVz9BckISjLv9qE6mJIUQhc+I6ZWmRB7KB2sZqbyUUWrV5axV79eY0TB/aDpCUFde0 CpjIX1DAEgcF3DbxCMuFC+iOR9IJkZEuGKmlV1caR5wNxq4dW8mNgVPdRNztnd0rA5ZJ exuwcK7C+kW2Qxg94wQOe0ESKgjr05cdPsUSmNdI+Khh9R5XivMwxaVdL75s/YUKKInk dkwtFHnAWHTQKh93YYXllNryhUv3RXz/TuYVfWFBhVOtYIXXmSSv4KKFQ2t243WL2ILi GYwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=JYdIRdolUQKW362b9259G+bWC93hNjSevpFof6Iyieo=; b=U2u665ik4GLNhzAE5764ZJ1/xbXw7Cegcne2vhEx8bkf6secTRKGgDtTL4hhmbI7Vv G0xA+2BgU8lsO3wPzoHJWt8XaN50G+zc2NUrL9HJzZFjowuR5wLmB1/qJDJRXni/0afS 9jSd7eKPHLb/vbgo/uThDYm9rSnboCRJvRF4HYHMgTQcd0IPyUSvg5M+jrSY83Dl8cXh 7i+PgANYtFRuuDBb9izO8CI9ovc+a6P9tSJA3uGKHV0ablMQ4Lyg0dxyBi+MqAxqjd7k 2Gd3LIJ9tXF1TlgeOtxzT/HR0rdo2eTteWn4w6I0/BZ+NWjpr5xlCRhsQ9+0EfkzPySm yXdg== X-Gm-Message-State: APjAAAXeZa7czcyWGWUyCIUOAr1kLu6yvuOGqYsyEluDYG+dPN5GNZRm mYVzXu5lEYGMz2cZ/zudMRQ0ZAyV X-Google-Smtp-Source: APXvYqzJjnZbq5Kt+QIBHNQ4Hq+dWSF7VyJ6fJgdlwzdfEe+GdLK1+U/01/sDpVZAGnZDb5C3GEXig== X-Received: by 2002:adf:f1d1:: with SMTP id z17mr11908901wro.330.1568973737697; Fri, 20 Sep 2019 03:02:17 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id z142sm2798280wmc.24.2019.09.20.03.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 03:02:16 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <8736grwd0l.fsf@cassou.me> (Damien Cassou's message of "Fri, 20 Sep 2019 11:08:42 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166754 Archived-At: >>>>> On Fri, 20 Sep 2019 11:08:42 +0200, Damien Cassou = said: Damien> Please find attached a patch fixing the default value and type = of Damien> message-make-forward-subject-function. Damien> + :type '(repeat :tag "List of functions" Damien> + (radio (function-item message-forward-subject= -author-subject) Damien> + (function-item message-forward-subject= -fwd) Damien> + (function-item message-forward-subject= -name-subject) Damien> + (function)))) I don=CA=BCt see how this could work: 'radio allows selecting only one from the list. How about something like this: diff --git i/lisp/gnus/message.el w/lisp/gnus/message.el index 48d79107ea..1a1cb79039 100644 --- i/lisp/gnus/message.el +++ w/lisp/gnus/message.el @@ -532,7 +532,7 @@ message-user-organization-file :group 'message-headers) =20 (defcustom message-make-forward-subject-function - #'message-forward-subject-name-subject + (list #'message-forward-subject-name-subject) "List of functions called to generate subject headers for forwarded mess= ages. The subject generated by the previous function is passed into each successive function. @@ -547,10 +547,11 @@ message-make-forward-subject-function to it." :group 'message-forwarding :link '(custom-manual "(message)Forwarding") - :type '(radio (function-item message-forward-subject-author-subject) - (function-item message-forward-subject-fwd) - (function-item message-forward-subject-name-subject) - (repeat :tag "List of functions" function))) + :type '(set :tag "List of functions" + (function-item message-forward-subject-author-subject) + (function-item message-forward-subject-fwd) + (function-item message-forward-subject-name-subject) + (repeat :tag "User functions" :inline t (function :tag "Func= tion")))) =20 (defcustom message-forward-as-mime nil "Non-nil means forward messages as an inline/rfc822 MIME section.