From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.devel Subject: Re: Review request: javac in compilation-error-regexp-alist-alist Date: Wed, 01 Apr 2020 03:34:50 +0300 Message-ID: References: <81FF6512-6E29-46F7-9AAD-324D915B3F2F@acm.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="5628"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 01 02:35:38 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJRM2-0001Mw-H0 for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Apr 2020 02:35:38 +0200 Original-Received: from localhost ([::1]:45488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJRM0-0001mX-2A for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 20:35:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42491) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJRLO-0001Il-2Q for emacs-devel@gnu.org; Tue, 31 Mar 2020 20:35:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJRLM-0007Ej-5n for emacs-devel@gnu.org; Tue, 31 Mar 2020 20:34:57 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54723) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJRLL-0007At-Ni for emacs-devel@gnu.org; Tue, 31 Mar 2020 20:34:55 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 42A6E5C012E; Tue, 31 Mar 2020 20:34:53 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 31 Mar 2020 20:34:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=+Mqt5QBRtSpYEB8l2aW497lTzW 40ddja+t9II/ilz+Y=; b=YxZPf1vdAejc7XCE5gslFXf5251KhalBbHBV+kbLqs TQnFsNago/DrhcZa5MIgFAxO/3EOqs7uUL/hMcM5ZumfQwxsSaaqKzHvW1GyB8b1 IlOJg8im0yCIPck3wnUGxp7RezqRsH+/w0ppOiiv837u02dWna7cQFN/eUEyrmor +X43KplJuUwIqCEOCGDbSK/nGm60e/uJMg2h7JHbFXqmKOiUbo24fpA8dRmWXfat iXDTDP317aMt59/vzcqwG3vJBzbSLsWpLQMN8z8M62fxvAjTYdfFSbVYRoZYFE1n jUTy9iHN9masgFj6aRsf3uCST9Vgh86xLBY58upxpQVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+Mqt5Q BRtSpYEB8l2aW497lTzW40ddja+t9II/ilz+Y=; b=zcT42Y5lTu+h5x397v0dGQ OMYf8IiDE59eTNgb+pxQ/7ddO1Ek+50ekDGAMcx3h0rnS1NAeSzsXNhDcMXli+zq Q8mtG7Zk9PQZzxXmWJJsk04IdFTojZEfcD505cUBDvOTIwYs6Z5Ie3mRKvs65nj2 FUoDi8YaUrzLXQpILqu2qzgdfCQgK6E/Ry56l7Wolt9ryFRxXiaE+fgyR0Cn9mxG /QAa7YpIvy3rnYhKJRWL136sP2ZF1tbPb4XSDaHJqFSFWy7lfx0u5kkI1WU4XAd2 cZLsem5bDZN2daPQNjBW1H8gmsfwKJbBIOMZ0S5qORAicqwXMVWbfZ5pfBPJoLsg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtddtgdduieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefhihhlihhp phcuifhunhgsihhnuceofhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmheqnecukfhppe ekledrudejledrudekjedrvdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepfhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: from fgunbin.local (unknown [89.179.187.25]) by mail.messagingengine.com (Postfix) with ESMTPA id 7C01B328005A; Tue, 31 Mar 2020 20:34:52 -0400 (EDT) In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sat, 29 Feb 2020 11:58:05 +0100") Mail-Followup-To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.27 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246166 Archived-At: Mattias, sorry for the long delay, and thanks again for comments, they're much appreciated. I've now pushed this as 319a2a7427 in master, except for this thing: > There seems to be an off-by-one error in the column number; try it and > you'll see. I think current-column is 0-based but Emacs expects a > 1-based column from the compilation error matcher. I didn't notice this because I do (set (make-local-variable 'compilation-first-column) 0) in java-mode, but then other java rules (ant, maven) may also be buggy, I'll look at this in more detail. Filipp