From: Filipp Gunbin <fgunbin@fastmail.fm>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel@gnu.org
Subject: Re: Review request: javac in compilation-error-regexp-alist-alist
Date: Wed, 01 Apr 2020 03:34:50 +0300 [thread overview]
Message-ID: <m2y2rg59hx.fsf@fastmail.fm> (raw)
In-Reply-To: <DA121AEE-FC96-4816-8A80-15BDE1E16930@acm.org> ("Mattias Engdegård"'s message of "Sat, 29 Feb 2020 11:58:05 +0100")
Mattias, sorry for the long delay, and thanks again for comments,
they're much appreciated.
I've now pushed this as 319a2a7427 in master, except for this thing:
> There seems to be an off-by-one error in the column number; try it and
> you'll see. I think current-column is 0-based but Emacs expects a
> 1-based column from the compilation error matcher.
I didn't notice this because I do (set (make-local-variable
'compilation-first-column) 0) in java-mode, but then other java rules
(ant, maven) may also be buggy, I'll look at this in more detail.
Filipp
next prev parent reply other threads:[~2020-04-01 0:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 18:17 Review request: javac in compilation-error-regexp-alist-alist Filipp Gunbin
2020-02-28 17:11 ` Mattias Engdegård
2020-02-28 23:02 ` Filipp Gunbin
2020-02-29 10:58 ` Mattias Engdegård
2020-04-01 0:34 ` Filipp Gunbin [this message]
2020-04-01 11:08 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y2rg59hx.fsf@fastmail.fm \
--to=fgunbin@fastmail.fm \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.