From: Filipp Gunbin <fgunbin@fastmail.fm>
To: emacs-devel@gnu.org
Cc: winkler@gnu.org
Subject: process-file instead of call-process in proced.el?
Date: Fri, 25 Mar 2022 03:09:12 +0300 [thread overview]
Message-ID: <m2y20ydhav.fsf@fastmail.fm> (raw)
There's this TODO in proced.el:
--8<---------------cut here---------------start------------->8---
;; - Allow "sudo kill PID", "sudo renice PID"
--8<---------------cut here---------------end--------------->8---
WDYT, can we just use process-file instead of call-process? Then, if
proced is opened from a /sudo:: (or su) buffer, and (setq
proced-signal-function "kill") is set, proced-send-signal "just works"
for processes owned by different user, with no special code in proced.
The simple patch is below.
Filipp.
diff --git a/lisp/proced.el b/lisp/proced.el
index c1d599afc4..7d324a37a3 100644
--- a/lisp/proced.el
+++ b/lisp/proced.el
@@ -1833,7 +1833,7 @@ proced-send-signal
(dolist (process process-alist)
(with-temp-buffer
(condition-case nil
- (unless (zerop (call-process
+ (unless (zerop (process-file
proced-signal-function nil t nil
signal (number-to-string (car process))))
(proced-log (current-buffer))
@@ -1875,7 +1875,7 @@ proced-renice
(dolist (process process-alist)
(with-temp-buffer
(condition-case nil
- (unless (zerop (call-process
+ (unless (zerop (process-file
proced-renice-command nil t nil
priority (number-to-string (car process))))
(proced-log (current-buffer))
next reply other threads:[~2022-03-25 0:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 0:09 Filipp Gunbin [this message]
2022-03-25 6:54 ` process-file instead of call-process in proced.el? Eli Zaretskii
2022-03-25 10:24 ` Filipp Gunbin
2022-03-25 10:31 ` Eli Zaretskii
2022-03-25 11:46 ` Michael Albinus
2022-03-25 12:12 ` Eli Zaretskii
2022-03-25 12:29 ` Filipp Gunbin
2022-03-25 13:34 ` Roland Winkler
2022-03-25 13:58 ` Michael Albinus
2022-03-25 14:26 ` Filipp Gunbin
2022-03-25 14:29 ` Michael Albinus
2022-03-25 15:40 ` Filipp Gunbin
2022-03-25 15:43 ` Michael Albinus
2022-03-26 16:49 ` Michael Albinus
2022-03-26 17:37 ` Roland Winkler
2022-03-26 18:31 ` Michael Albinus
2022-03-26 18:49 ` Roland Winkler
2022-03-27 7:28 ` Michael Albinus
2022-03-27 14:08 ` Michael Albinus
2022-03-28 2:57 ` Roland Winkler
2022-03-28 7:41 ` Michael Albinus
2022-03-28 14:34 ` Roland Winkler
2022-03-28 14:53 ` Filipp Gunbin
2022-03-28 15:40 ` Michael Albinus
2022-03-28 16:11 ` Filipp Gunbin
2022-03-28 16:39 ` Michael Albinus
2022-03-28 19:42 ` Filipp Gunbin
2022-03-30 11:20 ` Michael Albinus
2022-03-30 15:34 ` Filipp Gunbin
2022-03-28 17:08 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y20ydhav.fsf@fastmail.fm \
--to=fgunbin@fastmail.fm \
--cc=emacs-devel@gnu.org \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.