bug#65321: 30.0.50; Tramp sudo fails since commit 5c101b1adac

bug#65321: 30.0.50; Tramp sudo fails since commit 5c101b1adac

[Filipp Gunbin]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

Hi,

- emacs -Q
- M-x load-library tramp RET
- M-x set-variable tramp-verbose RET 10 RET
- C-x C-f /sudo::/tmp RET
- <enter password at the prompt>
- Observe hang with message like "Tramp: Opening connection nil for root@fgunbin.local using sudo...failed"
- C-g

*debug tramp* buffer contents attached.

Thanks.

In GNU Emacs 30.0.50 (build 16, x86_64-apple-darwin20.6.0, NS
 appkit-2022.70 Version 11.7.7 (Build 20G1345)) of 2023-08-15 built on
 fgunbin.local
Repository revision: 1db7e8eba961e88181879213dd5374ad9e87ac76
Repository branch: master
System Description:  macOS 11.7.7

Configured using:
 'configure --enable-check-lisp-object-type --with-file-notification=no'

Configured features:
ACL GLIB GNUTLS LCMS2 LIBXML2 MODULES NS PDUMPER PNG RSVG SQLITE3
THREADS TOOLKIT_SCROLL_BARS WEBP XIM ZLIB

Important settings:
  value of $LC_ALL: ru_RU.UTF-8
  value of $LC_CTYPE: UTF-8
  locale-coding-system: utf-8-unix


[-- Attachment #2: tramp.log --]
[-- Type: application/octet-stream, Size: 8688 bytes --]

  backtrace()
  tramp-signal-hook-function(quit nil)
  signal(quit nil)
  tramp-maybe-open-connection((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-send-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil) "/bin/test -e / 2>/dev/null; echo tramp_exit_status...")
  tramp-send-command-and-check((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil) "/bin/test -e /")
  tramp-find-file-exists-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-get-file-exists-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-bundle-read-file-names((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil) ("/bin" "/usr/bin" "/sbin" "/usr/sbin" "/usr/local/bin" "/usr/local/sbin" "/local/bin" "/local/freeware/bin" "/local/gnu/bin" "/usr/freeware/bin" "/usr/pkg/bin" "/usr/contrib/bin" "/opt/bin" "/opt/sbin" "/opt/local/bin"))
  tramp-get-remote-path((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-get-ls-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-find-file-exists-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-get-file-exists-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-bundle-read-file-names((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil) ("/bin" "/usr/bin" "/sbin" "/usr/sbin" "/usr/local/bin" "/usr/local/sbin" "/local/bin" "/local/freeware/bin" "/local/gnu/bin" "/usr/freeware/bin" "/usr/pkg/bin" "/usr/contrib/bin" "/opt/bin" "/opt/sbin" "/opt/local/bin"))
  tramp-get-remote-path((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-get-ls-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-find-file-exists-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-get-file-exists-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-bundle-read-file-names((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil) ("/bin" "/usr/bin" "/sbin" "/usr/sbin" "/usr/local/bin" "/usr/local/sbin" "/local/bin" "/local/freeware/bin" "/local/gnu/bin" "/usr/freeware/bin" "/usr/pkg/bin" "/usr/contrib/bin" "/opt/bin" "/opt/sbin" "/opt/local/bin"))
  tramp-get-remote-path((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-get-ls-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-find-file-exists-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-get-file-exists-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-sh-handle-file-exists-p(#("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  apply(tramp-sh-handle-file-exists-p #("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  tramp-sh-file-name-handler(file-exists-p #("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  apply(tramp-sh-file-name-handler file-exists-p #("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  tramp-file-name-handler(file-exists-p #("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  file-exists-p(#("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  completion-file-name-table(#("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)) file-exists-p lambda)
  test-completion(#("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)) completion-file-name-table file-exists-p)
  completion--file-name-table("~/src/emacs//sudo::/tmp" file-exists-p lambda)
  complete-with-action(lambda completion--file-name-table "~/src/emacs//sudo::/tmp" file-exists-p)
  #f(compiled-function (table) #<bytecode 0x1eea5def5e6e71df>)(completion--file-name-table)
  completion--some(#f(compiled-function (table) #<bytecode 0x1eea5def5e6e71df>) (completion--embedded-envvar-table completion--file-name-table))
  read-file-name-internal("~/src/emacs//sudo::/tmp" file-exists-p lambda)
  test-completion("~/src/emacs//sudo::/tmp" read-file-name-internal file-exists-p)
  completion--complete-and-exit(12 35 exit-minibuffer #f(compiled-function () #<bytecode 0x1dd499604bf1f372>))
  completion-complete-and-exit(12 35 exit-minibuffer)
  minibuffer-complete-and-exit()
  funcall-interactively(minibuffer-complete-and-exit)
  call-interactively(minibuffer-complete-and-exit nil nil)
  command-execute(minibuffer-complete-and-exit)
  read-from-minibuffer("Find file: " "~/src/emacs/" (keymap (keymap (32)) keymap (10 . minibuffer-complete-and-exit) (13 . minibuffer-complete-and-exit) keymap (menu-bar keymap (minibuf "Minibuf" keymap (tab menu-item "Complete" minibuffer-complete :help "Complete as far as possible") (space menu-item "Complete Word" minibuffer-complete-word :help "Complete at most one word") (63 menu-item "List Completions" minibuffer-completion-help :help "Display all possible completions") "Minibuf")) (M-down . minibuffer-next-completion) (M-up . minibuffer-previous-completion) (27 keymap (13 . minibuffer-choose-completion) (103 keymap (27 keymap (99 . switch-to-completions))) (118 . switch-to-completions)) (prior . switch-to-completions) (63 . minibuffer-completion-help) (32 . minibuffer-complete-word) (backtab . minibuffer-complete) (9 . minibuffer-complete) keymap (menu-bar keymap (minibuf "Minibuf" keymap (previous menu-item "Previous History Item" previous-history-element :help "Put previous minibuffer history element in the min...") (next menu-item "Next History Item" next-history-element :help "Put next minibuffer history element in the minibuf...") (isearch-backward menu-item "Isearch History Backward" isearch-backward :help "Incrementally search minibuffer history backward") (isearch-forward menu-item "Isearch History Forward" isearch-forward :help "Incrementally search minibuffer history forward") (return menu-item "Enter" exit-minibuffer :key-sequence "\15" :help "Terminate input and exit minibuffer") (quit menu-item "Quit" abort-recursive-edit :help "Abort input and exit minibuffer") "Minibuf")) (24 keymap (down . minibuffer-complete-defaults) (up . minibuffer-complete-history)) (13 . exit-minibuffer) (10 . exit-minibuffer) (7 . abort-minibuffers) (C-tab . file-cache-minibuffer-complete) (9 . self-insert-command) (XF86Back . previous-history-element) (up . previous-line-or-history-element) (prior . previous-history-element) (XF86Forward . next-history-element) (down . next-line-or-history-element) (next . next-history-element) (27 keymap (60 . minibuffer-beginning-of-buffer) (114 . previous-matching-history-element) (115 . next-matching-history-element) (112 . previous-history-element) (110 . next-history-element))) nil file-name-history "~/src/emacs/" nil)
  completing-read-default("Find file: " read-file-name-internal file-exists-p confirm-after-completion "~/src/emacs/" file-name-history "~/src/emacs/" nil)
  completing-read("Find file: " read-file-name-internal file-exists-p confirm-after-completion "~/src/emacs/" file-name-history "~/src/emacs/")
  read-file-name-default("Find file: " nil "~/src/emacs/" confirm-after-completion nil nil)
  read-file-name("Find file: " nil "~/src/emacs/" confirm-after-completion)
  find-file-read-args("Find file: " confirm-after-completion)
  byte-code("\300\301\302 \"\207" [find-file-read-args "Find file: " confirm-nonexistent-file-or-buffer] 3)
  call-interactively(find-file nil nil)
  command-execute(find-file)

bug#65321: 30.0.50; Tramp sudo fails since commit 5c101b1adac

[Michael Albinus]

Filipp Gunbin <fgunbin@fastmail.fm> writes:

> Hi,

Hi Filipp,

[Pls don't use this type of Cc and Mail-Followup-To. It isn't compatible
 with the debbugs mail configuration. If you want to add me when sending
 a bug report, pls use X-Debbugs-Cc as indicated in admin/notes/bugtracker]

> - emacs -Q
> - M-x load-library tramp RET
> - M-x set-variable tramp-verbose RET 10 RET
> - C-x C-f /sudo::/tmp RET
> - <enter password at the prompt>
> - Observe hang with message like "Tramp: Opening connection nil for root@fgunbin.local using sudo...failed"
> - C-g
>
> *debug tramp* buffer contents attached.

Thanks for the report. You are hit by an infloop, due to some code
reorganization in Tramp. Fixed in master.

> Thanks.

Best regards, Michael.

bug#65321: 30.0.50; Tramp sudo fails since commit 5c101b1adac

[Filipp Gunbin]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

Hi Michael,

On 16/08/2023 11:55 +0200, Michael Albinus wrote:

> Filipp Gunbin <fgunbin@fastmail.fm> writes:
>
>> Hi,
>
> Hi Filipp,
>
> [Pls don't use this type of Cc and Mail-Followup-To. It isn't compatible
>  with the debbugs mail configuration. If you want to add me when sending
>  a bug report, pls use X-Debbugs-Cc as indicated in
> admin/notes/bugtracker]

Noted.

>> - emacs -Q
>> - M-x load-library tramp RET
>> - M-x set-variable tramp-verbose RET 10 RET
>> - C-x C-f /sudo::/tmp RET
>> - <enter password at the prompt>
>> - Observe hang with message like "Tramp: Opening connection nil for root@fgunbin.local using sudo...failed"
>> - C-g
>>
>> *debug tramp* buffer contents attached.
>
> Thanks for the report. You are hit by an infloop, due to some code
> reorganization in Tramp. Fixed in master.

Thanks, but now another error, debug output attached.

Filipp


[-- Attachment #2: tramp.log --]
[-- Type: application/octet-stream, Size: 5815 bytes --]

  backtrace()
  tramp-signal-hook-function(quit nil)
  signal(quit nil)
  tramp-maybe-open-connection((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-send-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil) "/usr/bin/test -e / 2>/dev/null; echo tramp_exit_st...")
  tramp-send-command-and-check((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil) "/usr/bin/test -e /")
  tramp-find-file-exists-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-get-file-exists-command((tramp-file-name "sudo" #("root" 0 4 (tramp-default t)) nil #("fgunbin.local" 0 13 (tramp-default t)) nil "/tmp" nil))
  tramp-sh-handle-file-exists-p(#("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  apply(tramp-sh-handle-file-exists-p #("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  tramp-sh-file-name-handler(file-exists-p #("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  apply(tramp-sh-file-name-handler file-exists-p #("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  tramp-file-name-handler(file-exists-p #("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  file-exists-p(#("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)))
  completion-file-name-table(#("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)) file-exists-p lambda)
  test-completion(#("/sudo:root@fgunbin.local:/tmp" 6 10 (tramp-default t) 11 24 (tramp-default t)) completion-file-name-table file-exists-p)
  completion--file-name-table("~/src/emacs//sudo::/tmp" file-exists-p lambda)
  complete-with-action(lambda completion--file-name-table "~/src/emacs//sudo::/tmp" file-exists-p)
  #f(compiled-function (table) #<bytecode 0x1eea5def5f0371df>)(completion--file-name-table)
  completion--some(#f(compiled-function (table) #<bytecode 0x1eea5def5f0371df>) (completion--embedded-envvar-table completion--file-name-table))
  read-file-name-internal("~/src/emacs//sudo::/tmp" file-exists-p lambda)
  test-completion("~/src/emacs//sudo::/tmp" read-file-name-internal file-exists-p)
  completion--complete-and-exit(12 35 exit-minibuffer #f(compiled-function () #<bytecode 0x1dd49bd03b0af372>))
  completion-complete-and-exit(12 35 exit-minibuffer)
  minibuffer-complete-and-exit()
  funcall-interactively(minibuffer-complete-and-exit)
  call-interactively(minibuffer-complete-and-exit nil nil)
  command-execute(minibuffer-complete-and-exit)
  read-from-minibuffer("Find file: " "~/src/emacs/" (keymap (keymap (32)) keymap (10 . minibuffer-complete-and-exit) (13 . minibuffer-complete-and-exit) keymap (menu-bar keymap (minibuf "Minibuf" keymap (tab menu-item "Complete" minibuffer-complete :help "Complete as far as possible") (space menu-item "Complete Word" minibuffer-complete-word :help "Complete at most one word") (63 menu-item "List Completions" minibuffer-completion-help :help "Display all possible completions") "Minibuf")) (M-down . minibuffer-next-completion) (M-up . minibuffer-previous-completion) (27 keymap (13 . minibuffer-choose-completion) (103 keymap (27 keymap (99 . switch-to-completions))) (118 . switch-to-completions)) (prior . switch-to-completions) (63 . minibuffer-completion-help) (32 . minibuffer-complete-word) (backtab . minibuffer-complete) (9 . minibuffer-complete) keymap (menu-bar keymap (minibuf "Minibuf" keymap (previous menu-item "Previous History Item" previous-history-element :help "Put previous minibuffer history element in the min...") (next menu-item "Next History Item" next-history-element :help "Put next minibuffer history element in the minibuf...") (isearch-backward menu-item "Isearch History Backward" isearch-backward :help "Incrementally search minibuffer history backward") (isearch-forward menu-item "Isearch History Forward" isearch-forward :help "Incrementally search minibuffer history forward") (return menu-item "Enter" exit-minibuffer :key-sequence "\15" :help "Terminate input and exit minibuffer") (quit menu-item "Quit" abort-recursive-edit :help "Abort input and exit minibuffer") "Minibuf")) (24 keymap (down . minibuffer-complete-defaults) (up . minibuffer-complete-history)) (13 . exit-minibuffer) (10 . exit-minibuffer) (7 . abort-minibuffers) (C-tab . file-cache-minibuffer-complete) (9 . self-insert-command) (XF86Back . previous-history-element) (up . previous-line-or-history-element) (prior . previous-history-element) (XF86Forward . next-history-element) (down . next-line-or-history-element) (next . next-history-element) (27 keymap (60 . minibuffer-beginning-of-buffer) (114 . previous-matching-history-element) (115 . next-matching-history-element) (112 . previous-history-element) (110 . next-history-element))) nil file-name-history "~/src/emacs/" nil)
  completing-read-default("Find file: " read-file-name-internal file-exists-p confirm-after-completion "~/src/emacs/" file-name-history "~/src/emacs/" nil)
  completing-read("Find file: " read-file-name-internal file-exists-p confirm-after-completion "~/src/emacs/" file-name-history "~/src/emacs/")
  read-file-name-default("Find file: " nil "~/src/emacs/" confirm-after-completion nil nil)
  read-file-name("Find file: " nil "~/src/emacs/" confirm-after-completion)
  find-file-read-args("Find file: " confirm-after-completion)
  byte-code("\300\301\302 \"\207" [find-file-read-args "Find file: " confirm-nonexistent-file-or-buffer] 3)
  call-interactively(find-file nil nil)
  command-execute(find-file)

bug#65321: 30.0.50; Tramp sudo fails since commit 5c101b1adac

[Michael Albinus]

Filipp Gunbin <fgunbin@fastmail.fm> writes:

> Hi Michael,

Hi Filipp,

> Noted.
>
>>> - emacs -Q
>>> - M-x load-library tramp RET
>>> - M-x set-variable tramp-verbose RET 10 RET
>>> - C-x C-f /sudo::/tmp RET
>>> - <enter password at the prompt>
>>> - Observe hang with message like "Tramp: Opening connection nil for root@fgunbin.local using sudo...failed"
>>> - C-g
>>>
>>> *debug tramp* buffer contents attached.
>>
>> Thanks for the report. You are hit by an infloop, due to some code
>> reorganization in Tramp. Fixed in master.
>
> Thanks, but now another error, debug output attached.

Hmm. According to the backtrace, Tramp has sent "/usr/bin/test -e / 2>/dev/null"
to the sudo process. It didn't return; you seem to have interrupted this
(it signals `quit').

What happens if you apply "/usr/bin/test -e /" in a sudo shell? And
could you, pls, send next time the debug buffer
*debug tramp/sudo root@fgunbin.local* instead just the backtrace?

> Filipp

Best regards, Michael.

bug#65321: 30.0.50; Tramp sudo fails since commit 5c101b1adac

[Filipp Gunbin]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi Michael,

On 16/08/2023 15:24 +0200, Michael Albinus wrote:

> Hmm. According to the backtrace, Tramp has sent "/usr/bin/test -e / 2>/dev/null"
> to the sudo process. It didn't return; you seem to have interrupted this
> (it signals `quit').
>
> What happens if you apply "/usr/bin/test -e /" in a sudo shell? And
> could you, pls, send next time the debug buffer
> *debug tramp/sudo root@fgunbin.local* instead just the backtrace?

$ sudo su
sh-3.2# /usr/bin/test -e /
sh: /usr/bin/test: No such file or directory

Attached debug buffer.

Thanks.
Filipp


[-- Attachment #2: tramp-debug.log.gz --]
[-- Type: application/octet-stream, Size: 91040 bytes --]

bug#65321: 30.0.50; Tramp sudo fails since commit 5c101b1adac

[Michael Albinus]

Filipp Gunbin <fgunbin@fastmail.fm> writes:

> Hi Michael,

Hi Filipp,

>> What happens if you apply "/usr/bin/test -e /" in a sudo shell? And
>> could you, pls, send next time the debug buffer
>> *debug tramp/sudo root@fgunbin.local* instead just the backtrace?
>
> $ sudo su
> sh-3.2# /usr/bin/test -e /
> sh: /usr/bin/test: No such file or directory

That's OK.

> Attached debug buffer.

Thanks. It is the famous "echo -n" bug; this command isn't
portable. I've fixed this on master.

> Thanks.
> Filipp

Best regards, Michael.

bug#65321: 30.0.50; Tramp sudo fails since commit 5c101b1adac

[Filipp Gunbin]

Hi Michael,

On 16/08/2023 19:35 +0200, Michael Albinus wrote:

[...]

>> Attached debug buffer.
>
> Thanks. It is the famous "echo -n" bug; this command isn't
> portable. I've fixed this on master.

It works now, thank you very much!

Filipp

bug#65321: 30.0.50; Tramp sudo fails since commit 5c101b1adac

[Michael Albinus]

Version: 30.1

Filipp Gunbin <fgunbin@fastmail.fm> writes:

> Hi Michael,

Hi Filipp,

>> Thanks. It is the famous "echo -n" bug; this command isn't
>> portable. I've fixed this on master.
>
> It works now, thank you very much!

Thanks for the feedback, I'm closing the bug.

> Filipp

Best regards, Michael.