From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rudolf Schlatte Newsgroups: gmane.emacs.bugs Subject: bug#68781: [PATCH] Don't fill yaml except comments and block scalars. Date: Tue, 30 Jan 2024 11:15:34 +0100 Message-ID: References: <216ddb7b-e02d-4e68-9dbb-68fa1202d198@mgmarlow.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24047"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 68781@debbugs.gnu.org Cancel-Lock: sha1:yf8Iw8LBUb/HzQpcMHIvG7FVcS0= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 30 11:17:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUlBH-00061x-Sj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Jan 2024 11:17:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUlAo-0004LO-T4; Tue, 30 Jan 2024 05:16:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUlAj-0004Kx-Pw for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 05:16:54 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUlAj-0005C2-I0 for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 05:16:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rUlAr-00040j-Lz for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 05:17:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Rudolf Schlatte Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2024 10:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170660976815329 (code B ref -1); Tue, 30 Jan 2024 10:17:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Jan 2024 10:16:08 +0000 Original-Received: from localhost ([127.0.0.1]:34250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUlA0-0003zA-Fv for submit@debbugs.gnu.org; Tue, 30 Jan 2024 05:16:08 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:39214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUl9x-0003ye-Tm for submit@debbugs.gnu.org; Tue, 30 Jan 2024 05:16:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUl9j-0003BK-4d for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 05:15:51 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUl9h-00051p-5j for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 05:15:50 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rUl9d-0003fP-6p for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 11:15:45 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279163 Archived-At: Graham Marlow writes: >> Hello Randy, thanks for having a look! Could you tell me which >> tree-sitter grammar you are using? I'm asking because with the grammar >> from https://github.com/ikatyang/tree-sitter-yaml I don't see what you >> describe. > > For the record I'm also using this grammar. > > Looking at the patch, what do you think about retaining the existing behavior > (so block_scalars still fill correctly) while inhibiting fill_paragraph for > everything else as suggested? Originally I retained the existing behavior of > fill-paragraph just to limit the number of things changed by the patch, not > because it was working properly. I think blocking the call to fill-paragraph > for non-block/comment nodes makes sense. I'm suddenly a bit stressed for time and can't investigate properly for the next few days why my proposed patch misbehaves under some circumstances.. And your patch fixes the misbehavior with a minimum of changes, so I think it's the one that should go in. Thanks to both of you for working on this!