From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc fe90d556834: Make glyphs ambiguous roots Date: Mon, 29 Jul 2024 16:12:45 +0200 Message-ID: References: <172218853212.17772.9043342656088870281@vcs2.savannah.gnu.org> <20240728174212.BDB66C41F13@vcs2.savannah.gnu.org> <87h6c8lnva.fsf@gmail.com> <87le1kk0zk.fsf@gmail.com> <87r0bcfgb1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34511"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 29 16:13:40 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYR86-0008rX-UK for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Jul 2024 16:13:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sYR7M-0003Vs-4t; Mon, 29 Jul 2024 10:12:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sYR7K-0003Vk-WD for emacs-devel@gnu.org; Mon, 29 Jul 2024 10:12:51 -0400 Original-Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sYR7J-0002Ua-EG for emacs-devel@gnu.org; Mon, 29 Jul 2024 10:12:50 -0400 Original-Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a7a9a369055so396395566b.3 for ; Mon, 29 Jul 2024 07:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722262367; x=1722867167; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=19pb0MviY4PGYfC93cEOi7QiLobiiQ8sVGN9iZ56zV4=; b=nQi6iErrvoAYd49R+ngK9adSOfaGzWUXgxqDVqwMlLjMGSZZUNTbpMYk4UKIJATDkz x/kYmXe5eSy6pEwJ/yWiJsxyTtEg1Lpx6ZTDV87d1aBgaBqstquFiFaOk6D0bFr3u1r4 zzkThbRxjMGN/pLKxWh5ThZS5nKr+N4GTQsBxiRu3i4McRtYYP1FbAFxlVW1iGhWEnDM Mb47JsN6ye4MimIA4jCeCKARACszncReTeM2P/Ist8Arr8IQDo3422lEKPnAhVnH8g5L XuecBYHjmy66Yj/InYDFX2NiB0jrJvbIFT37sKeM2AFKIkio5nUqBt69AB6lHXfZrGSG nHSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722262367; x=1722867167; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=19pb0MviY4PGYfC93cEOi7QiLobiiQ8sVGN9iZ56zV4=; b=pspeew/L9/7uZTDfW9YSna65BDW4yz3R/VI6X40rPV22CqDbCFbXs2AcnNQZ1qdg1b I00o3dNI5gVy6o5Cx3u1/01LwC8aEnF2xG2NxkioAjGQBF98PIUhFjtTE6RcXglbkOBU xLg18zpc2b3Z0xFr/vDdGVmawRESYqqxf0ndz9stPTC+P0Dd4BUIaYWimKVtSB1gaW0n sLIpgfzLXKi9PiJNIkscERCkX6y5MxPBeOCcYfjoXtmE8mUMt4URzrd7Qu7hy/XqUvOd ApTooaDrW/Rla8vnhf7ZexzqXk3CfC7PC7BR5ISGZ1EKrutHpFWlP1TO//35tTnirH+f rF5g== X-Gm-Message-State: AOJu0Yw0la9cqih9ewE3c8GEKjmq0p+VFVbR/nUPUwdvvayi22fS4BwH L7s/XgFBaW4wioSIf2WjXPnOouuPCYOJBWzcpA+cF5MqWjw9d4MaYVI9iA== X-Google-Smtp-Source: AGHT+IF2TKAo4cBw2xfyuKiCXP4v33FIRLApnwxo1qMbjd66mOzrKBXwXPh4IxsKQPrjj+Q+uDOvew== X-Received: by 2002:a17:907:c201:b0:a7a:ab8a:386 with SMTP id a640c23a62f3a-a7d40158ec2mr291357066b.63.1722262367157; Mon, 29 Jul 2024 07:12:47 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3a35e.dip0.t-ipconnect.de. [79.227.163.94]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad4b825sm508971266b.112.2024.07.29.07.12.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 07:12:46 -0700 (PDT) In-Reply-To: <87r0bcfgb1.fsf@gmail.com> (Helmut Eller's message of "Mon, 29 Jul 2024 16:01:22 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322195 Archived-At: Helmut Eller writes: > On Mon, Jul 29 2024, Gerd M=C3=B6llmann wrote: > >>>> While the doc doesn't guarantee that all other (registered) threads are >>>> suspended, it's hard to imagine what else MPS could do to stop other >>>> threads from messing up the object. (MPS must remove hardware barrier= s, >>>> so that's not an option.) >>> >>> Good point, indeed. >>> >>> I've reverted that change. Thanks for checking! >> >> By the same argument, I think we could simplify face_cache and >> image_cache which both use IGC_OBJ_PTR_VEC at the moment.=20 >> IGC_OBJ_PTR_VEC could then go completely. > > You mean, you would use the regular xmalloc instead of igc_make_ptr_vec > to allocate those vectors and trace the vectors in fix_face_cache. Hm, > yes that's indeed a similar situation. As long as those caches aren't > roots, I don't see a problem. Yes, axactly. The bucket vectors and face_cache::faces_by_id and image_cache::images could be xmalloc'd like in the non-MPS case, and fix_face_cache and fix_image_cache could iterator over them and so on.=20 > I guess this would make the MPS and non-MPS code more alike. We'd lose > some details for igc-info, though that's a minor issue. Yes, and things gets a bit simpler, which I'm personally a big fan of. I'll put that on my todo list. Thanks!