From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: "Final" version of tty child frames Date: Tue, 22 Oct 2024 16:01:08 +0200 Message-ID: References: <86wmi0g0x6.fsf@gnu.org> <4a4cb10e-fe30-4830-b5fe-93d075e12479@gmx.at> <86iktkfe1n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40081"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: rudalics@gmx.at, jared@finder.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 22 16:01:55 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3FSN-000AGe-7D for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Oct 2024 16:01:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3FRm-0007qN-7v; Tue, 22 Oct 2024 10:01:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3FRk-0007qD-Hq for emacs-devel@gnu.org; Tue, 22 Oct 2024 10:01:16 -0400 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3FRi-00036C-O7; Tue, 22 Oct 2024 10:01:16 -0400 Original-Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-43159c9f617so54320565e9.2; Tue, 22 Oct 2024 07:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729605671; x=1730210471; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sVz49mp7BjBFAoOFMe2hvA1nCkaiSBG3s6SQeJ87Bfk=; b=I6sIdFPxuWSglZG+4AdRq7H9WzHlarMT6pAAL3iLgHH49xeRnoruWYgtaefECn0BjL 5GiEg+48StZIiepBSOhKwXg6+upcCO4MvrBlkO5QDZROpxvgd/yiUKogyC1qwJQIJCCR iNn4OBj6512VzMV3i/1GZL4mKT+mnDk1dDbfYJuLIfBTxm7aGGlDT/SEeXQ/gi7faxAP bRRL4pje7WLXL/SHL+8ecgROjaQVqsWWfOIk0Az6jBy0x/eIw220VLH4ARR5z06OeDJR sazoMaAaC3XPs2fNw4qH/s+YtgQu24wELa+JcrJWefimULF3dHkKAtTJhjZv6Mk0UBI9 gHOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729605671; x=1730210471; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sVz49mp7BjBFAoOFMe2hvA1nCkaiSBG3s6SQeJ87Bfk=; b=YuTpz1H3LURzivz/ez7A6yCqNOWcjOU0HJfq1y3+RNgLeYk9LWWUnXSnKog5y5jx1D 72p+yptaT2CBQz87kF+Gb0KB7dPqS/ofBEsk9fA3gWYOUdJ5g8k8Thmctia3sDAb/Bgz S0S8DEeUvNfJLfMYr97OE4ihYzfeVs+QAD53IKdErfTi3QOQYd6+JgCSRH1IjSlfgRE3 5uGVbmtDOhINDIyjR7EjyY/V3ZBX6eDh5+AHg7DJHlliTgDcCC+9g3cotMUQ1TbHtVoo nYutt3tZB0FzQ3Gawe+oXNVScYoqlGy3sVt9ZE8XmlvwoD2X9ezuGN52Ls6bLBJGr0iQ uP4w== X-Forwarded-Encrypted: i=1; AJvYcCUiDIjSJK5MqlrwHLApzJ1FI2kL/cojSq9x1EMwaVVKyst0N0urfY44tiKGOS0Ihf4ZgPZL0g4NaeD81Q==@gnu.org X-Gm-Message-State: AOJu0YzgMuZKbxRnN4cNpdkHbS6m5cXlpKpDqvIBJ/MRK3X+C7QypW47 tI87zT/aHL+mqASgvX5mODtOXJ+FtvvQEcmokglRzReKIR3cQc3gdLZ0gxt8 X-Google-Smtp-Source: AGHT+IEi4KQZusgalYUuQ9iU7bb8eod6q6p7TIN0w/d2eagVc9aFZb0lAEsmMO6AS5IaPt5gvOufRA== X-Received: by 2002:a05:600c:1e0e:b0:431:60d0:9088 with SMTP id 5b1f17b1804b1-4316163887fmr123057155e9.13.1729605670339; Tue, 22 Oct 2024 07:01:10 -0700 (PDT) Original-Received: from pro2 (p4fe3ac5a.dip0.t-ipconnect.de. [79.227.172.90]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f5cbe64sm89146905e9.40.2024.10.22.07.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 07:01:09 -0700 (PDT) In-Reply-To: <86iktkfe1n.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 22 Oct 2024 16:44:04 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324737 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: Eli Zaretskii , Jared Finder , >> emacs-devel@gnu.org >> Date: Tue, 22 Oct 2024 12:40:21 +0200 >>=20 >> martin rudalics writes: >>=20 >> > Building complains here as >> > >> > In file included from ../../src/term.c:30: >> > ../../src/lisp.h: In function =E2=80=98Ftty_display_pixel_height=E2=80= =99: >> > ../../src/lisp.h:406:24: warning: =E2=80=98height=E2=80=99 may be used= uninitialized [-Wmaybe-uninitialized] >> > 406 | XIL ((EMACS_INT) (((EMACS_UINT) (n) << INTTYPEBITS) + Lisp= _Int0)) >> > | ^ >> > ../../src/term.c:4907:14: note: =E2=80=98height=E2=80=99 was declared = here >> > 4907 | int width, height; >> > | ^~~~~~ >> > ../../src/lisp.h: In function =E2=80=98Ftty_display_pixel_width=E2=80= =99: >> > ../../src/lisp.h:406:24: warning: =E2=80=98width=E2=80=99 may be used = uninitialized [-Wmaybe-uninitialized] >> > 406 | XIL ((EMACS_INT) (((EMACS_UINT) (n) << INTTYPEBITS) + Lisp= _Int0)) >> > | ^ >> > ../../src/term.c:4896:7: note: =E2=80=98width=E2=80=99 was declared he= re >> > 4896 | int width, height; >> > | ^~~~~ >>=20 >> That's code like this: >>=20 >> { >> int width, height; >> tty_display_dimension (display, &width, &height); >> return make_fixnum (height); >> } >>=20 >> So width and height are returned by the call to tty_display_dimension. >> TBH, I can't make sense of the warning. > > I could: tty_display_dimension includes a switch without 'default', > and thus might not set width and height to any value. I installed > what should be a fix for that, and I hope Martin will confirm that the > warning is now gone. Ok, thanks. I thought that was an exhaustive switch, but apparently not. > >> FWIW, clang doesn't complain. > > It probably doesn't analyze the code so thoroughly. > >> > One thing I noticed is that changing the background color works only >> > after I changed something like the position or size.=20=20 >>=20 >> Probably a SET_FRAME_GARBAGED missing somewhere, or something like that. > > If someone gives the recipe for this, I could look into it. > >> > Also I would like to get rid of those |+- borders. What would I have >> > to do? >>=20 >> If you want to get rid of the border completely add a frame parameter >> (undecorated . t), Default if no no undecorated is specified, it to not >> draw borders. > > You mean, if undecorated is not specified, the default is to _draw_ > the borders, yes? Because the examples I used do not specify > undecorated, and the borders were drawn. It's this, so if it's not undecoreated. if (!FRAME_UNDECORATED (child)) { /* Horizontal line above. */ The double negation always gets me confused :-).