From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#74966: 31.0.50; Crash report (using igc on macOS) Date: Sat, 21 Dec 2024 09:07:40 +0100 Message-ID: References: <86a5cqkc2g.fsf@gnu.org> <86o716ah09.fsf@gnu.org> <87ikrejok5.fsf@protonmail.com> <86cyhm9m9a.fsf@gnu.org> <87seqihyex.fsf@protonmail.com> <864j2xa5x0.fsf@gnu.org> <86r0618odu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26654"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: spd@toadstyle.org, pipcet@protonmail.com, acorallo@gnu.org, monnier@iro.umontreal.ca, 74966@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 21 09:09:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOuXx-0006me-B7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Dec 2024 09:09:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOuXr-0006Wc-TW; Sat, 21 Dec 2024 03:09:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOuXm-0006WC-T4 for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 03:09:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOuXm-0004qk-93 for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 03:09:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ltT3Z83WObHqX8eKVXzMruiNw2hlkSN/xFmy/eqCeLA=; b=D8vknkSd95fI6N/pahFQgnHhyCNhipSxWklhk/09/x+cDzIUsJeP+t+ukBaNLAWu9kkcSjLUkkNMUzqXitJ15LvtwhEG5TyFB0tjUFHLoKJDSKGPN3/WpVxzK+Cg7iAYZe9SUVEgWcagWVnWufcsQ4UU0w1E953lawr7SA0w4nWsW0MLZDubHeobdZgzskwqw3AhRAtTPVU1/tVRDkT/598pb+eHqJ4279Zaxlej/3EWqYtKPWBQnHepZktpSAgakj8ff5TLBXd+SZJ2MEc/zB+Jt8PwPrPykJghErPbXwBLHz4rw1GxxV/syaPB270EJiZCHyTN4mCs0YQWWgxr1w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOuXm-0003OP-3J for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 03:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2024 08:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74966 X-GNU-PR-Package: emacs Original-Received: via spool by 74966-submit@debbugs.gnu.org id=B74966.173476852513008 (code B ref 74966); Sat, 21 Dec 2024 08:09:02 +0000 Original-Received: (at 74966) by debbugs.gnu.org; 21 Dec 2024 08:08:45 +0000 Original-Received: from localhost ([127.0.0.1]:45122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOuXV-0003Ni-4b for submit@debbugs.gnu.org; Sat, 21 Dec 2024 03:08:45 -0500 Original-Received: from mail-ej1-f53.google.com ([209.85.218.53]:50581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOuXS-0003NZ-Nu for 74966@debbugs.gnu.org; Sat, 21 Dec 2024 03:08:43 -0500 Original-Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a9e8522445dso539574066b.1 for <74966@debbugs.gnu.org>; Sat, 21 Dec 2024 00:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734768462; x=1735373262; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ltT3Z83WObHqX8eKVXzMruiNw2hlkSN/xFmy/eqCeLA=; b=hhK+cM2wkCzD4RtqD9S9fU0RIxoHDtge5kvRZUzmnHinTJLaO2gtBGgsKjXOeanQ1g KP7OISKyY+81kFmYdd760lEiQouNQRj3urvUs+S2myd2MS+eB3IhrLJwBApR5DPSqZn9 sNWmwCM0O0ls4B2p7tScWwGKyjkOpHJapGrW6UqP9/Uv12xSFTdwzMqhwrbmPk74FmiT J/S8TMiYOQDPEWBFXtiEMmnC1tr1Hdyjgnrm0sQUL7qUQErjMPeEUE4CdDbqBs6RB03e RT1k83Hw55GUdCNhXMMFqmeNIjRzyGsc6kaaNhLd/nLmBAmVrITlQNPpFXnZS1YwIi6f Rxkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734768462; x=1735373262; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ltT3Z83WObHqX8eKVXzMruiNw2hlkSN/xFmy/eqCeLA=; b=WYj+xMk58i+ePC4mycnwrVOG4/e+Yg1e8cK39XNXpzhSANoF2hnIn5B0Ul1TKHSCV6 OQ5JksXCL8T/VFPZgNupvzVJkEoJ7GpQTjns1rvOolrhPZS9VP+viGtVTAVsduplbL3t AW8t+kHMfADBiVJNgBFWHpyVcqdFU5I0y/eQ/0vQECyAGp/wQAv+3dcq89j4CwoMadqL z45mJ+0qu30UKxWU9I5Vxr05chlwyerTlxNCjdy67sn/iOLuMvuQCRev0yP/S/NjZe9n DOcnEItc1YsSw0KN6VXauWnw5pZnqIIbZs1xODB1h/PqqPe/KZLHvwMGeYesg+13KVj0 qHLQ== X-Forwarded-Encrypted: i=1; AJvYcCV43rsBSLo1iKS62o2eOZFFUZt4FTcWo7Hxc/x3lhzBVTZbITrQTUodw42gyLcrM4e20M56oQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwqvxFqYeaMX5UJNZxIb8yMMR9QPu/q2SdFuvpsOkdOgINe56OX avE7WijvITjUJbb5kUU96DxeoZeGi1pxir5vACcYh+TFrMos6Jiv3MGpGQ== X-Gm-Gg: ASbGncvSTJNY6nnVgj/kwp29DLEUqlUOwni2iOhGU48Ndv5KkaQKAvZZua71mcTFV7u xSWF1HU8oiBotZPyJTzA4fk/PIlNIsUVZnMH4+stne7KF/6O029p32xOmTw+a/nNLrvajhYDPcD 4XCE53l+k6NVGnEWofA+oWwYaBpntnQytoNFjqfWDfAXAehEeqbBS1Yr+Jh3SCA8WAbhWFFHfwU 7Mir612kedXhrLHoGzCQNulj+KU8uoF37HSi03II1KH1LE1tXeG6Clbv4FrStFRNTQEBE093+86 xOPje8lwhmFF/pAsP5fi+bFxt71bHqwdEoSjPyAfsAD3ymoDGn/xKnz79JC2Iu9DVQ== X-Google-Smtp-Source: AGHT+IGL7lc3FcMvB1Grfebfv3MrcOYqAc9TjRPwT2UgJutD5ZyOODboztdvdzT961YBR5ryacWxuw== X-Received: by 2002:a17:907:3f8a:b0:aa6:acbb:3653 with SMTP id a640c23a62f3a-aac27027037mr530841766b.12.1734768461342; Sat, 21 Dec 2024 00:07:41 -0800 (PST) Original-Received: from pro2 (p200300e0b7162300456cde412cc45ae9.dip0.t-ipconnect.de. [2003:e0:b716:2300:456c:de41:2cc4:5ae9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e8953c1sm252382566b.49.2024.12.21.00.07.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2024 00:07:40 -0800 (PST) In-Reply-To: <86r0618odu.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 21 Dec 2024 09:51:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297497 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: Pip Cet , spd@toadstyle.org, acorallo@gnu.o= rg, >> monnier@iro.umontreal.ca, 74966@debbugs.gnu.org >> Date: Sat, 21 Dec 2024 08:08:40 +0100 >>=20 >> Eli Zaretskii writes: >>=20 >> >> I agree that the docfile hack in general is very hairy territory. It >> >> might be safer to simply accept the wrong docstrings for now, and Ger= d's >> >> patch does that, IIUC. Can we just apply that for now and add a FIXM= E? >> > >> > Maybe, but I'd like first to understand better the "wrong docstrings" >> > situations. >>=20 >> Maybe I can explain this. The current error's cause is that nativecomp >> currently (wrongly) assumes that it never needs an offset into DOC, so >> it reused Lisp_Subr::doc for its own purposes, namely as an index into a >> vector contained in an .eln file. The doc string of a function is found >> at that index. >>=20 >> Pip's patch changes nativecomp code stores the said index from above in >> a new Lisp_Subr::doc_index, and makes it possible to fix the wrong >> assumption from above, Nativecomp of course has to check which of the >> now two members it has to use, which Pip does. >>=20 >> Renaming Lisp_Subr::doc to Lisp_Object::doc_offset is a nice extra, IMO, >> because it makes it clearer what the member contains. > > OK, thanks. I'd like Andrea to chime in first and see if he can fix > this on the nativecomp side. Ok. > Also, Stefan said something about using a Lisp_Object for the value? Haven't seen or registered that, so I better leave that to Stefan to explain. > > And finally, does what you wrote explain the "wrong docstrings" > situation, or does it only explain the crash you saw? If the former, > I'm afraid I'm still missing something, because I don't understand how > this could cause a wrong docstring to be used. I understood that as "if we avoid setting Lisp_Subr::doc for native compiled functions, then we'll use "SKIP:..." as the doc string (e.g. for x-file-dialog), which is the wrong docstring." That would be the the little patch I posted first.