From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Aaron S. Hawley" Newsgroups: gmane.emacs.bugs Subject: bug#5955: completions in M-x find-library include .elc files Date: Thu, 15 Apr 2010 22:28:57 -0400 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1271386812 845 80.91.229.12 (16 Apr 2010 03:00:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 16 Apr 2010 03:00:12 +0000 (UTC) To: 5955@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 16 05:00:11 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O2bmq-0002aV-Rv for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Apr 2010 05:00:09 +0200 Original-Received: from localhost ([127.0.0.1]:33119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2bmq-0003Hh-Fh for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Apr 2010 23:00:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2blp-0002q3-Ke for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 22:59:05 -0400 Original-Received: from [140.186.70.92] (port=54972 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2blo-0002pO-0n for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 22:59:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2bll-0000ZQ-Ga for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 22:59:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38694) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2bll-0000ZM-Ca for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 22:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O2bTP-0001n0-GQ; Thu, 15 Apr 2010 22:40:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Aaron S. Hawley" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Apr 2010 02:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 5955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.12713855516852 (code B ref -1); Fri, 16 Apr 2010 02:40:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Apr 2010 02:39:11 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2bSZ-0001mT-B4 for submit@debbugs.gnu.org; Thu, 15 Apr 2010 22:39:11 -0400 Original-Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2bQo-0001lL-B7 for submit@debbugs.gnu.org; Thu, 15 Apr 2010 22:37:23 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:53403) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O2bQj-0002Jj-Mi for submit@debbugs.gnu.org; Thu, 15 Apr 2010 22:37:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2bQi-0005Ht-SZ for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 22:37:16 -0400 Original-Received: from [140.186.70.92] (port=39768 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2bQe-00053h-4C for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 22:37:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2bIh-0005CJ-6S for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 22:29:00 -0400 Original-Received: from mail-yw0-f191.google.com ([209.85.211.191]:43934) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2bIh-0005CC-3o for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 22:28:59 -0400 Original-Received: by ywh29 with SMTP id 29so1986319ywh.14 for ; Thu, 15 Apr 2010 19:28:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:received:message-id :subject:from:to:content-type; bh=Xw7umg24sRvXBCpRdtZBfDSlyGF2x4kA2ENyZM0OvCU=; b=x4COOS3+tjz/0pjLXTt4rNOodIaIZ+xRN2wKCL86irTiXvb4EwyCSli3Y2uONLlPO0 VgKcxxZUq9qutj+MXghXRQ61QGdMyB0XfAm+QejLObVvR9JYSYXJ7DRM3L2mJHFEWk2r AzTWYblSUr8YhTwLi2th5cc5A7vRn4B3Vv7aA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=etaKeYYJfzvQGWENyiGco8QwXl6Y1468MtPwAQxa+hl8LYOL5eH4wll0buOqQnagv6 roZfSWxmkQdW7dkZQ/senwP1r0Z/nvEjLXctiGv26blQPM46RDlOWkmn7UoUKJE3lmJ2 +LqCQbvzCizmtFiTLizkK6ikBkAPfGoBsm2aE= Original-Received: by 10.231.184.82 with HTTP; Thu, 15 Apr 2010 19:28:57 -0700 (PDT) Original-Received: by 10.150.180.16 with SMTP id c16mr1193011ybf.4.1271384937843; Thu, 15 Apr 2010 19:28:57 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Mailman-Approved-At: Thu, 15 Apr 2010 22:39:10 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 15 Apr 2010 22:40:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36267 Archived-At: Typing TAB or ? in M-x find-library shows .el and .elc files when it probably should just be the name of the library without the extension. Appears that this is a general problem with locate-file-completion-table in files.el. It appears to put all files in to the completion table without condition. The fix is just removing the first `push' operation. === modified file 'lisp/files.el' --- lisp/files.el 2010-03-31 01:51:54 +0000 +++ lisp/files.el 2010-04-16 01:57:24 +0000 @@ -760,7 +760,6 @@ (when (file-directory-p dir) (dolist (file (file-name-all-completions string-file dir)) - (push file names) (when (string-match suffix file) (setq file (substring file 0 (match-beginning 0))) (push file names))))) Hope this can get fixed. I'd love to have the size of my *completions* buffers reduced by a factor of 3! Thanks for Emacs, /a