From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] system-type cygwin with window-system w32 Date: Mon, 18 Jul 2011 19:34:41 +0200 Message-ID: References: <4E2377E2.1020804@gmail.com> <4E23D2BF.7080309@gmail.com> <4E245BB0.3000403@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1311013520 26017 80.91.229.12 (18 Jul 2011 18:25:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 18 Jul 2011 18:25:20 +0000 (UTC) Cc: Daniel Colascione , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 18 20:25:16 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QisVH-0004ZG-M8 for ged-emacs-devel@m.gmane.org; Mon, 18 Jul 2011 20:25:15 +0200 Original-Received: from localhost ([::1]:48670 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QisVG-0000E4-F7 for ged-emacs-devel@m.gmane.org; Mon, 18 Jul 2011 14:25:14 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:59643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QiriW-0000RB-Uy for emacs-devel@gnu.org; Mon, 18 Jul 2011 13:34:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QiriS-00035Q-B4 for emacs-devel@gnu.org; Mon, 18 Jul 2011 13:34:52 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:33010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QiriR-00034e-Tf for emacs-devel@gnu.org; Mon, 18 Jul 2011 13:34:48 -0400 Original-Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id C766F1C01D97; Mon, 18 Jul 2011 19:34:42 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id 96EAD1C0008D; Mon, 18 Jul 2011 19:34:42 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id H3CKmTmBp5UI; Mon, 18 Jul 2011 19:34:41 +0200 (CEST) Original-Received: from igel.home (ppp-88-217-110-34.dynamic.mnet-online.de [88.217.110.34]) by mail.mnet-online.de (Postfix) with ESMTP; Mon, 18 Jul 2011 19:34:41 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 501) id 6E43CCA293; Mon, 18 Jul 2011 19:34:41 +0200 (CEST) X-Yow: I'm gliding over a NUCLEAR WASTE DUMP near ATLANTA, Georgia!! In-Reply-To: <4E245BB0.3000403@cs.ucla.edu> (Paul Eggert's message of "Mon, 18 Jul 2011 09:13:36 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 212.18.0.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:142130 Archived-At: Paul Eggert writes: > I have qualms about this part of the patch, in lisp.h: > > +#define t(...) \ > + ({ \ > + fprintf (stderr, "T:%s:%u: ", \ > + __FUNCTION__, __LINE__); \ > + fprintf (stderr, __VA_ARGS__); \ > + fputc ('\n', stderr); \ > + }) > + > > Is this some sort of test scaffolding that is intended to be > removed before the patch actually goes in? If not, it has > some problems. The name "t" is too short and cryptic. > The ({...}} construction is not standard C and won't work > with many non-GCC compilers. The __FUNCTION__ macro is also > GCC-specific. This is all not a problem if the macro is unused, but the C99 variable argument list will cause C89 compilers to trip over. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."