Re: [PATCH] system-type cygwin with window-system w32

[Andreas Schwab <schwab@linux-m68k.org>]

Paul Eggert <eggert@cs.ucla.edu> writes:

> I have qualms about this part of the patch, in lisp.h:
>
> +#define t(...)                                          \
> +    ({                                                  \
> +      fprintf (stderr, "T:%s:%u: ",                     \
> +               __FUNCTION__, __LINE__);                 \
> +      fprintf (stderr, __VA_ARGS__);                    \
> +      fputc ('\n', stderr);                             \
> +    })
> +
>
> Is this some sort of test scaffolding that is intended to be
> removed before the patch actually goes in?  If not, it has
> some problems.  The name "t" is too short and cryptic.
> The ({...}} construction is not standard C and won't work
> with many non-GCC compilers.  The __FUNCTION__ macro is also
> GCC-specific.

This is all not a problem if the macro is unused, but the C99 variable
argument list will cause C89 compilers to trip over.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."