bug#9550: Toggling whitespace modes appears to be broken in 24

bug#9550: Toggling whitespace modes appears to be broken in 24

[Sarah]

Toggling for instance whitespace-newline-mode does not work. Once it's
on, it stays on. This seems to have some added symptoms of breaking the
rest of whitespace too, on occasion.

Steps to reproduce:

M-x whitespace-newline-mode
M-x whitespace-newline-mode

That's it. :-)


In GNU Emacs 24.0.50.1 (i386-apple-darwin11.1.0, NS apple-appkit-1138.00)
of 2011-09-18 on antistof
Windowing system distributor `Apple', version 10.3.1138
configured using `configure '--prefix=/usr/local/Cellar/emacs/HEAD' '--without-dbus' '--enable-locallisppath=/usr/local/share/emacs/site-lisp' '--infodir=/usr/local/Cellar/emacs/HEAD/share/info/emacs' '--with-ns' '--disable-ns-self-contained' 'CC=/usr/bin/llvm-gcc' 'CFLAGS=-O3 -march=core2 -msse4.1 -w -pipe''

Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: UTF-8
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
tooltip-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t

Recent input:
M-x e <backspace> r e p o r <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr message format-spec rfc822 mml easymenu
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader
emacsbug time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel
ns-win tool-bar dnd fontset image fringe lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs
button faces cus-face files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process ns multi-tty emacs)

bug#9550: Toggling whitespace modes appears to be broken in 24

[Stefan Monnier]

>>>>> "Sarah" == Sarah  <sbrofeldt@gmail.com> writes:

> Toggling for instance whitespace-newline-mode does not work. Once it's
> on, it stays on. This seems to have some added symptoms of breaking the
> rest of whitespace too, on occasion.

> Steps to reproduce:

> M-x whitespace-newline-mode
> M-x whitespace-newline-mode

> That's it. :-)

Thanks.  I installed the patch below which should fix it.


        Stefan


=== modified file 'lisp/whitespace.el'
--- lisp/whitespace.el	2011-05-04 01:02:09 +0000
+++ lisp/whitespace.el	2011-09-19 18:05:20 +0000
@@ -1105,8 +1105,8 @@
   :global     nil
   :group      'whitespace
   (let ((whitespace-style '(face newline-mark newline)))
-    (whitespace-mode whitespace-newline-mode)
-    ;; sync states (running a batch job)
+    (whitespace-mode (if whitespace-newline-mode 1 -1))
+    ;; Sync states (running a batch job).
     (setq whitespace-newline-mode whitespace-mode)))
 
 \f