From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.bugs Subject: bug#12119: 24.1.50; symbol-macrolet regresssion Date: Sun, 05 Aug 2012 13:38:45 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344166765 28177 80.91.229.3 (5 Aug 2012 11:39:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 5 Aug 2012 11:39:25 +0000 (UTC) Cc: 12119@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 05 13:39:25 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SxzB2-0000F4-CC for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Aug 2012 13:39:20 +0200 Original-Received: from localhost ([::1]:42019 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxzB1-0004fk-O7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Aug 2012 07:39:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxzAz-0004cn-5O for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2012 07:39:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxzAx-0004NV-Mi for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2012 07:39:17 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxzAx-0004NQ-JV for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2012 07:39:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SxzIU-0007vC-01 for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2012 07:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Helmut Eller Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Aug 2012 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12119 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12119-submit@debbugs.gnu.org id=B12119.134416719830421 (code B ref 12119); Sun, 05 Aug 2012 11:47:01 +0000 Original-Received: (at 12119) by debbugs.gnu.org; 5 Aug 2012 11:46:38 +0000 Original-Received: from localhost ([127.0.0.1]:34786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SxzI5-0007uZ-RF for submit@debbugs.gnu.org; Sun, 05 Aug 2012 07:46:38 -0400 Original-Received: from mail-we0-f172.google.com ([74.125.82.172]:40806) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SxzI3-0007uS-IH for 12119@debbugs.gnu.org; Sun, 05 Aug 2012 07:46:36 -0400 Original-Received: by weyu54 with SMTP id u54so1454210wey.3 for <12119@debbugs.gnu.org>; Sun, 05 Aug 2012 04:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=CcFvDznpL29yvpeK+RnLgW+CteSHsLvNlbUbPD8JGqs=; b=dVZNYHckYJvxrM+f5MEWu6SeN+Cjgx0KHmz11bhnL5rC9dZGlZfb+MebqRZnIqIxOT 56rvz4XGVZSUDIYgJf/F6mq2y9qNbC9tytV4OBy6sh6qc5qwrbY0qS9fhDAPJG0ld3Lf cpxAxWgjt73KlovvNPOuJCcsvFsK7JbKSHSGsuJKaUsqNtn9dadcnZKCoJoPalkemM2Y C1NE1DaWAWmkjatDR8nLWgnxMeDrWhPkpRFalRgE+CtEhi7IA8mgOXhuhFxvH31W6BNy ZsnZZzaNpFu73d1ZSQxIGSpT8Lr14iUSpI3LEcqbomi+TjJhrxyrCMaFVCaNwbHO7tMi RDTA== Original-Received: by 10.180.78.135 with SMTP id b7mr10425928wix.11.1344166728024; Sun, 05 Aug 2012 04:38:48 -0700 (PDT) Original-Received: from ix (dial-182251.pool.broadband44.net. [212.46.182.251]) by mx.google.com with ESMTPS id b7sm13439310wiz.9.2012.08.05.04.38.47 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Aug 2012 04:38:47 -0700 (PDT) Original-Received: from helmut by ix with local (Exim 4.72) (envelope-from ) id 1SxzAT-0000VY-VA; Sun, 05 Aug 2012 13:38:45 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 04 Aug 2012 19:40:46 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:62842 Archived-At: On Sun, Aug 05 2012, Stefan Monnier wrote: >> Also, in Emacs 22 the macroepansion (via cl-macroexpand-all) >> produces something like > >> (let ((outer '42)) >> (let ((outer 'inner)) >> (progn >> (or >> (eq outer 'inner) >> (signal 'cl-assertion-failed >> (list >> '(eq x 'inner)))) >> nil))) > > While the above expansion returns the right value, it is not correct. > The right expansion would be > > (let ((outer '42)) > (let ((x 'inner)) > (progn > (or > (eq x 'inner) > (signal 'cl-assertion-failed > (list > '(eq x 'inner)))) > nil))) > >> while in Emacs 24 it looks like > >> (let ((outer '42)) >> (progn >> (let ((x 'inner)) >> (progn >> (or >> (eq outer 'inner) >> (signal 'cl-assertion-failed >> (list >> '(eq x 'inner)))) >> nil)))) > >> Such a change should be documented. > > That's an accident, so it shouldn't be documented. The new code is no > better than the old one, and arguably slightly worse since it fails in > your test while the old code worked. > I'm not yet sure how we can fix it properly, tho. Well, it depends on the definition of "correct". The old version seems to do what the documentation says, i.e., let binding the variable is treated like letf. What you call "correct" may be closer to what ANSI CL does, but such a change should be documented. Either way, I don't see the point in breaking existing code. Helmut