From: David Edmondson <dme@dme.org>
To: Thien-Thi Nguyen <ttn@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH v1] Fix errors generated when multiple IRC clients talk to a single IRC proxy.
Date: Wed, 15 Oct 2014 08:58:50 +0100 [thread overview]
Message-ID: <m2wq81kblx.fsf@fenchurch.hh.sledj.net> (raw)
In-Reply-To: <87wq81om34.fsf@zigzag.favinet>
On Wed, Oct 15 2014, Thien-Thi Nguyen wrote:
> () David Edmondson <dme@dme.org>
> () Wed, 8 Oct 2014 15:03:17 +0100
>
> + (when erc-channel-new-member-names
> + (maphash (lambda (nick user)
> + (if (null (gethash nick erc-channel-new-member-names))
> + (erc-remove-channel-user nick)))
> + erc-channel-users)
> + (setq erc-channel-new-member-names nil)))
>
> I don't know if this is the case for Emacs Lisp, but i've been
> burned when (and am thus now leery of) doing a destructive
> operation on the hash table while hash walking, elsewhere
> (here, ‘erc-remove-channel-user’ boils down to ‘remhash’).
>
> Better to restructure as two passes: accumulation + destruction.
> That way, we cleanly avoid a bug, whether manifest or latent.
I understand your concern, however this is not that bug.
next prev parent reply other threads:[~2014-10-15 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 14:03 [PATCH v1] Fix errors generated when multiple IRC clients talk to a single IRC proxy David Edmondson
2014-10-15 6:58 ` Thien-Thi Nguyen
2014-10-15 7:06 ` Thien-Thi Nguyen
2014-10-15 7:58 ` David Edmondson [this message]
2014-10-15 13:54 ` Stefan Monnier
2014-10-15 15:50 ` Mirek Kaim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wq81kblx.fsf@fenchurch.hh.sledj.net \
--to=dme@dme.org \
--cc=emacs-devel@gnu.org \
--cc=ttn@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.