From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix (letrec ((ignore))) Date: Sat, 12 Dec 2015 15:10:05 -0800 Message-ID: References: <20151211161116.GA8923@apertron.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1449962056 10310 80.91.229.3 (12 Dec 2015 23:14:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Dec 2015 23:14:16 +0000 (UTC) Cc: Artur Malabarba , Zack Piper , =?utf-8?Q?Aur=C3=A9lien?= Aptel , Emacs developers To: Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 13 00:14:09 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a7tMf-0001sA-0O for ged-emacs-devel@m.gmane.org; Sun, 13 Dec 2015 00:14:09 +0100 Original-Received: from localhost ([::1]:53305 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7tMe-0000sx-6w for ged-emacs-devel@m.gmane.org; Sat, 12 Dec 2015 18:14:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7tLT-0007y4-QG for emacs-devel@gnu.org; Sat, 12 Dec 2015 18:12:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7tLR-0007Du-7V for emacs-devel@gnu.org; Sat, 12 Dec 2015 18:12:55 -0500 Original-Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]:35710) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7tLR-0007Dq-1U for emacs-devel@gnu.org; Sat, 12 Dec 2015 18:12:53 -0500 Original-Received: by padhk6 with SMTP id hk6so43764262pad.2 for ; Sat, 12 Dec 2015 15:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mail-followup-to:mime-version:content-type; bh=1cKDbETcjoDOezLYvjhvTBQ3b8L5YimPN+rU+Ufl9aU=; b=gcZZXSRJTMyHRmg8sDUJDW48zrw1+fs+UhAXVZ9L5aUZkWEybr8ppHFEtahzDqALtr uyGtqsKhgceuPrWQVKyFRHiJ0W6rIjRwwJA68w6uJ9nuhf3zq9SoxeYzLIT9NcSQ6tnJ GpieIEdyKmul4sVVx1sediLgHjI6a5taug16fDmz0d6EhnAmtM1ri2WVYyhIfM6NKzGW bjXdG/SQuZLUhDGlpG45xqjwWwANdiJtszCXYE1c2VCm+B7xDtNTCDTmtOzDb3+O+izZ EkeUvo0kOhs5Ues1ogKWocnRBPDrCSf2nhr68+oI8zg7t9JrGSklcwibyMyWVKzsoS0D xFCg== X-Received: by 10.67.5.164 with SMTP id cn4mr34314229pad.141.1449961972641; Sat, 12 Dec 2015 15:12:52 -0800 (PST) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id b17sm33223944pfj.43.2015.12.12.15.12.48 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 12 Dec 2015 15:12:51 -0800 (PST) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id 42FDB114636FE; Sat, 12 Dec 2015 15:12:48 -0800 (PST) In-Reply-To: (Kaushal Modi's message of "Fri, 11 Dec 2015 15:08:18 -0500") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin) Mail-Followup-To: Kaushal Modi , Zack Piper , Artur Malabarba , =?utf-8?Q?Aur=C3=A9lien?= Aptel , Emacs developers X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196182 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >>>>> Kaushal Modi writes: > Would it be better instead to fix the org-mode files for consistency? > - Replace all instances of > (letrec ((SOMEVAR)) ..) > with > (letrec ((SOMEVAR nil)) ..) (letrec ((SOMEVAR))) should be an error, since the value is missing. If one wishes to declare SOMEVAR with a nil value, the correct forms are: (letrec ((SOMEVAR nil))) (letrec (SOMEVAR)) > Question to emacs-devel: What would be the right approach? We should give `letrec' the same treatment we've given to `setq' and `setf', and then Org and other users should be corrected. =2D-=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGcBAEBCgAGBQJWbKlNAAoJEMFE2PTxn+YwBPML/iA4WosRAL2PnzY4oJ28ZhJO qAu7Cc7IRQuE55HZ6A545ArQjVVNP3DH34x1VBpq71tCpbXMx/3q2YpsnsuawBIj WZEEtvXHiJYWaUAxYAV/tMolcIv0s55HTR8jvENMtmi/0sTihEZsgKQdxPgbY6gw biIHFzNy1WLn4o10TWCiB1W1XqBO76d04szafFC+kDIJiPbUSnsW3GVkQOBBZmyt HYEgNb6m7thHW5HnUAh85BYzRtaJ6oquwuZrEcaLLyGuZvfWxj2gDzN05bx8jAWo G89cI5VhkBiGtzPg3LMzn/x3CzNk/Z+uei7fHPjIfZRibKKUlJ6jCtzqsbLUfHxZ xFP/IqrrStuAXGZp6Gdy9OK/Tn4gNHnBetj4SrlhNaHPHesToFL7dozzvUezinze tlubzpS/hZErwMqgIwvFVFSoqF2D2kVAAt7oDTU1JWADKxtcIQRKaVntY1r3jICI z1OBlyjei9Yr4xbr5hfB6MfUKYRHOh89+4+7RqDJjg== =bdfm -----END PGP SIGNATURE----- --=-=-=--