From: charles@aurox.ch (Charles A. Roelli)
To: charles@aurox.ch (Charles A. Roelli)
Cc: 29053@debbugs.gnu.org
Subject: bug#29053: 26.0.90: scroller cannot be dragged to bottom of window
Date: Tue, 31 Oct 2017 22:12:47 +0100 [thread overview]
Message-ID: <m2wp3b9g34.fsf@aurox.ch> (raw)
In-Reply-To: <m2y3nu9ko7.fsf@aurox.ch> (charles@aurox.ch)
Seems that reverting this commit removes the issue:
commit e683a2570be6f2e4f8defa4e7ee35a7d87f18918
Author: Alan Third <alan@idiocy.org>
Ref: tags/emacs-26.0.90~2038
Date: Sun May 1 13:04:07 2016 +0200
Implement horizontal scroll bars on NS
* lisp/scroll-bar.el (horizontal-scroll-bars-available-p): Remove NS
check.
* lisp/term/ns-win.el: Remove custom NS scroll-bar handlers and bind
scroll-bar mouse clicks to standard handlers.
* src/nsterm.h (EmacsScroller): Add 'horizontal' property and rename
pixel_height to pixel_length.
* src/nsterm.m (x_set_window_size): Remove left-hand scroll-bar code. It
caused scroll-bars to be over-drawn and the best working solution
appears to be complete removal.
(ns_set_horizontal_scroll_bar): Rewrite to handle horizontal scrollers
correctly.
(ns_set_vertical_scroll_bar): Set width to actual scroller width.
(setFrame): Handle horizontal case.
(dealloc): Handle horizontal case.
(judge): Handle horizontal case.
(setPosition): Rename pixel_height to pixel_length.
(sendScrollEventAtLoc): Handle horizontal case.
(mouseDown): Handle horizontal case and general tidy up of code.
(mouseDragged): Handle horizontal case. Call sendScrollEventAtLoc with
absolute pixel size instead of ratio.
* src/window.h: Remove NS check.
macOS 10.6 is probably a special case.
next prev parent reply other threads:[~2017-10-31 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 12:00 bug#29053: 26.0.90: scroller cannot be dragged to bottom of window Charles A. Roelli
2017-10-29 12:22 ` Eli Zaretskii
2017-10-29 12:56 ` Charles A. Roelli
2017-10-31 21:12 ` Charles A. Roelli [this message]
2017-11-01 16:52 ` Alan Third
2017-11-01 20:43 ` Charles A. Roelli
2017-11-02 22:54 ` Alan Third
2017-11-04 9:57 ` Charles A. Roelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wp3b9g34.fsf@aurox.ch \
--to=charles@aurox.ch \
--cc=29053@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.