all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: charles@aurox.ch (Charles A. Roelli)
To: 綾小路剛志 <ayanokoji.takesi@gmail.com>
Cc: 24017-done@debbugs.gnu.org
Subject: bug#24017: 24.5; vc-dir-mark loop infinitely when region is active and cursor position in last blank line.
Date: Mon, 18 Dec 2017 20:59:07 +0100	[thread overview]
Message-ID: <m2wp1jdcz8.fsf@aurox.ch> (raw)
In-Reply-To: <CAN7WbiYs1mSR3h2pKzLA_WiLtMyJMJpgbt+ZsyoGrozJDnhZMA@mail.gmail.com> (message from 綾小路剛志 on Sun, 17 Jul 2016 19:07:50 +0900)

> From: 綾小路剛志 <ayanokoji.takesi@gmail.com>
> Date: Sun, 17 Jul 2016 19:07:50 +0900
> 
> How to reproduce bug.
> 
> 1. Create a directory and move there.
> 
> mkdir BUG
> cd BUG
> 
> 2. Create files and start emacs.
> 
> $ echo foo > foo.txt 
> $ echo bar > bar.txt 
> $ LANG=C emacs -Q
> 
> 3. Open a file.
> 
> C-x C-f foo.txt
> 
> 4. Create repository (this example use SVN for VC backend).
> 
> C-x v v SVN <RET> <RET>
> 
> 5. Open *vc-dir* buffer
> 
> C-x v d <RET>
> At now, vc-dir buffer displays directory contents like bellow.
> 
> VC backend : SVN
> Working dir: ~/BUG/
> Repository : file:///home/h1r0s/BUG/SVN
> 
> ./
> unregistered SVN
> unregistered bar.txt
> added foo.txt
> 
> 6. Select last file's line entirely.
> 
> C-s <RET> foo.txt C-a S-<Down>
> 
> 7. Mark the region
> 
> M-x vc-dir-mark (or hit 'm')
> 
> ... And this will never return.
> 
> Thanks.
> ---
> Ayanokoji Takesi <ayanokoji.takesi@gmail.com>
> 
> In GNU Emacs 24.5.1 (i686-pc-linux-gnu, GTK+ Version 3.4.4)
> of 2015-04-27 on himawari
> Windowing system distributor `Fedora Project', version 11.0.11203000
> System Description: Fedora release 17 (Beefy Miracle)

Thanks, I think I've fixed this now.

  commit 9685774e38dc6f5670c8e57dc9f49335f4f738b6
  Date:   Mon Dec 18 20:51:30 2017 +0100

  Fix infinite loop in vc-dir-mark-unmark

  * lisp/vc/vc-dir.el (vc-dir-mark-unmark): Prevent from getting
  stuck on the same line in an infinite loop.  (Bug#24017)





      reply	other threads:[~2017-12-18 19:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-17 10:07 bug#24017: 24.5; vc-dir-mark loop infinitely when region is active and cursor position in last blank line 綾小路剛志
2017-12-18 19:59 ` Charles A. Roelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2wp1jdcz8.fsf@aurox.ch \
    --to=charles@aurox.ch \
    --cc=24017-done@debbugs.gnu.org \
    --cc=ayanokoji.takesi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.