bug#38421: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

bug#38421: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

[Filipp Gunbin]

When gnus-visual is nil, attachments of type text/x-patch (and probably
others) still get fontified when Gnus displays them inline.

I have a patch, will attach it soon.
Thanks.


In GNU Emacs 27.0.50 (build 9, x86_64-apple-darwin19.0.0, NS appkit-1894.10 Version 10.15.1 (Build 19B88))
 of 2019-11-28 built on fgunbin.local
Repository revision: b05aa8d742d80aeb692c54289e8ccb074a68bf51
Repository branch: master
System Description:  Mac OS X 10.15.1

bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

[Filipp Gunbin]

[-- Attachment #1: Type: text/plain, Size: 25 bytes --]

tags 38421 + patch
quit


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1401 bytes --]

From 5ce40fc8e81a82d173e9cb17fa3390369b9b87f4 Mon Sep 17 00:00:00 2001
From: Filipp Gunbin <fgunbin@fastmail.fm>
Date: Thu, 28 Nov 2019 23:24:40 +0300
Subject: [PATCH] Fontify inline article parts only if gnus-visual says to do
 so

* lisp/gnus/mm-view.el (mm-display-inline-fontify): Check gnus-visual
before calling font-lock-ensure.
---
 lisp/gnus/mm-view.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/gnus/mm-view.el b/lisp/gnus/mm-view.el
index 559ec7a669..3762e866fb 100644
--- a/lisp/gnus/mm-view.el
+++ b/lisp/gnus/mm-view.el
@@ -32,6 +32,7 @@
 
 (autoload 'gnus-completing-read "gnus-util")
 (autoload 'gnus-article-prepare-display "gnus-art")
+(autoload 'gnus-visual-p "gnus")
 (autoload 'vcard-parse-string "vcard")
 (autoload 'vcard-format-string "vcard")
 (autoload 'fill-flowed "flow-fill")
@@ -499,8 +500,9 @@ mm-display-inline-fontify
 			 (copy-sequence auto-mode-alist))))
 	      (set-auto-mode)
 	      (setq mode major-mode)))
-	  ;; Do not fontify if the guess mode is fundamental.
-	  (unless (eq major-mode 'fundamental-mode)
+          (when (and (gnus-visual-p 'article-highlight 'highlight)
+                     ;; Do not fontify if the guessed mode is fundamental
+                     (not (eq major-mode 'fundamental-mode)))
 	    (font-lock-ensure))))
       (setq text (buffer-string))
       (when (eq mode 'diff-mode)
-- 
2.24.0

Re: bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

[Filipp Gunbin]

Could someone please review the patch? (bug#38421)

It's simple, but I'm not sure about using gnus-visual-p in mm-* files.

Thanks.

bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

[Lars Ingebrigtsen]

Filipp Gunbin <fgunbin@fastmail.fm> writes:

> Could someone please review the patch? (bug#38421)
>
> It's simple, but I'm not sure about using gnus-visual-p in mm-* files.

I don't think we can use that function there, because these are general
utility functions (used by mh-e, for instance).

As the comment in mm-view.el says:

;; Shouldn't these functions check whether the user even wants to use
;; font-lock?

They should, indeed.  But I'm not quite sure what the correct approach
for the application (that is Gnus) to inhibit these functions...

What functions to use is decided by mm-inline-media-tests, and there's
no way to use one version if we want highlights and another if we
don't...

Anybody got any ideas here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

[Lars Ingebrigtsen]

Filipp Gunbin <fgunbin@fastmail.fm> writes:

> Could someone please review the patch? (bug#38421)
>
> It's simple, but I'm not sure about using gnus-visual-p in mm-* files.

I don't think we can use that function there, because these are general
utility functions (used by mh-e, for instance).

As the comment in mm-view.el says:

;; Shouldn't these functions check whether the user even wants to use
;; font-lock?

They should, indeed.  But I'm not quite sure what the correct approach
for the application (that is Gnus) to inhibit these functions...

What functions to use is decided by mm-inline-media-tests, and there's
no way to use one version if we want highlights and another if we
don't...

Anybody got any ideas here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> What functions to use is decided by mm-inline-media-tests, and there's
> no way to use one version if we want highlights and another if we
> don't...
>
> Anybody got any ideas here?

Apparently not, so I added a variable callers (like Gnus) can bind to
switch font-locking off.  Seems to work OK for me (in Emacs 28).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

[Filipp Gunbin]

On 02/08/2020 19:45 +0200, Lars Ingebrigtsen wrote:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> What functions to use is decided by mm-inline-media-tests, and there's
>> no way to use one version if we want highlights and another if we
>> don't...
>>
>> Anybody got any ideas here?
>
> Apparently not, so I added a variable callers (like Gnus) can bind to
> switch font-locking off.  Seems to work OK for me (in Emacs 28).

Thanks!
Filipp

bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> What functions to use is decided by mm-inline-media-tests, and there's
> no way to use one version if we want highlights and another if we
> don't...
>
> Anybody got any ideas here?

Apparently not, so I added a variable callers (like Gnus) can bind to
switch font-locking off.  Seems to work OK for me (in Emacs 28).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil

[Filipp Gunbin]

Could someone please review the patch? (bug#38421)

It's simple, but I'm not sure about using gnus-visual-p in mm-* files.

Thanks.