From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: STatus of MPS branch Date: Mon, 22 Apr 2024 06:58:15 +0200 Message-ID: References: <878r16n5jl.fsf@gmail.com> <87ttjulb16.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13718"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 22 06:59:07 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ryllj-0003Lv-BE for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Apr 2024 06:59:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryll1-0004cd-2o; Mon, 22 Apr 2024 00:58:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rylkz-0004cT-Fd for emacs-devel@gnu.org; Mon, 22 Apr 2024 00:58:21 -0400 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rylkx-00043t-ML for emacs-devel@gnu.org; Mon, 22 Apr 2024 00:58:20 -0400 Original-Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-56e48d0a632so5894464a12.2 for ; Sun, 21 Apr 2024 21:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713761898; x=1714366698; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mNJ6gpOuqz/PDCULomKLtu8+ekghZNPXV6NFeLJV7xc=; b=g0Lfd3WLkzMDqBfuDi+74pCADxtboI/0dILWRrZ/ApOyBz0kWAnvfQNbrGAoFtMNdo Ehz+tFwH1dmhV7R4ofIQipDpuLLvYFwAKMS696//E0KuVJn3tJVzZx1SUaSBKXod3KRv AUx+/vg6GTJ1cXOc3zUF3Bb3v7+fkbc+KMMwgA/jiAdGoG/lmUjmqOd2c9edxP2+I8NB hStkR2skpQaxGbYZLYIOS2D0uMIQ5ABQfzKiqxMKXUnGklFaWJnQF85glhEOVdve2Qrk KcEwgWqqfyUnPC08SzR2z8YVoF2VEQK1uHDHbCA8WOR4ZOV7+bBoEzClXBmhk2ETHBPj ncwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713761898; x=1714366698; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mNJ6gpOuqz/PDCULomKLtu8+ekghZNPXV6NFeLJV7xc=; b=u4KEWZebwLfjKzD4qzBzTZ4nEmH8aJETVM06zQW+3QX/MMnUOuX7BhmLUxm1iUTECa BfkQiBjQap7n+CAHQNSc49wJhDrw7qh2UTIknapdqGoNH/pSHV7gU3XwGyVgWhv1+h+o O3KU/ySkk+WiFFOsgvw0R1ca8eqwvGGaNGWuYOwKx0BOKCGpd1VGbiTG0LNM+IAlqxjq b+Ro8RJfPCReu2MpHzllJUv2q/+6grn8xPTs7vxTyrm1pyspwDbuZUOBOOyZ7npAewtj b/EY+vsMmvX6O5OnqYq7WTLZO+Vov0i0h8fwLV1gMGCu5Hnx+OXBLLElRqxnZdoPGglj +4Dg== X-Gm-Message-State: AOJu0YyHVTNY/XbGugRCbprem0X0KJRF2MRQlNi0CEReainBUa5GEYNS hxYkfnMwsVxpxs61TqhBQSV+oNthkJ9csZFficHrrsBn6dd68TNKaIPBBg== X-Google-Smtp-Source: AGHT+IFNtdR8UzZUKKrus90xmqsNVHO6OC4HlBTsFcyVFptf/pdyzEAgPbefmeioUv9hnov4Xchc9g== X-Received: by 2002:a17:906:c1cf:b0:a52:3316:bc29 with SMTP id bw15-20020a170906c1cf00b00a523316bc29mr8091554ejb.3.1713761897608; Sun, 21 Apr 2024 21:58:17 -0700 (PDT) Original-Received: from Pro.fritz.box (p4fe3af79.dip0.t-ipconnect.de. [79.227.175.121]) by smtp.gmail.com with ESMTPSA id jy2-20020a170907762200b00a55bb9704d2sm371378ejc.102.2024.04.21.21.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 21:58:17 -0700 (PDT) In-Reply-To: <87ttjulb16.fsf@gmail.com> (Helmut Eller's message of "Sun, 21 Apr 2024 22:24:05 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317945 Archived-At: Helmut Eller writes: > On Sun, Apr 21 2024, Gerd M=C3=B6llmann wrote: > > I did this; GCC stopped complaining but otherwise it made no observable > difference. Thanks. I've done that now on the branch, too + a compile-time assertion for clang. > Without some change GCC emits lots of warnings of this kind: > igc.c: In function =E2=80=98to_words=E2=80=99: > igc.c:246:49: warning: suggest braces around empty body in an =E2=80=98el= se=E2=80=99 statement [-Wempty-body] > 246 | igc_assert (nbytes % sizeof (mps_word_t) =3D=3D 0); > | ^ > > So maybe the macro should end with "else {}". That would also not work. Something like if (x) igc_assert (y); else would then be a syntax error. It would expand to if (x) if (...) ... else { } ; else and the last else hangs in the air. This is a situation where the code is definitely correct, and I find GCC a bit over-eager, or maybe it's the compiler switches Emacs uses. You could put a #pragma GCC diagnostic ignored "-Wempty-body" Or put "do { ... } while (0)" around what's currently the macro body, i.e. #define igc_assert(e) do { \ ... original macro body here. } while (0) I'll reply to the rest in a different mail..