From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS image cache Date: Fri, 03 May 2024 13:43:11 +0200 Message-ID: References: <875xvvp3fo.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1170"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Emacs Devel To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 03 13:44:17 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2rKr-00008b-9V for ged-emacs-devel@m.gmane-mx.org; Fri, 03 May 2024 13:44:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2rK7-0002Iw-FD; Fri, 03 May 2024 07:43:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2rK3-0002Ic-2Y for emacs-devel@gnu.org; Fri, 03 May 2024 07:43:27 -0400 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2rJr-00086s-4W; Fri, 03 May 2024 07:43:17 -0400 Original-Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-572adaa172cso2091218a12.1; Fri, 03 May 2024 04:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714736592; x=1715341392; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dzMZUkBAfS5beob1M8LfStdW2uICj11xTvXkv4Xjk+0=; b=YN6JmHTjT2VbEnP8BCCQoL30TXLTgquMn/ko0dXpZ6XBbaptW4m9R99KukURof3HT6 WIbumypQBLhCX6s17fYPsDYpBbu+tWlL4tYG3N9WpCmpN2P00UX7mgXdd4M/kaHvEk9l lfu4Pz7oNS6nTWLRf5nApjHbU4DF1IkaQsc81BnUZf1JFV9mI/2og1qYD5XQXtAathns CD59lvxjXkqGbrTXXfHV64vkC2Efd0m6hrUheu2OVZhbT3pmOoGJx0gwfrWuoiOx6tZ6 esNkX4or/FXqwJxM24BWaQEEojghNdm9CuSGHQPy/2IhLL4jzPw+hJBwJUq7lSv0OP+l rz9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714736592; x=1715341392; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dzMZUkBAfS5beob1M8LfStdW2uICj11xTvXkv4Xjk+0=; b=Nj/ESuN3OGMYtHMUbxK3v9olKhwVH4EDWceS6wV0nIIMsRWa1L65SpLx1pFjlyz+zR WjLyFINmWInRYdELXtaO8DKXZVuEYEhuH5dNapsn84HnjWHJIEQcIsOUDYh9qG40+r8q x99rVmaHV/YfsuoJne2Vx9XQczs9hvhNL+S63KlVrzT3XS2PL65hiM7eIe95SLe7q4SA kw8A4HuHY3MS+qZn2iPoFp1pRJ/w8EtEe61Laso+1f3KnVQ2Bw3XWMImyWPB4xruh6eO iECAUl/dYBjbCd40r415h1KduO0rvW+0y0fF9QOywLaBXJjrtVNr9OwcnFzExqfoK/1u qB7w== X-Forwarded-Encrypted: i=1; AJvYcCU4EZDzAe5RjbtIPMsndEqvtg/grDKPlbwAROnk1vFAXw6iRilxJEMf2lzQEWBaXlyLxEfVWNXkSLkb47MKIio7V7Pv X-Gm-Message-State: AOJu0Yx9RPYmoql64ZZi17qPjRqs7Du1ZyeajH+UzgB3Ltuz37EwRdYQ p4X8n7jHpcOHKYOxtDTm3rPNvDBdVGKsIjNl0mcWFXZfrBj9sEf+6zLCog== X-Google-Smtp-Source: AGHT+IEglBDwYPVmx85RkcsURnUSR0FiATAyrA7sESuWBI/5nE3f108EbnW/ShpwIzY2uPbhxV+Y6Q== X-Received: by 2002:a50:8ad6:0:b0:571:da40:22d9 with SMTP id k22-20020a508ad6000000b00571da4022d9mr4158095edk.10.1714736592463; Fri, 03 May 2024 04:43:12 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36a94.dip0.t-ipconnect.de. [217.227.106.148]) by smtp.gmail.com with ESMTPSA id p7-20020aa7d307000000b005722d871e4csm1585809edq.90.2024.05.03.04.43.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 04:43:11 -0700 (PDT) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Fri, 03 May 2024 13:22:15 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318662 Archived-At: Gerd M=C3=B6llmann writes: > Helmut Eller writes: > >> On Fri, May 03 2024, Gerd M=C3=B6llmann wrote: >> >>> I think I have one: struct terminal's image_cache is not traced. AFAICS, >>> the cache is malloc'd and contains struct image which is an MPS object. >>> >>> WDYT? >> >> Two options come to mind: >> 1) trace it in fix_terminal >> 2) register terminal.c:terminal_list as root. >> >> It seems to me that creating a root is more "correct". > > I'm meanhile tending ta the third option: make iamge_cache an MPS object > like face_cache. For a reason that's proobably the reason why I made > fache_cache an MPS object: > > While we scan an object, MPS gives us exclusive access to it. I think we > want that for these caches, so that scanning does not interfere iwth the > client modifying the cache? > > Right? I've doen that now. It is right :-)