From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.bugs Subject: bug#72313: 31.0.50; Warning about cl-member possibly being undefined when using cl-pushnew Date: Sat, 27 Jul 2024 23:25:14 +0200 Message-ID: References: <874j8bx5gr.fsf@gnu.org> <875xsrjoi9.fsf@gnu.org> <87v80qftk4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33496"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72313@debbugs.gnu.org, monnier@iro.umontreal.ca To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 27 23:26:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sXovj-0008Zh-6s for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Jul 2024 23:26:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sXovK-0007bj-8q; Sat, 27 Jul 2024 17:25:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXovI-0007b1-95 for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2024 17:25:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sXovI-0005nv-0L for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2024 17:25:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=HUHLKhJk4+KsJ4Eu+QDh4DiyHt7eO/qGjqH3A7z55Kg=; b=W12x5qvHX1J/NKiWJWtkG/iBH7aHBrz7UxzByf9dtvqbjYKImLJ6wL788Ore6TBrxr28wWftztEV1X9JDVvo7gOnXYekZxhBf2qkqzAuojZPFZX4wBHx8W+SqUd0payECiuISVV7ptX2z8WIYUUYphvTY0uApQJDRG/Hw3jYDN0s+JTp6pbkoAML6ZSNqMlWnjwU1+v/8E/tSclhRzxE2FfDN8QQ9xEvKEkOBqo4xg4vD9Pj6Q927Op2CCY4nnnNKMdxTzXcoCZRJIoCuanmJoZ29/lFrDHANSI1eFOYVEx+6LikNJJ6UXy7Sb+SJzeaFkc1/V7P8fdao2McaFTT5w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sXovS-0008Tz-7q for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2024 17:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Arash Esbati Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2024 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72313 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Stefan Monnier , 72313@debbugs.gnu.org Original-Received: via spool by 72313-submit@debbugs.gnu.org id=B72313.172211553632551 (code B ref 72313); Sat, 27 Jul 2024 21:26:02 +0000 Original-Received: (at 72313) by debbugs.gnu.org; 27 Jul 2024 21:25:36 +0000 Original-Received: from localhost ([127.0.0.1]:42503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXov1-0008Sx-La for submit@debbugs.gnu.org; Sat, 27 Jul 2024 17:25:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXov0-0008SV-Tm for 72313@debbugs.gnu.org; Sat, 27 Jul 2024 17:25:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXoul-0005fo-2Y; Sat, 27 Jul 2024 17:25:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HUHLKhJk4+KsJ4Eu+QDh4DiyHt7eO/qGjqH3A7z55Kg=; b=Qs44kZoStc3g81SV/Jvh H6dcjxBWjtGSLDjzhu53jz2ewlfWtt1JFf5CHGeA9Ds7kpOBObb4hgz2StTrsk+0s1LYMxN2R00mh sJIDC77gjjf6DJmM/09ITlQuzRoT3INjW9p/T+2t+rzHKsNUguD67OfYAnG51zLLAhgb6SwslRJ3i 46IiCjMRNns5XVYsKu63ZweUXnNSAbazY3MgenrlS35jX8isVntr4mKAZuocXjrwaySParzoFBl1P rLUUcvPv063fo2rPZiP5fBUkiwZ7TFyuZ0W6QXaNXKCLdX+wxUabCW4d3z+UspGKue2OfVjUgczq3 KgmNPKTqtMBm0g==; In-Reply-To: <87v80qftk4.fsf@gnu.org> (Tassilo Horn's message of "Sat, 27 Jul 2024 22:50:35 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289448 Archived-At: Tassilo Horn writes: > Let's just require cl-lib. declare-function only silences the > byte-compiler and the usage of cl-member at runtime is a fact; no > cheating allowed. It's also an implementation detail we should not > bother with. I'm not sure if this is cheating, but I'm easy, and if we want to require cl-lib, I'd do it in tex.el which is loaded by all .el files; so basically: --8<---------------cut here---------------start------------->8--- diff --git a/tex-info.el b/tex-info.el index dc69762e..4ae14401 100644 --- a/tex-info.el +++ b/tex-info.el @@ -24,9 +24,6 @@ ;;; Code: -(eval-when-compile - (require 'cl-lib)) - (require 'tex) (require 'texinfo) diff --git a/tex.el b/tex.el index e67d2059..729e4db2 100644 --- a/tex.el +++ b/tex.el @@ -33,8 +33,8 @@ (require 'custom) (require 'tex-site) +(require 'cl-lib) (eval-when-compile - (require 'cl-lib) (require 'subr-x)) (require 'texmathp) ;; seq.el is preloaded in Emacs 29, so the next form can be removed --8<---------------cut here---------------end--------------->8--- (plus some more changes to come). > Tomorrow, Stefan might have optimized it to use some cl-memql-1-wazzup > for the specific case we have here. :-) I will not put my money on another bet :) Best, Arash