From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Question about dubious code for terminal frames Date: Mon, 02 Sep 2024 11:04:02 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14258"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: martin rudalics To: Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 02 11:04:42 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sl2zJ-0003dP-Kj for ged-emacs-devel@m.gmane-mx.org; Mon, 02 Sep 2024 11:04:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sl2yn-0004BO-H2; Mon, 02 Sep 2024 05:04:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sl2ym-0004BD-6I for emacs-devel@gnu.org; Mon, 02 Sep 2024 05:04:08 -0400 Original-Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sl2yk-0006Wj-GG for emacs-devel@gnu.org; Mon, 02 Sep 2024 05:04:07 -0400 Original-Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a8696e9bd24so456673866b.0 for ; Mon, 02 Sep 2024 02:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725267844; x=1725872644; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=qEtFuH2dSX1r3gIJfNcHvUNUG1ezdmlH+P/UWMI7R3M=; b=aOBBRYuN0DaN4siQ88iaquTF9JhrNoOhpzW45+IUQuoRJiCnQpQfqIoqPH4qFGuTKM BuAB88egCCe7aFRoXFb7l59idJDEMMFzHv+am5woTpPwRKeUnp6uYX3PjDlu8yqBVge3 lK7WRi/JsUhRogQb14moVbsT8WpIof+5Y9RbtESe2jF3dYZwyJEm/o6nGdCQzdx+SbWQ yfJXr4nh/gyasfxQ9eEuz46Bo5JUXNBx8BXz/fIAjz4+3rPWZT4qjOy++E5uOGm0bRB4 dycb4VCKcIgvwj0J4kWWG9qgNkeF2cr3hq6iebMU4FCtBkcIRoO/wF11mPkfhD39qPu5 09pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725267844; x=1725872644; h=mime-version:user-agent:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qEtFuH2dSX1r3gIJfNcHvUNUG1ezdmlH+P/UWMI7R3M=; b=qxYD1KdeZX7DdUN+fZHgJZ9kKzt52XxIrUXZzzm/xdFNc3pZ+k8c7mtfooqXaQjU5p YB3/hMPOKKjnjkE5qKCFX4hHjQYoHzhjR2IEyTClL/n/tg7s7g9WqXqyoir+raEpdSm2 vIch2k9nMbL/4LpJkbV+BKyV3A09AYJp4y0JMrfmgP0xVCNusnsWIJX1ABmHnjSNuCTk t5OVBG9Cllv20zBv94Q56VdUIHntFxd3M5BBGx/6PaCgn+/oIWeucnXL832U9hA5Gbm5 OANvXeSwm/mNvHh1EyYY6DvdbF5UjRculyp+t48XrnXiAPLqSQ7Ku14CJLEINbY3kiPs UWnA== X-Gm-Message-State: AOJu0YxB+tYQCDkS0cyAWIo7gukiu9vB9oH8aH96JWGOMPrfUpUACWJU 2kO912sy+dbtrH+FA69Axib2Qrwc48lDfP5hycSikHrBjj6WnOO+WaUZcg== X-Google-Smtp-Source: AGHT+IEjuxR1zT58ryLj1jJBbcaDpU8MoE2al71+zSNoClYf4LBGbh4tafWR4EEEFUaCRnWFJ/Z4ew== X-Received: by 2002:a17:907:3ea2:b0:a80:aefa:14d3 with SMTP id a640c23a62f3a-a897fad6937mr999293166b.63.1725267844030; Mon, 02 Sep 2024 02:04:04 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3a928.dip0.t-ipconnect.de. [79.227.169.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8988feb0f0sm528326866b.20.2024.09.02.02.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 02:04:03 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323268 Archived-At: In 3 places, among them adjust_frame_size, which is why I CC'd Martin, Emacs sets the values of FrameRows/FrameCols. AFAIU, these two values give the physical size of a terminal (screen, window), as returned from the co and li escape sequences on termcap frames. And I can't find code that tries to change the physical size of the terminal, if that would even make sense in the first place :-). So this doesn't make any sense to me. Alas, the code in question has been so heavily modified over the decades that I can't find out where this code originates from. Maybe it's even something that I missed to fix when introducing the new redisplay, because in the old redisplay it might have mad>e sense for GUI frames. Maybe, don't remember. In any case, does someone have an idea what that code is for? If not, I suggest to remove it (and maybe making them rvalues or const).