From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Jeff Walsh <fejfighter@gmail.com>
Cc: 74224@debbugs.gnu.org
Subject: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling
Date: Wed, 06 Nov 2024 11:49:02 +0100 [thread overview]
Message-ID: <m2wmhgvdr5.fsf@gmail.com> (raw)
In-Reply-To: <CALohuRBd3GMPv61vEakw=WhJb4rG175+qtdxT3GB95RiDo6u6w@mail.gmail.com> (Jeff Walsh's message of "Wed, 6 Nov 2024 21:44:57 +1100")
Jeff Walsh <fejfighter@gmail.com> writes:
>> LGTM. Can you commit that yourself to the branch?
>
> I don't have a savannah account for emacs, but I have just registered and will chase up approvals.
>
> timers are cleaned up by cancel_atimer(), then they get put on a free list (`free_atimers` on line 132 in the snippet).
> It appears that we rely on the OS to cleanup at emacs shutdown.
Very good, thanks!
I'll commit that for you, then, and close this bug when done.
>
> On Wed, Nov 6, 2024 at 9:36 PM Gerd Möllmann <gerd.moellmann@gmail.com> wrote:
>
> Jeff Walsh <fejfighter@gmail.com> writes:
>
> > #ifdef WINDOWSNT
> > #define raise(s) w32_raise(s)
> > @@ -132,7 +133,13 @@ start_atimer (enum atimer_type type, struct timespec timestamp,
> > free_atimers = t->next;
> > }
> > else
> > - t = xmalloc (sizeof *t);
> > + {
> > +#ifdef HAVE_MPS
> > + t = igc_xzalloc_ambig (sizeof *t);
> > +#else
> > + t = xmalloc (sizeof *t);
> > +#endif
> > + }
> >
> > /* Fill the atimer structure. */
> > memset (t, 0, sizeof *t);
>
> On second thought, and I don't know if it's relevant, do we need to
> igc_xfree that?
next prev parent reply other threads:[~2024-11-06 10:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 8:04 bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling Fejfighter
2024-11-06 8:56 ` Gerd Möllmann
2024-11-06 9:30 ` Jeff Walsh
2024-11-06 10:34 ` Gerd Möllmann
2024-11-06 10:36 ` Gerd Möllmann
2024-11-06 10:44 ` Jeff Walsh
2024-11-06 10:49 ` Gerd Möllmann [this message]
2024-11-06 13:17 ` Eli Zaretskii
2024-11-06 13:39 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wmhgvdr5.fsf@gmail.com \
--to=gerd.moellmann@gmail.com \
--cc=74224@debbugs.gnu.org \
--cc=fejfighter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.