From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filippo Argiolas Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] new package: eglot-inactive-regions Date: Tue, 03 Dec 2024 23:02:54 +0100 Message-ID: References: <874j3nrri7.fsf@posteo.net> <878qswlfty.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28486"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Gerd =?utf-8?Q?M=C3=B6llmann?= , Stefan Kangas To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 03 23:03:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIazp-0007Dr-Fz for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Dec 2024 23:03:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIaz4-0000E9-Tk; Tue, 03 Dec 2024 17:03:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIaz2-0000Dk-DY for emacs-devel@gnu.org; Tue, 03 Dec 2024 17:03:04 -0500 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIaz0-00072D-7o for emacs-devel@gnu.org; Tue, 03 Dec 2024 17:03:04 -0500 Original-Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-434a752140eso51259465e9.3 for ; Tue, 03 Dec 2024 14:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733263378; x=1733868178; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=mpsGbV/M0j8eWao+hLdg7S415Tbdd5Q8rBfKeD3VCHM=; b=RdvKaCva8BpmVyDcPLQoaJmbhKuhH9Nn2YTfZerWtLhXcLlwebNdUtgfTZFLBJLJm7 HSbiL1fiHOTBNkJrTW5ekfm8vLrPvN/zsuGdBIxGMr39cQjX6ROOcHGNz0EjjbRr/kMe 3U751rQh2FqAW13q88QgVVVosBdIv9trWc/Rq40nwUyV+Dt6WlJXllSM6znub8XePfXc jySfcKziMOkJ9kRZfHAkhMvVLfdnBUm7yuQpZPhtJVPndWHxsTs+XvreZKahKHg0wa3Y UF/GXZrRyFsjuJsb3Jc9QQFgm9FVUFPtreuvJ8PF97eVJe8MPcFLmpbKndVbefwRE+xi AB+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733263378; x=1733868178; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mpsGbV/M0j8eWao+hLdg7S415Tbdd5Q8rBfKeD3VCHM=; b=lU9eX05P2+8zS2n/E/c8wC0O541EbavRdz8BQ3q8izgTGCmusIptSMD+Gc9Pi6JVyT Fl8qaAlrdh6k+jV97p0Ap9sGG0zlQef/Eu3juQeEixRQ/DQBRyStW2hKioZfYBskONxB KNpLDYACzMO3xKC6aBFh06kx8zJqAoxed33uOufbzCH3UEfFaD6koHdbqCq7Gzw9HREI bnkNn50Wpr8C+4dBWf6bXpOkapLR2vwyLBdH6KZRAW0iEb5zzHCTYlnsJAf8teFcPe5o rHjJ9ugCOwmG+L/0bcgdRT0S1V7Y+qGtlj51CmAyOoPFo/aqD41hjOEgZDTZvADHNvnM dUkw== X-Gm-Message-State: AOJu0Yy8HQXqelMTkoUAFHS2L0OCmsUVsk1UEtEh4aPTXyKIjZRxSlPY RPgld5S0oYcW9z1aWBWBQQocV9AS5w95LzaK9+kcbJmHCBiHirWj X-Gm-Gg: ASbGncskW7cBl6xgvfdDvo56iWFWG/a62xqO53xeuDRqpE52nQH3KoGlQvaWMf7XPMF QM6BZSlv4TEZh+LTLnIMRRcx1JMcu4McdmdtlVuCy1CFTlFkESdu1UTjqdQBLV+olp1OfyZVFHQ ecNo8Rl8NiS5s+EUzkQyc8oOXd+hlKmeo58RHng/Qh7XUW/nEwpbY13VUV7a7uEX7ztLpynO7Xa THXQZylF09w2vjKx8W4c61lrv+Y1lkwg0sakiapehD5h2g1kfzUFbN74EU= X-Google-Smtp-Source: AGHT+IHCIx3i08peayv3QySOTrintoZ+MLNIWdxfWl4bn7iePQUujhaXwzxEDkOKrhqL0VkDcqM85A== X-Received: by 2002:a05:6000:4025:b0:385:ee59:44f1 with SMTP id ffacd0b85a97d-385fd3e9c41mr3485079f8f.20.1733263378195; Tue, 03 Dec 2024 14:02:58 -0800 (PST) Original-Received: from mba ([151.81.191.240]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d52c0bfasm1287525e9.32.2024.12.03.14.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 14:02:57 -0800 (PST) In-Reply-To: <878qswlfty.fsf@posteo.net> Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=filippo.argiolas@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326008 Archived-At: Philip Kaludercic writes: > Filippo Argiolas writes: > >> Philip Kaludercic writes: >> >>> Filippo Argiolas writes: >>> >>>> Hi all, >>>> >>>> a couple of weeks ago I submitted my clangd-inactive-regions package >>>> NonGNU ELPA inclusion. Previous discussion led to renaming the package >>>> to make it more general, so I am submitting it again. >>>> >>>> For whom who missed it, it's a little Eglot extension to visually style >>>> inactive preprocessor branches in c/cpp code in a LSP powered way. >>>> >>>> You can find more at: >>>> https://github.com/fargiolas/eglot-inactive-regions >>> >>> Here are a few comments and alternatives that you might be interested >>> in: >> >> Thanks for the review, much appreciated! >> Just a few comments below. >> >>> @@ -65,17 +66,15 @@ >>> Used to mix foreground and background colors and apply to the foreground >>> face of the inactive region. The lower the blending factor the more >>> text will look dim." >>> - :type '(float :tag "Opacity" :min 0.0 :max 1.0) >>> - :set #'eglot-inactive-regions--set-and-refresh >>> - :group 'inactive-regions) >>> + :type '(float :tag "Opacity" :min 0.0 :max 1.0) ;:min and :max >>> have no effect, but you can use :validate >>> + :set #'eglot-inactive-regions--set-and-refresh) >> >> No idea how I came up with those, I was sure to have used another mode >> as inspiration but it seems those are pure allucinations :) >> >>> @@ -157,13 +152,13 @@ Only applies to `shade-background' style." >>> "Linearly interpolate between two colors. >>> Blend colors FROM-COLOR and TO-COLOR with ALPHA interpolation >>> factor." >>> - (if-let ((from-rgb (color-name-to-rgb from-color)) >>> - (to-rgb (color-name-to-rgb to-color)) >>> - (alpha (min 1.0 (max 0.0 alpha)))) >>> - (apply 'color-rgb-to-hex >>> - (cl-mapcar #'(lambda (a b) (+ (* a alpha) (* b (- 1.0 alpha)))) >>> + (if-let* ((from-rgb (color-name-to-rgb from-color)) >>> + (to-rgb (color-name-to-rgb to-color)) >>> + (alpha (min 1.0 (max 0.0 alpha)))) >>> + (apply #'color-rgb-to-hex >>> + (cl-mapcar (lambda (a b) (+ (* a alpha) (* b (- 1.0 alpha)))) >>> from-rgb to-rgb)) >>> - 'unspecified)) >>> + 'unspecified)) >> >> Why the star variant if I don't need to bind variables sequentially? is >> it just for future-proofness? > > The star-less version has been recently deprecated on the master branch. > And despite not using the variables in subsequent terms, I like to > imagine that if-let* makes more sense since the terms are still > explicitly evaluated in the order in which they are listed. > Furthermore, if you take a look at if-let, you will see that it is > implemented in terms of if-let* which means that the bindings remain > visible even if the name doesn't indicate that. > >>> @@ -197,7 +192,10 @@ If the correspondend \"eglot-inactive\" face doesn't not exist yet create it." >>> (eglot-inactive-face (intern eglot-inactive-face-name)) >>> (eglot-inactive-doc (concat (face-documentation parent-face) doc-suffix))) >>> (unless (facep eglot-inactive-face) >>> - (eval `(defface ,eglot-inactive-face '((t nil)) ,eglot-inactive-doc))) >>> + (custom-declare-face >>> + eglot-inactive-face >>> + '((t nil)) >>> + eglot-inactive-doc)) >>> (set-face-foreground eglot-inactive-face eglot-inactive-fg) >>> eglot-inactive-face)) >> >> Nice, I always struggle with eval quoting, definitely better with your version. > > Just double check that it works as intended. > >>> @@ -207,10 +205,14 @@ Some mode use `default' face for both generic keywords and >>> whitespace while some other uses nil for whitespace. Either way >>> we don't want to include whitespace in fontification." >>> (let* ((prev-face (get-text-property (point) 'face)) >>> - (_ (forward-char)) >>> - (next-face (get-text-property (point) 'face))) >>> + (next-face (progn >>> + (forward-char) >>> + (get-text-property (point) 'face)))) >>> (while (and (eq prev-face next-face) >>> - (not (thing-at-point 'whitespace))) >>> + ;; what are you trying to do here? if you want to >>> + ;; check if you are not on whitespace, consider >>> + ;; something like (looking-at-p "[^[:space:]]"). >>> + (not (thing-at-point 'whitespace))) >>> (setq prev-face (get-text-property (point) 'face)) >>> (forward-char) >>> (setq next-face (get-text-property (point) 'face))))) >> >> Idea here is to jump to the next face change or whitespace. I believe I >> wanted to avoid applying shaded faces to empty space. Probably I could >> use a mix of `next-single-property-change' and `looking-at-p'. It's old >> code I never got to review, will take a better look in the next few >> days. Maybe there's no point of skipping whitespace after all. > > I would suspect that it would be easier and more efficient not to have > to think about having multiple separate properties. Removed that function altogether, just using `next-single-property-change' seems good. >>> @@ -280,16 +282,16 @@ Useful to update colors after a face or theme change." >>> (dolist (range eglot-inactive-regions--ranges) >>> (let ((beg (car range)) >>> (end (cdr range))) >>> - (cond >>> - ((eq eglot-inactive-regions-style 'darken-foreground) >>> + (pcase-exhaustive eglot-inactive-regions-style >>> + ('darken-foreground >>> (with-silent-modifications >>> (put-text-property beg end 'eglot-inactive-region t)) >>> (font-lock-flush)) >>> - ((eq eglot-inactive-regions-style 'shadow-face) >>> + ('shadow-face >>> (let ((ov (make-overlay beg end))) >>> (overlay-put ov 'face 'eglot-inactive-regions-shadow-face) >>> (push ov eglot-inactive-regions--overlays))) >>> - ((eq eglot-inactive-regions-style 'shade-background) >>> + ('shade-background >>> (let ((ov (make-overlay beg (1+ end)))) >>> (overlay-put ov 'face 'eglot-inactive-regions-shade-face) >>> (push ov eglot-inactive-regions--overlays)))))))) >> >> Isn't pcase overkill if no complex pattern matching is involved? > > It compiles down to the same (byte)code, so there is no overhead > > (macroexpand-all > '(pcase foo > ('one 1) > ('two 2))) > ;=> (cond ((eq foo 'one) (let nil 1)) ((eq foo 'two) (let nil 2))) > > and `pcase-exhaustive' raises an error earlier if the variable is in an > unexpected state. > >>> @@ -320,7 +322,7 @@ Useful to update colors after a face or theme change." >>> >>> (defun eglot-inactive-regions--handle-notification (uri regions) >>> "Update inactive REGIONS for the buffer corresponding to URI." >>> - (when-let* ((path (expand-file-name (eglot--uri-to-path uri))) >>> + (when-let* ((path (expand-file-name (eglot--uri-to-path uri))) >>> ;note that this function is deprecated! >> >> I know, I believe I was even involved in deprecating it. At first I was >> using the new version but a user forked the repo to make it work in 29.1 >> where both functions are still private. >> >> What's the proper way to handle this without losing backwards >> compatibility? > > I would try something of the form like > > (if (fboundp 'new-function) > (new-function ...) > (old-function ...)) > > If on the other hand there has already been a new release of Eglot with > these commands, then just depend on that version and the issue would > resolve itself. > Thanks again for the review and for the useful explanations. I pushed your suggested changes to master. Will test it a bit and bump version if everything seems ok. Filippo