From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#11442: dbus uses Emacs integer as pointer, possible core dump Date: Wed, 09 May 2012 17:45:19 +0200 Message-ID: References: <4FAA8B59.8050207@cs.ucla.edu> <87y5p1l63u.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1336578366 3951 80.91.229.3 (9 May 2012 15:46:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 9 May 2012 15:46:06 +0000 (UTC) Cc: 11442@debbugs.gnu.org, Paul Eggert To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 09 17:46:04 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SS95Y-0008H9-0X for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 May 2012 17:46:04 +0200 Original-Received: from localhost ([::1]:49320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS95X-0007Dj-3Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 May 2012 11:46:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS95T-0007DR-S4 for bug-gnu-emacs@gnu.org; Wed, 09 May 2012 11:46:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SS95J-0002Ik-Mt for bug-gnu-emacs@gnu.org; Wed, 09 May 2012 11:45:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS95J-0002IW-Hl for bug-gnu-emacs@gnu.org; Wed, 09 May 2012 11:45:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SS97R-0000ZW-GT for bug-gnu-emacs@gnu.org; Wed, 09 May 2012 11:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 May 2012 15:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11442 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11442-submit@debbugs.gnu.org id=B11442.13365784592168 (code B ref 11442); Wed, 09 May 2012 15:48:01 +0000 Original-Received: (at 11442) by debbugs.gnu.org; 9 May 2012 15:47:39 +0000 Original-Received: from localhost ([127.0.0.1]:43400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SS974-0000Yt-7Q for submit@debbugs.gnu.org; Wed, 09 May 2012 11:47:39 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:50467) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SS971-0000Yl-Py for 11442@debbugs.gnu.org; Wed, 09 May 2012 11:47:37 -0400 Original-Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3VnhjD6NLdz3hhVL; Wed, 9 May 2012 17:45:19 +0200 (CEST) Original-Received: from igel.home (ppp-88-217-114-242.dynamic.mnet-online.de [88.217.114.242]) by mail.mnet-online.de (Postfix) with ESMTPA id 3VnhjC5pLdz4KK2v; Wed, 9 May 2012 17:45:19 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 501) id 5A24CCA2AA; Wed, 9 May 2012 17:45:19 +0200 (CEST) X-Yow: Boys, you have ALL been selected to LEAVE th' PLANET in 15 minutes!! In-Reply-To: <87y5p1l63u.fsf@gmx.de> (Michael Albinus's message of "Wed, 09 May 2012 17:35:49 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.96 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59891 Archived-At: Michael Albinus writes: > Paul Eggert writes: > > Hi Paul, > >> The trunk version of Emacs src/dbusbind.c contains a function >> xd_get_connection_address that does this: >> >> connection = (DBusConnection *) (intptr_t) XFASTINT (val); >> >> This converts an Emacs integer to a pointer without checking >> that it is actually of the proper C type. It is possible >> for Lisp code to mistakenly put an integer there that will >> cause Emacs to dump core. > > In general, I agree with you. In the given case, it is just a pointer > address which has been written in Fdbus_init_bus. No other place is > expected to write such an address, but since it is a Lisp object, > somebody could do by mistake. Why is Vdbus_registered_buses exported to lisp? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."