From: Alan Schmitt <alan.schmitt@polytechnique.org>
To: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: evaluation issue with ocaml code (due to changes to org-babel-comint-with-output)
Date: Fri, 18 Dec 2015 09:18:56 +0100 [thread overview]
Message-ID: <m2vb7wp3tb.fsf@charm-ecran.irisa.fr> (raw)
In-Reply-To: <m2d1u6f88e.fsf@polytechnique.org> (Alan Schmitt's message of "Wed, 16 Dec 2015 21:29:05 +0100")
[-- Attachment #1: Type: text/plain, Size: 2828 bytes --]
Hello,
Can I push this?
Thanks,
Alan
On 2015-12-16 21:29, Alan Schmitt <alan.schmitt@polytechnique.org> writes:
> Hello,
>
> I finally found the issue (using the plain debugger): the call to
> org-babel-comint-with-output was set to remove the echo, but the only
> time there is an echo of the full body is when a single line function
> has an error, and this echo is useful to show where the error is. Here
> is a patch that makes sure the echo is kept.
>
> From 59e6912e6bf769fff2f48b6c2af95bda918d0cd9 Mon Sep 17 00:00:00 2001
> From: Alan Schmitt <alan.schmitt@polytechnique.org>
> Date: Wed, 16 Dec 2015 21:19:23 +0100
> Subject: [PATCH] ob-ocaml.el: Keep echo to display ocaml errors
>
> * ob-ocaml.el (org-babel-execute:ocaml): call
> `org-babel-comint-with-output' with nil `remove-echo' argument.
> ---
> lisp/ob-ocaml.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/ob-ocaml.el b/lisp/ob-ocaml.el
> index 48f8aba..68ac859 100644
> --- a/lisp/ob-ocaml.el
> +++ b/lisp/ob-ocaml.el
> @@ -66,7 +66,7 @@
> (session (org-babel-prep-session:ocaml
> (cdr (assoc :session params)) params))
> (raw (org-babel-comint-with-output
> - (session org-babel-ocaml-eoe-output t full-body)
> + (session org-babel-ocaml-eoe-output nil full-body)
> (insert
> (concat
> (org-babel-chomp full-body) ";;\n"
> --
> 2.6.4
>
>
> For the record, the problem I wanted to fix.
>
> On 2015-12-14 13:04, Alan Schmitt <alan.schmitt@polytechnique.org> writes:
>
>>> I have found that commit f0bf77e82a3d37ba7548aa40198bc982e9875f1b breaks
>>> evaluation of ocaml code. With the following init file (the
>>> `package-initialize' is there for tuareg to be available):
>>>
>>> #+begin_src emacs-lisp
>>> (add-to-list 'load-path "/Users/schmitta/projets/org-mode/lisp")
>>>
>>> (require 'org)
>>>
>>> (package-initialize)
>>>
>>> (org-babel-do-load-languages
>>> 'org-babel-load-languages
>>> '((ocaml . t)))
>>> #+end_src
>>>
>>> When I evaluate this block I get this result:
>>>
>>> #+BEGIN_SRC ocaml :results code verbatim :exports results
>>> 1 + "toto";;
>>> #+END_SRC
>>>
>>> #+results:
>>> #+BEGIN_SRC ocaml
>>> Characters 4-10:
>>> 1 + "toto";;;;
>>> ^^^^^^
>>> Error: This expression has type string but an expression was expected of type
>>> int
>>> #+END_SRC
>>>
>>> After commit f0bf77e82a3d37ba7548aa40198bc982e9875f1b I get this:
>>>
>>> #+results:
>>> #+BEGIN_SRC ocaml
>>> ;;
>>> ^^^^^^
>>> Error: This expression has type string but an expression was expected of type
>>> int
>>> #+END_SRC
>
> Best,
>
> Alan
--
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated December 13, 2015, Mauna Loa Obs.): 401.31 ppm
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2015-12-18 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 9:14 evaluation issue with ocaml code (due to changes to org-babel-comint-with-output) Alan Schmitt
2015-12-14 12:04 ` Alan Schmitt
2015-12-16 20:29 ` Alan Schmitt
2015-12-18 8:18 ` Alan Schmitt [this message]
2015-12-18 21:38 ` Nicolas Goaziou
2015-12-21 8:06 ` Alan Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vb7wp3tb.fsf@charm-ecran.irisa.fr \
--to=alan.schmitt@polytechnique.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.